Skip to content

[Due for payment 2025-06-18] [$125] Update the adhoc build message to say a build was skipped and not failed #59843

Closed

Description

@mountiny

Problem

When we create adhoc builds, we can select platforms to run them for. When we skip some platform, the adhoc builds message still says the build failed #59835 (comment)

That is confusing as its same message as if you actually tried to build those platforms and the builds failed.

Solution

If the platform was not chosen to be built, update the message for the platform to ⏩ SKIPPED ⏩

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021909655979936056229
  • Upwork Job ID: 1909655979936056229
  • Last Price Increase: 2025-04-08
  • Automatic offers:
    • mkzie2 | Contributor | 106839778
Issue OwnerCurrent Issue Owner: @sonialiap

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 8, 2025
  2. self-assigned this
    on Apr 8, 2025
  3. melvin-bot commented on Apr 8, 2025

    @melvin-bot
  4. changed the title [-]Update the adhoc build message to say a build was skipped and not failed[/-] [+][$250] Update the adhoc build message to say a build was skipped and not failed[/+] on Apr 8, 2025
  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 8, 2025
  6. melvin-bot commented on Apr 8, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

  7. melvin-bot commented on Apr 8, 2025

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  8. changed the title [-][$250] Update the adhoc build message to say a build was skipped and not failed[/-] [+][$125] Update the adhoc build message to say a build was skipped and not failed[/+] on Apr 8, 2025
  9. melvin-bot commented on Apr 8, 2025

    @melvin-bot

    Upwork job price has been updated to $125

  10. mkzie2 commented on Apr 8, 2025

    @mkzie2
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-04-08 17:26:09 UTC.

    Please re-state the problem that we are trying to solve in this issue.

    Update the adhoc build message to say a build was skipped and not failed

    What is the root cause of that problem?

    We're showing "Failed"

    const link = isSuccess ? core.getInput(`${platform}_LINK`) : '❌ FAILED ❌';

    const link = isSuccess ? core.getInput(`${platform}_LINK`) : '❌ FAILED ❌';

    What changes do you think we should make in order to solve the problem?

    Update to "⏩ SKIPPED ⏩" if the input is skipped:

    const input = core.getInput(platform, {required: false});

    const isSkipped = input === 'skipped';
    const link = isSuccess ? core.getInput(`${platform}_LINK`) : isSkipped ? '⏩ SKIPPED ⏩' : '❌ FAILED ❌';
    const qrCode = isSuccess
                ? `![${names[platform]}](https://api.qrserver.com/v1/create-qr-code/?size=120x120&data=${link})`
                isSkipped
                ? 'Skipped the build'
                : `The QR code can't be generated, because the ${names[platform]} build failed`;

    input here can be of 4 values:

    type PlatformResult = 'success' | 'cancelled' | 'skipped' | 'failure';

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    We can update postTestBuildComment unit test to cover the skipped case and Skipped text.

    What alternative solutions did you explore? (Optional)

    None

  11. github-actions commented on Apr 8, 2025

    @github-actions
    Contributor

    ⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

  12. 19 remaining items

  13. melvin-bot commented on Jun 11, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Jun 11, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.64-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-06-18. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Jun 11, 2025

    @melvin-bot

    @mountiny @sonialiap @mkzie2 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. mkzie2 commented on Jun 18, 2025

    @mkzie2
    Contributor

    @sonialiap We do not need regression test here since it was just to update the Github workflow. Ready for payment now.

  17. mountiny commented on Jun 18, 2025

    @mountiny
    ContributorAuthor

    Agreed no tests required

  18. sonialiap commented on Jun 20, 2025

    @sonialiap
    Contributor

    @mkzie2 new offer sent in upwork (the old one expired)

  19. sonialiap commented on Jun 23, 2025

    @sonialiap
    Contributor

    Payment completed ✔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions