You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-06-18] [$125] Update the adhoc build message to say a build was skipped and not failed #59843
When we create adhoc builds, we can select platforms to run them for. When we skip some platform, the adhoc builds message still says the build failed #59835 (comment)
That is confusing as its same message as if you actually tried to build those platforms and the builds failed.
Solution
If the platform was not chosen to be built, update the message for the platform to ⏩ SKIPPED ⏩
changed the title [-]Update the adhoc build message to say a build was skipped and not failed[/-][+][$250] Update the adhoc build message to say a build was skipped and not failed[/+]on Apr 8, 2025
changed the title [-][$250] Update the adhoc build message to say a build was skipped and not failed[/-][+][$125] Update the adhoc build message to say a build was skipped and not failed[/+]on Apr 8, 2025
⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.64-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@mountiny@sonialiap@mkzie2 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Apr 8, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021909655979936056229
[-]Update the adhoc build message to say a build was skipped and not failed[/-][+][$250] Update the adhoc build message to say a build was skipped and not failed[/+]melvin-bot commentedon Apr 8, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (
External)melvin-bot commentedon Apr 8, 2025
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-][$250] Update the adhoc build message to say a build was skipped and not failed[/-][+][$125] Update the adhoc build message to say a build was skipped and not failed[/+]melvin-bot commentedon Apr 8, 2025
Upwork job price has been updated to $125
mkzie2 commentedon Apr 8, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-04-08 17:26:09 UTC.
Please re-state the problem that we are trying to solve in this issue.
Update the adhoc build message to say a build was skipped and not failed
What is the root cause of that problem?
We're showing "Failed"
App/.github/actions/javascript/postTestBuildComment/postTestBuildComment.ts
Line 26 in 7af0310
App/.github/actions/javascript/postTestBuildComment/index.js
Line 11519 in 5851537
What changes do you think we should make in order to solve the problem?
Update to "⏩ SKIPPED ⏩" if the
inputisskipped:App/.github/actions/javascript/postTestBuildComment/postTestBuildComment.ts
Line 17 in 7af0310
App/.github/actions/javascript/postTestBuildComment/postTestBuildComment.ts
Line 24 in 7af0310
inputhere can be of 4 values:App/.github/actions/javascript/markPullRequestsAsDeployed/markPullRequestsAsDeployed.ts
Line 10 in 8dc83c3
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We can update
postTestBuildCommentunit test to cover the skipped case andSkippedtext.What alternative solutions did you explore? (Optional)
None
github-actions commentedon Apr 8, 2025
19 remaining items
melvin-bot commentedon Jun 11, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 11, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.64-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-06-18. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 11, 2025
@mountiny @sonialiap @mkzie2 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
mkzie2 commentedon Jun 18, 2025
@sonialiap We do not need regression test here since it was just to update the Github workflow. Ready for payment now.
mountiny commentedon Jun 18, 2025
Agreed no tests required
sonialiap commentedon Jun 20, 2025
@mkzie2 new offer sent in upwork (the old one expired)
sonialiap commentedon Jun 23, 2025
Payment completed ✔