Repository navigation
[No QA] Update the adhoc build message to say a build was skipped and not failed - #59847
Conversation
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Testing, no need for C+ review? |
|
🚧 @mountiny has triggered a test app build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
We also have Hybrid adhoc build. Does these changes also cover that? |
|
Can you run the build actions npm script |
|
@mountiny Is it @parasharrajat We don't build Standalone no more #59835. |
|
@mountiny I also think we should remove this row from the result table. It might have been used to separate Standalone & HybridApp builds. |
|
Seems like it did not really work, right? |
|
@mountiny I found the fix. Can you trigger the adhoc build? |
|
🚧 @mountiny has triggered a test app build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
Still it does not seem like it posted the right messages |
|
The root cause is that the |
|
@mountiny Please help to trigger adhoc build. |
|
🚧 @mountiny has triggered a test app build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
| # - PR: https://github.com/rhysd/actionlint/pull/513 | ||
| - '"env" is not allowed in "runs" section because .* is a Composite action.*' | ||
| # Temporary workaround to fix actionlint not recognizing jobs.<job_id>.result | ||
| - 'property "result" is not defined in object type \{outputs: \{.*\}\}' |
There was a problem hiding this comment.
changes look good to me except this, can we update the code so we do not have to add this?
There was a problem hiding this comment.
@mountiny actionlint builds the validation schema by crawling GH Actions documentation (reference here), specifically this table. But that table is missing the entry for jobs.<job_id>.result. So we need to raise a PR to fix the GH documentation which will probably blocks this ticket longer. Does it sound good to you?
There was a problem hiding this comment.
I am not too happy to add more exceptions here, but I think its OK got now
There was a problem hiding this comment.
@mkzie2 Could you raise the upstream issue and PR and add it here same as the comment above?
| ANDROID: | ||
| value: ${{ jobs.androidHybrid.result }} | ||
| IOS: | ||
| value: ${{ jobs.iosHybrid.result }} |
There was a problem hiding this comment.
Could you also add the result into the output of those actions and avoid changing the actionlint?
There was a problem hiding this comment.
Those actions will be automatically skipped so no output is yielded.
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
| # - PR: https://github.com/rhysd/actionlint/pull/513 | ||
| - '"env" is not allowed in "runs" section because .* is a Composite action.*' | ||
| # Temporary workaround to fix actionlint not recognizing jobs.<job_id>.result | ||
| - 'property "result" is not defined in object type \{outputs: \{.*\}\}' |
There was a problem hiding this comment.
I am not too happy to add more exceptions here, but I think its OK got now
| # - PR: https://github.com/rhysd/actionlint/pull/513 | ||
| - '"env" is not allowed in "runs" section because .* is a Composite action.*' | ||
| # Temporary workaround to fix actionlint not recognizing jobs.<job_id>.result | ||
| - 'property "result" is not defined in object type \{outputs: \{.*\}\}' |
There was a problem hiding this comment.
@mkzie2 Could you raise the upstream issue and PR and add it here same as the comment above?
|
Still researching the |
|
It seems that we cannot simply update GH documentation like I mentioned previously. I'm investigating actionlint codebase https://github.com/rhysd/actionlint to fix this. It's written in Golang so quite takes a few time. |
|
@mkzie2 thanks! lets try to wrap this up |
|
Still researching the upstream codebase. Should be completed in end of week. |
|
I just came across this one where they will combine @mountiny What do you think about putting this on hold for that ticket? |
|
Yeah lets wait for that! |
|
@mountiny This is off hold. Can you retest? |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
@mountiny Seems like it worked well. |
mountiny
left a comment
There was a problem hiding this comment.
Thank you for your patience
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.64-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.1.64-5 🚀
|

cc @mountiny to trigger adhoc builds
Explanation of Change
Fixed Issues
$ #59843
PROPOSAL: #59843 (comment)
Tests
None
Offline tests
None
QA Steps
None
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop