You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Better Expense Report View] Update the report preview action #60214
We are inconsistent with what report total we use in the report action buttons in the workspace chat when the user can, for example, submit a report of a certain value.
Solution
Let's clean this up to achieve this set-up:
Submit: use overall report total
Review: use overall report total
Approve: use overall report total
Pay: only use the amount that would actually be paid
Export: we don't use the total here
Let's abstract this logic into a separate method and cover its logic with automated tests.
Note this means we would also include the held items values in the overall report total - as we already show the hold modal for the users to confirm before action is actually completed.
Activity
melvin-bot commentedon Apr 14, 2025
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.mountiny commentedon Apr 14, 2025
cc @JmillsExpensify @shawnborton for vis
shawnborton commentedon Apr 15, 2025
Looks good, thanks for making the issue!
JakubKorytko commentedon Apr 17, 2025
I can take care of this, please assign it to me.
trjExpensify commentedon Apr 17, 2025
Done!
melvin-bot commentedon Apr 24, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
allgandalf commentedon May 6, 2025
PR is on production, @JakubKorytko is there a follow up or are we good to close ?
trjExpensify commentedon May 9, 2025
Bump on the Q @JakubKorytko? I think we can close this, personally.
JakubKorytko commentedon May 9, 2025
Yes, sorry, forgot to reply, I agree this can be closed, no issues have been raised for a long time and the amount looks fine.
trjExpensify commentedon May 9, 2025
Dope!