Skip to content

[Better Expense Report View] Update the report preview action #60214

Closed

Description

@mountiny

Problem

We are inconsistent with what report total we use in the report action buttons in the workspace chat when the user can, for example, submit a report of a certain value.

Solution

Let's clean this up to achieve this set-up:

  • Submit: use overall report total
  • Review: use overall report total
  • Approve: use overall report total
  • Pay: only use the amount that would actually be paid
  • Export: we don't use the total here

Let's abstract this logic into a separate method and cover its logic with automated tests.

Note this means we would also include the held items values in the overall report total - as we already show the hold modal for the users to confirm before action is actually completed.

Issue OwnerCurrent Issue Owner: @JakubKorytko

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 14, 2025
  2. self-assigned this
    on Apr 14, 2025
  3. melvin-bot commented on Apr 14, 2025

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. mountiny commented on Apr 14, 2025

    @mountiny
    ContributorAuthor
  5. moved this to Second Cohort - CRITICAL in [#whatsnext] #migrateon Apr 14, 2025
  6. shawnborton commented on Apr 15, 2025

    @shawnborton
    Contributor

    Looks good, thanks for making the issue!

  7. JakubKorytko commented on Apr 17, 2025

    @JakubKorytko
    Member

    I can take care of this, please assign it to me.

  8. trjExpensify commented on Apr 17, 2025

    @trjExpensify
    Contributor

    Done!

  9. melvin-bot commented on Apr 24, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  10. allgandalf commented on May 6, 2025

    @allgandalf
    Contributor

    PR is on production, @JakubKorytko is there a follow up or are we good to close ?

  11. trjExpensify commented on May 9, 2025

    @trjExpensify
    Contributor

    Bump on the Q @JakubKorytko? I think we can close this, personally.

  12. JakubKorytko commented on May 9, 2025

    @JakubKorytko
    Member

    Yes, sorry, forgot to reply, I agree this can be closed, no issues have been raised for a long time and the amount looks fine.

  13. trjExpensify commented on May 9, 2025

    @trjExpensify
    Contributor

    Dope!

  14. moved this from Second Cohort - CRITICAL to Done in [#whatsnext] #migrateon May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions