You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Google location link is being cut off and placed in a new line #6216
changed the title [-]Google location link is being cut off and places in a new line before a Period[/-][+]Google location link is being cut off and placed in a new line[/+]on Nov 4, 2021
First of all, I don't think its being "cut and placed in a new line", the main problem here is that the regex doesn't matches with some characteres( . , = ( + $ ! * ) right before /, we can reproduce this problem putting any of those characteres instead of . in the url
-\w~@:%)
E.G.:
Input: https://www.google.com/maps/place/Poster+Auctions+International,+Inc./test
Will match with: https://www.google.com/maps/place/Poster+Auctions+International,+Inc
Ignoring all the rest of the link
If this could be external I would like to fix this issue:
PROPOSAL
We have to add support to . and all the others characteres to the regex:
At ExpensiMark.js we have to change URL_PATH_REGEX
Activity
MelvinBot commentedon Nov 4, 2021
Triggered auto assignment to @flodnv (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.[-]Google location link is being cut off and places in a new line before a Period[/-][+]Google location link is being cut off and placed in a new line[/+]mateusbra commentedon Nov 6, 2021
First of all, I don't think its being "cut and placed in a new line", the main problem here is that the regex doesn't matches with some characteres( . , = ( + $ ! * ) right before /, we can reproduce this problem putting any of those characteres instead of . in the url
-\w~@:%)
E.G.:
Input:
https://www.google.com/maps/place/Poster+Auctions+International,+Inc./testWill match with:
https://www.google.com/maps/place/Poster+Auctions+International,+IncIgnoring all the rest of the link
If this could be external I would like to fix this issue:
PROPOSAL
We have to add support to . and all the others characteres to the regex:
At ExpensiMark.js we have to change URL_PATH_REGEX
https://github.com/Expensify/expensify-common/blob/e6ba00d53b8119fa0e641ed1544257ac4bcb9aec/lib/ExpensiMark.js#L6-L10
We will have:
This way we guarantee any url will match with our REGEX even with thoses characteres in the end of the link, like what Github does.
mateusbra commentedon Nov 6, 2021
Test with code changes:
MelvinBot commentedon Nov 8, 2021
Triggered auto assignment to @jboniface (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.7 remaining items
mateusbra commentedon Nov 8, 2021
Proposal posted in upwork! Once it be accepted I'll rise the PR.
mateusbra commentedon Nov 11, 2021
@jboniface have you seen my proposal in upwork?
mallenexpensify commentedon Nov 12, 2021
Hired "Matheus B" in Upwork! @mateusbra, when do you expect to have a PR submitted?
mateusbra commentedon Nov 12, 2021
@mallenexpensify PR submitted!
botify commentedon Nov 16, 2021
@pecanoro @jboniface Be sure to fill out the Contact List!
mateusbra commentedon Nov 18, 2021
@mallenexpensify when do you expect this job to be payed in UpWork?
pecanoro commentedon Nov 18, 2021
@mateusbra We wait 7 days to check out for regressions. It is mentioned in the contributor's guidelines.
Anyways, going to reopen since I think Botify closed it too fast and we still need to handle payment. cc/ @jboniface
mateusbra commentedon Nov 25, 2021
Do you think payment could be done? PR was merged has 10 days
dylanexpensify commentedon Nov 29, 2021
@mateusbra I can handle payment today! Thanks for your patience and sorry about that!
dylanexpensify commentedon Nov 29, 2021
@mateusbra payment sent, contract closed!
botify commentedon Nov 29, 2021
@pecanoro @jboniface Be sure to fill out the Contact List!