You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-06-02] [Better Expense Report View] Add the skeleton loading UI when clicking into a report from a preview in a chat. #62198
show the same standard skeleton rows that we have on the reports page when the report is loading
I don't think we need to try get cute with the violations or the comments below the table, I think I'd just do something simple like this (but maybe remove the button shape from the right side of each row)
Question though: can we detect if we're using the multi-expense report layout? Because the single-expense report layout should probably load more like a chat does, right? Ooof, another good reason to get rid of that special view.
changed the title [-][Better Expense Report View] Add the skeleton loading UI when clicking into a report from a preview in a chat.[/-][+][Due for payment 2025-06-02] [Better Expense Report View] Add the skeleton loading UI when clicking into a report from a preview in a chat.[/+]on May 26, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.51-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@DylanDylann@trjExpensify@DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon May 16, 2025
Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.
SzymczakJ commentedon May 16, 2025
Do we have designs for these skeletons?
cc @shawnborton @dannymcclain @dubielzyk-expensify @trjExpensify
shawnborton commentedon May 16, 2025
I think we should:
I don't think we need to try get cute with the violations or the comments below the table, I think I'd just do something simple like this (but maybe remove the button shape from the right side of each row)
Question though: can we detect if we're using the multi-expense report layout? Because the single-expense report layout should probably load more like a chat does, right? Ooof, another good reason to get rid of that special view.
shawnborton commentedon May 16, 2025
I can make some mocks for this too, but mostly just want to get some responses to my comments above first before diving in.
trjExpensify commentedon May 16, 2025
I agree with yah 👍
19 remaining items
dannymcclain commentedon May 20, 2025
Agree—looking good!
melvin-bot commentedon May 22, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon May 24, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon May 26, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-][Better Expense Report View] Add the skeleton loading UI when clicking into a report from a preview in a chat.[/-][+][Due for payment 2025-06-02] [Better Expense Report View] Add the skeleton loading UI when clicking into a report from a preview in a chat.[/+]melvin-bot commentedon May 26, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 26, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.51-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-06-02. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 26, 2025
@DylanDylann @trjExpensify @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
mountiny commentedon May 27, 2025
I believe we can close this one now as payments for this was handled for the project still and regression testing will be handled