Skip to content

[Due for payment 2025-06-02] [Better Expense Report View] Add the skeleton loading UI when clicking into a report from a preview in a chat. #62198

Closed

Description

@trjExpensify

Coming from here.

Steps:
Prerequisite:

  • Use an account on the tableReportView beta, ideally that has a bunch of expense reports already.
  1. Go to the Inbox
  2. Find the workspace chat
  3. Click on a report preview in the history
  4. Observe the lack of a skeleton loading screen

Expected results:
The skeleton loading UI should be present until the report has properly loaded.

Actual results:
No skelly 💀

2025-05-16_11-15-07.mp4
Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 16, 2025
  2. moved this to Second Cohort - MEDIUM or LOW in [#whatsnext] #migrateon May 16, 2025
  3. melvin-bot commented on May 16, 2025

    @melvin-bot

    Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

  4. SzymczakJ commented on May 16, 2025

    @SzymczakJ
    Contributor

    Do we have designs for these skeletons?

    1. Should we also show skeleton for Report status bar("No further actions required")?
    2. Should we show skeleton instead of transactions when the violations are loaded? If yes, then how should it look like?
    3. What should be the skeleton for report actions.
      cc @shawnborton @dannymcclain @dubielzyk-expensify @trjExpensify
  5. shawnborton commented on May 16, 2025

    @shawnborton
    Contributor

    I think we should:

    • show a skeleton for the next steps banner
    • show the same standard skeleton rows that we have on the reports page when the report is loading

    I don't think we need to try get cute with the violations or the comments below the table, I think I'd just do something simple like this (but maybe remove the button shape from the right side of each row)

    Image

    Question though: can we detect if we're using the multi-expense report layout? Because the single-expense report layout should probably load more like a chat does, right? Ooof, another good reason to get rid of that special view.

  6. shawnborton commented on May 16, 2025

    @shawnborton
    Contributor

    I can make some mocks for this too, but mostly just want to get some responses to my comments above first before diving in.

  7. trjExpensify commented on May 16, 2025

    @trjExpensify
    ContributorAuthor

    I agree with yah 👍

  8. 19 remaining items

  9. dannymcclain commented on May 20, 2025

    @dannymcclain
    Contributor

    Agree—looking good!

  10. melvin-bot commented on May 22, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  11. melvin-bot commented on May 24, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  12. melvin-bot commented on May 26, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on May 26, 2025
  14. changed the title [-][Better Expense Report View] Add the skeleton loading UI when clicking into a report from a preview in a chat.[/-] [+][Due for payment 2025-06-02] [Better Expense Report View] Add the skeleton loading UI when clicking into a report from a preview in a chat.[/+] on May 26, 2025
  15. melvin-bot commented on May 26, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on May 26, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.51-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-06-02. 🎊

    For reference, here are some details about the assignees on this issue:

    • @SzymczakJ does not require payment (Contractor)
    • @DylanDylann requires payment through NewDot Manual Requests
  17. melvin-bot commented on May 26, 2025

    @melvin-bot

    @DylanDylann @trjExpensify @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  18. mountiny commented on May 27, 2025

    @mountiny
    Contributor

    I believe we can close this one now as payments for this was handled for the project still and regression testing will be handled

  19. moved this from Second Cohort - MEDIUM or LOW to Done in [#whatsnext] #migrateon May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.WeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions