You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-09-02] [$1750] Use react-native-reanimated in CENTERED Modals #64776
hey @mountiny, Having slight issue testing CardAuthenticationModal. It's a modal that shows when a bank requires second step of card authentication when connecting a card to your subscription.
AFAIU I need to enter card details of regulatory card and have local backend through ngrok set up to test it.
@jnowakow can help here, but an address with sub domain needs to be proxied which is a premium feature. Do you have ngrok subscription that we can use ?
Unless you know of another way to test it for this use case ?
changed the title [-][Due for payment 2025-08-26] [$1750] Use react-native-reanimated in CENTERED Modals[/-][+][Due for payment 2025-09-02] [Due for payment 2025-08-26] [$1750] Use react-native-reanimated in CENTERED Modals[/+]on Aug 26, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.98-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@ZhenjaHorbach@jliexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2025-09-02] [Due for payment 2025-08-26] [$1750] Use react-native-reanimated in CENTERED Modals[/-][+][Due for payment 2025-09-02] [$1750] Use react-native-reanimated in CENTERED Modals[/+]on Aug 27, 2025
Activity
melvin-bot commentedon Jun 24, 2025
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.mountiny commentedon Jun 27, 2025
@jmusial will work on these
jmusial commentedon Jun 30, 2025
Tracking of types / PRS comment for
CENTEREDmodals:FutureTrainingModal- Migrate Quickbooks and Xero flow modals to use Reanimated modal #65172ConnectToQuickBooks- Migrate Quickbooks and Xero flow modals to use Reanimated modal #65172ConnectToXeroFlow- Migrate Quickbooks and Xero flow modals to use Reanimated modal #65172SearchRouterModal- Use ReanimatedModal in Search Router Modal #65250CardAuthenticationModal- Reanimated modal for CardAuthenticationModal #65668ComparePlansModal- Migrate ComparePlansModal #66868AttachmentModalContainer- Migrate AttachmentModalContainer to use the Reanimated modal #67480 <- cannot publish, new pr - Feat/migrate attachment modal container #68343AttachmentModal- Assuming we do not need to worry about this one bc [HOLD on #69523] Migrate remainingAttachmentModalusages #65245 -The modals will get switched to usereanimatedone anyways. - Centered modals migration cleanup #68729jmusial commentedon Jun 30, 2025
hey @mountiny, Having slight issue testing
CardAuthenticationModal. It's a modal that shows when a bank requires second step of card authentication when connecting a card to your subscription.AFAIU I need to enter card details of regulatory card and have local backend through
ngrokset up to test it.@jnowakow can help here, but an address with sub domain needs to be proxied which is a premium feature. Do you have
ngroksubscription that we can use ?Unless you know of another way to test it for this use case ?
mountiny commentedon Jul 1, 2025
@jmusial Can you just use Revolut card and setup EUR country for it? I think I tested that against staging
We do have our org NGROK I assume we have that paid feature but not sure if we discussed inviting the external devs to the organization there.
Can you first try using card that is based in EU, just block it/ remove it after testing, you should not be charge anything
99 remaining items
melvin-bot commentedon Aug 25, 2025
mountiny commentedon Aug 25, 2025
No checklist required as this was new feature rather than bug. Updated and its 7 PRs so $1750
jliexpensify commentedon Aug 25, 2025
Thanks @mountiny and @ZhenjaHorbach!
jliexpensify commentedon Aug 25, 2025
Payment Summary
[-][Due for payment 2025-08-26] [$1750] Use react-native-reanimated in CENTERED Modals[/-][+][Due for payment 2025-09-02] [Due for payment 2025-08-26] [$1750] Use react-native-reanimated in CENTERED Modals[/+]melvin-bot commentedon Aug 26, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.98-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-09-02. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Aug 26, 2025
@ZhenjaHorbach @jliexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
jliexpensify commentedon Aug 26, 2025
Payment summary
No checklist required
[-][Due for payment 2025-09-02] [Due for payment 2025-08-26] [$1750] Use react-native-reanimated in CENTERED Modals[/-][+][Due for payment 2025-09-02] [$1750] Use react-native-reanimated in CENTERED Modals[/+]ZhenjaHorbach commentedon Sep 2, 2025
Requested in ND !
quinthar commentedon Sep 15, 2025
Approved $1750 to @ZhenjaHorbach
flaviadefaria commentedon Sep 19, 2025
Approved $1750 for @ZhenjaHorbach