Repository navigation
Conversation
|
|
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@ZhenjaHorbach can you complete the checklist here too? |
Yes |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreenrecorder-2025-07-25-18-15-57-831.mp4Android: mWeb ChromeScreenrecorder-2025-07-25-18-11-27-229.mp4iOS: HybridApp2025-07-25.18.21.10.mp4iOS: mWeb Safari2025-07-25.18.21.13.mp4MacOS: Chrome / Safariweb.movMacOS: Desktopweb.mov |
|
LGTM ! |
| "version": "0.72.8", | ||
| "resolved": "https://registry.npmjs.org/@types/react-native/-/react-native-0.72.8.tgz", | ||
| "integrity": "sha512-St6xA7+EoHN5mEYfdWnfYt0e8u6k2FR0P9s2arYgakQGFgU1f9FlPrIEcj0X24pLCF5c5i3WVuLCUdiCYHmOoA==", |
There was a problem hiding this comment.
Why are all these changes necessary @jmusial
Ideally we can avoid all these resolved/ integrity changes
|
|
||
| ### [react-native-reanimated+3.19.0+001+catch-all-exceptions-on-stoi.patch](react-native-reanimated+3.19.0+001+catch-all-exceptions-on-stoi.patch) | ||
|
|
||
| - Reason: 🛑 |
There was a problem hiding this comment.
If we are adding this file, can you plus put in the work to back trace this? Maybe @war-in can help but I do not like that we would add this docs file empty, it will never be backfiled
| "react": "*", | ||
| "react-native": "*" |
There was a problem hiding this comment.
@war-in is it ok to leave it like that? Feels like quite random changes 😄
There was a problem hiding this comment.
yup, it's auto generated. Would leave it if that's ok?
There was a problem hiding this comment.
Yeah I assume that is autogenerated, but we had seen that some local setup / config can mess up with the output
There was a problem hiding this comment.
I missed it was below, thanks!
|
@mountiny just want to track down reasons for patches, will let you know when it's there ! |
|
@mountiny all done here |
mountiny
left a comment
There was a problem hiding this comment.
Thank you! moving this ahead!
| ### [react-native-reanimated+3.19.0+001+catch-all-exceptions-on-stoi.patch](react-native-reanimated+3.19.0+001+catch-all-exceptions-on-stoi.patch) | ||
|
|
||
| - Reason: Reanimated wasn't able to catch an exception here, so the catch clause was broadened. | ||
| - Upstream PR/issue: 🛑 |
There was a problem hiding this comment.
Not sure tbh, we can create a follow-up issue to investigate it (and possibly create upstream PRs)
| "react": "*", | ||
| "react-native": "*" |
There was a problem hiding this comment.
I missed it was below, thanks!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.88-0 🚀
|
|
🚀 Deployed to production by https://github.com/grgia in version: 9.1.88-3 🚀
|

Important
This PR requires Mobile-Expensify changes https://github.com/Expensify/Mobile-Expensify/pull/13640
Explanation of Change
This PR updates
react-native-reanimatedto version3.19.0.Patches removed have been adapted into the lib code in
3.19.0Fixed Issues
$ #64776
PROPOSAL:
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13640
Tests
N/A
Offline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop