Skip to content

[Due for payment 2025-07-04] Expense - Error message when amount is missing is above currency button instead of Next button #64853

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.71-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #56092
Email or phone of affected tester (no customers): jsndojdsosjdo@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Open FAB > Create expense > Manual.
  3. Without entering amount, click Next.

Expected Result:

Error message when amount is not entered will be placed above Next button.

Actual Result:

Error message when amount is not entered is placed above currency button.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6868837_1750799045569.20250625_025249.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jun 24, 2025
  2. melvin-bot commented on Jun 24, 2025

    @melvin-bot

    Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jun 24, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Jun 24, 2025

    @melvin-bot

    Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Jun 24, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. samranahm commented on Jun 24, 2025

    @samranahm
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Error message when amount is missing is above currency button instead of Next button

    What is the root cause of that problem?

    Currently the FormHelpMessage is placed above currency selector button that cause the error to show bellow the amount instead of above the next button

    {!!formError && (
    <FormHelpMessage
    style={[styles.pAbsolute, styles.b0, styles.mb0, styles.ph5, styles.w100]}
    isError
    message={formError}
    />
    )}

    What changes do you think we should make in order to solve the problem?

    We should move

    {!!formError && (
    <FormHelpMessage
    style={[styles.pAbsolute, styles.b0, styles.mb0, styles.ph5, styles.w100]}
    isError
    message={formError}
    />
    )}

    bellow the currency selector button

    {isCurrencyPressable && !canUseTouchScreen && (
    <Button
    shouldShowRightIcon
    small
    iconRight={Expensicons.DownArrow}
    onPress={onCurrencyButtonPress}
    style={styles.minWidth18}
    isContentCentered
    text={currency}
    />
    )}

    like this

    {isCurrencyPressable && !canUseTouchScreen && (
        <Button
            shouldShowRightIcon
            small
            iconRight={Expensicons.DownArrow}
            onPress={onCurrencyButtonPress}
            style={styles.minWidth18}
            isContentCentered
            text={currency}
        />
    )}
    {!!formError && (
        <FormHelpMessage
            style={[styles.pAbsolute, styles.b0, styles.mb0, styles.ph5, styles.w100]}
            isError
            message={formError}
        />
    )}

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    Results

    Image
  7. 18 remaining items

  8. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jun 27, 2025
  9. changed the title [-]Expense - Error message when amount is missing is above currency button instead of Next button[/-] [+][Due for payment 2025-07-04] Expense - Error message when amount is missing is above currency button instead of Next button[/+] on Jun 27, 2025
  10. melvin-bot commented on Jun 27, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Jun 27, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.71-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-07-04. 🎊

  12. melvin-bot commented on Jun 27, 2025

    @melvin-bot

    @roryabraham @roryabraham The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. melvin-bot commented on Sep 22, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  14. melvin-bot commented on Sep 22, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  15. melvin-bot commented on Sep 22, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  16. melvin-bot commented on Oct 9, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions