Skip to content

Deploy Checklist: New Expensify 2021-11-29 #6505

Closed

Description

@OSBotify

Release Version: 1.1.17-7
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

cc @Expensify/applauseleads

Activity

  1. MelvinBot commented on Nov 29, 2021

    @MelvinBot
    Contributor

    📣 @applausebot You have been assigned to this job by @OSBotify!
    Please apply to this job in Upwork and let us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  2. roryabraham commented on Nov 29, 2021

    @roryabraham
    Contributor

    Something weird happened here, going to unlock and relock

  3. added and removed on Nov 29, 2021
  4. roryabraham commented on Nov 29, 2021

    @roryabraham
    Contributor

    Trying again

  5. added and removed on Nov 29, 2021
  6. roryabraham commented on Nov 29, 2021

    @roryabraham
    Contributor

    Okay, that time it worked and 1.1.17-0 is deploying here

  7. parasharrajat commented on Nov 29, 2021

    @parasharrajat
    Member

    #6433 is in production already.

  8. roryabraham commented on Nov 29, 2021

    @roryabraham
    Contributor

    @parasharrajat This is a known issue with pull requests that are CP'd. We should be close to a fix, but won't know for sure until the next checklist. Checked off #6433 for now

  9. isagoico commented on Nov 30, 2021

    @isagoico

    @roryabraham @marcaaron Got the notification to test these Cherry picks but both seem internal QA. I'll add them to the Internal list of PRs in the main comment.
    #6531
    #6411

  10. 4 remaining items

  11. isagoico commented on Dec 1, 2021

    @isagoico

    @roryabraham Botify didn't like me adding stuff to the checklist 😆 I think what we can do is simply add comments with checklists to test the CPs until the CP checklist issue is resolved so we have visibility on what has been tested or not.
    image

  12. isagoico commented on Dec 2, 2021

    @isagoico

    Only thing missing for this checklist is the fix for #6518 (deploy blocker) being worked on here #6535 - once that it fixed we will retest #6442 and check both of them off if they are a pass.

  13. roryabraham commented on Dec 3, 2021

    @roryabraham
    Contributor

    Botify didn't like me adding stuff to the checklist

    Oh, I can fix that 😄 Mind creating an issue and assigning it to me?

  14. ogumen commented on Dec 3, 2021

    @ogumen

    The PRs not applicable to accessibility testing are: #6165, #6195, #6268, #6278, #6279, #6387, #6441, #6417, #6466, #6485. All others except #6442 have been tested, the failures are mentioned in comments for the corresponding PRs.

  15. isagoico commented on Dec 3, 2021

    @isagoico

    Testing this CP on all environments:
    #6259

    Will be tested internally #6571 (comment)

  16. marcaaron commented on Dec 3, 2021

    @marcaaron
    Contributor

    #6411 should be good to go - removing the blocker.

  17. mvtglobally commented on Dec 6, 2021

    @mvtglobally

    @roryabraham Friendly bump.
    Still waiting for the fix for #6518 (deploy blocker) to retest #6442 & close this checklist

  18. roryabraham commented on Dec 6, 2021

    @roryabraham
    Contributor

    @mvtglobally We're working on getting #6518 resolve ASAP.

  19. roryabraham commented on Dec 6, 2021

    @roryabraham
    Contributor

    The fix to #6518 is being CP'd in 1.1.17-7 here

  20. roryabraham commented on Dec 6, 2021

    @roryabraham
    Contributor

    1.1.17-7 has finished deploying. @mvtglobally @isagoico please retest #6442, #6518, and #6535

  21. mvtglobally commented on Dec 6, 2021

    @mvtglobally

    @roryabraham #6518 and #6535 are pass. 1.1.17-7 is not available on Android yet, but PR #6442 seem pass on build 1.1.17-6 on Android. Let me know if we should wait for 1.1.17-7 or it is ok to check off this PR?

  22. roryabraham commented on Dec 6, 2021

    @roryabraham
    Contributor

    Sounds good, going to check everything off and deploy.

  23. roryabraham commented on Dec 6, 2021

    @roryabraham
    Contributor

    :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions