Skip to content

[Due for payment 2025-07-25] [$250] Remove remaining withOnyx HOCs from the project | Batch 5 #65966

Closed

Description

@fabioh8010

Parent issue: #64225

Let's refactor the following files to use useOnyx instead of withOnyx. All the work must be done in one PR.

After refactor please test them extensively and provide test steps in your PR. In case of questions please ask in #expensify-open-source channel.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021944840329549889266
  • Upwork Job ID: 1944840329549889266
  • Last Price Increase: 2025-07-14
  • Automatic offers:
    • QichenZhu | Reviewer | 108043527
    • mkzie2 | Contributor | 108043531
Issue OwnerCurrent Issue Owner: @QichenZhu

Activity

  1. mkzie2 commented on Jul 14, 2025

    @mkzie2
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Remove withOnyx and replace with useOnyx

    What is the root cause of that problem?

    Improvement

    What changes do you think we should make in order to solve the problem?

    Remove withOnyx here and use the useOnyx with the same key

    const [preferredSkinTone] = useOnyx(ONYXKEYS.PREFERRED_EMOJI_SKIN_TONE, {canBeMissing: true, selector: EmojiUtils.getPreferredSkinToneIndex});
    

    export default withOnyx<SuggestionEmojiProps & RefAttributes<SuggestionsRef>, SuggestionEmojiOnyxProps>({
    preferredSkinTone: {
    key: ONYXKEYS.PREFERRED_EMOJI_SKIN_TONE,
    selector: EmojiUtils.getPreferredSkinToneIndex,
    },

    SilentCommentUpdater component is already migrated to useOnyx

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  2. self-assigned this
    on Jul 14, 2025
  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 14, 2025
  4. changed the title [-]Remove remaining withOnyx HOCs from the project | Batch 5[/-] [+][$250] Remove remaining withOnyx HOCs from the project | Batch 5[/+] on Jul 14, 2025
  5. melvin-bot commented on Jul 14, 2025

    @melvin-bot
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 14, 2025
  7. melvin-bot commented on Jul 14, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @QichenZhu (External)

  8. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 14, 2025
  9. melvin-bot commented on Jul 14, 2025

    @melvin-bot

    📣 @QichenZhu 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job

  10. melvin-bot commented on Jul 14, 2025

    @melvin-bot

    📣 @mkzie2 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  11. added
    ReviewingHas a PR in review
    and removed on Jul 15, 2025
  12. 6 remaining items

  13. melvin-bot commented on Jul 18, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Jul 18, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.82-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-07-25. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Jul 25, 2025

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @abekkala you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  16. abekkala commented on Jul 28, 2025

    @abekkala
    Contributor

    PAYMENT SUMMARY FOR JUL 25

  17. abekkala commented on Jul 28, 2025

    @abekkala
    Contributor

    @mkzie2 payment sent and contract ended - thank you! 🎉

  18. QichenZhu commented on Jul 28, 2025

    @QichenZhu
    Contributor

    @abekkala I don't think this was a bug. Does the BugZero Checklist apply?

  19. abekkala commented on Jul 29, 2025

    @abekkala
    Contributor

    Ah got it @QichenZhu Thanks

  20. abekkala commented on Jul 29, 2025

    @abekkala
    Contributor

    @QichenZhu payment sent and contract ended - thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions