Skip to content

[Due for payment 2025-10-13] Remove remaining withOnyx HOCs from the project #64225

Closed

Description

@fabioh8010

Context: #62300 (comment)

Let's remove the remaining withOnyx from the project. With that we will be able to remove the HOC from react-native-onyx and remove/optimize a bunch of code that will become useless.

I created some batches to avoid lots of PRs and reviews.










Several attempts were made in the past, so we'll have to revisit this one.


Just cleanup, remove written references to withOnyx, comments, etc. MUST be the last issue to be worked on!


cc @roryabraham

Issue OwnerCurrent Issue Owner: @CortneyOfstad

Activity

  1. fabioh8010 commented on Jun 18, 2025

    @fabioh8010
    ContributorAuthor

    @roryabraham Do you think we can offload this work to the community, and we act as reviewers? Seems something straightforward enough for some external contributors to take it.

  2. roryabraham commented on Jun 19, 2025

    @roryabraham
    Contributor

    Yes, that sounds good. Maybe we can do a standard bounty of $100/component for this, because most of these will be pretty quick and easy.

    That said, I think my preference would be to start this after F1, So the week of June 30th

  3. fabioh8010 commented on Jul 1, 2025

    @fabioh8010
    ContributorAuthor

    @roryabraham Maybe we can return to this ticket now?

    Maybe we can do a standard bounty of $100/component for this, because most of these will be pretty quick and easy.

    I created some batches (updated them today) of files I think we can do together in each issue (instead of 1 issue per component) and I put in the issue description. WDYT?

  4. roryabraham commented on Jul 3, 2025

    @roryabraham
    Contributor

    Sounds good, let's get started on it @fabioh8010. I added this to the #quality project since we have evidence that useOnyx is better for performance than withOnyx

  5. fabioh8010 commented on Jul 7, 2025

    @fabioh8010
    ContributorAuthor

    @roryabraham How do you want to proceed? Can I create the GH issues for each batch and then we announce in open-source channel?

  6. fabioh8010 commented on Jul 11, 2025

    @fabioh8010
    ContributorAuthor

    @roryabraham

    I created all the issues, details in the issue description

    #65961
    #65962
    #65963
    #65964
    #65966
    #65967
    #65968
    #65970
    #65971

    Please let me know once you add the labels, and I will announce on the channel!

  7. fabioh8010 commented on Jul 15, 2025

    @fabioh8010
    ContributorAuthor

    All the issues (except #65971 because is on hold) are already assigned to a contributor 🎉 I will actively check and review the PRs.

  8. roryabraham commented on Aug 19, 2025

    @roryabraham
    Contributor

    currently blocked on AuthScreens, which I'm trying to push forward by requesting Applause QA

  9. 19 remaining items

  10. roryabraham commented on Oct 2, 2025

    @roryabraham
    Contributor

    @CortneyOfstad the only TODO for you here will be to pay @jjcoffee $250 for his review of #71369, after that PR has been deployed to production for 1 week

  11. changed the title [-]Remove remaining withOnyx HOCs from the project[/-] [+][Due for payment 2025-10-13] Remove remaining withOnyx HOCs from the project[/+] on Oct 6, 2025
  12. melvin-bot commented on Oct 6, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.23-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-10-13. 🎊

    For reference, here are some details about the assignees on this issue:

    • @fabioh8010 does not require payment (Contractor)
    • @jjcoffee requires payment through NewDot Manual Requests
  13. melvin-bot commented on Oct 6, 2025

    @melvin-bot

    @jjcoffee @CortneyOfstad The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. CortneyOfstad commented on Oct 7, 2025

    @CortneyOfstad
    Contributor

    Hey @jjcoffee can you complete the checklist when you have a chance? Thank you!

  15. jjcoffee commented on Oct 10, 2025

    @jjcoffee
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/A - feature

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Go to Workspaces tab and create a new Workspace.
    2. Verify that the Workspace was created without errors, and that the #admins and Workspace chats exist.
    3. Go to Workspaces and duplicate this Workspace.
    4. Verify the Workspace was created without errors, and that the #admins and Workspace chats exist.
    5. Delete both Workspaces.
    6. Verify the Workspaces were deleted without errors, and the corresponding rooms/chats are deleted too.

    Do we agree 👍 or 👎

  16. melvin-bot commented on Oct 13, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @fabioh8010 is from an agency-contributor and not due payment
    • Reviewer: @jjcoffee owed $250 via NewDot

    BugZero Checklist (@CortneyOfstad)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  17. CortneyOfstad commented on Oct 13, 2025

    @CortneyOfstad
    Contributor

    Payment Summary

    @jjcoffee to be paid $250 via NewDot

    Regression Test

    https://github.com/Expensify/Expensify/issues/556869

  18. JmillsExpensify commented on Oct 14, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @jjcoffee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ImprovementItem broken or needs improvement.WeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions