Repository navigation
Description
Context: #62300 (comment)
Let's remove the remaining withOnyx from the project. With that we will be able to remove the HOC from react-native-onyx and remove/optimize a bunch of code that will become useless.
I created some batches to avoid lots of PRs and reviews.
-
Remove remaining withOnyx HOCs from the project | Batch 5 (PR)
-
src/pages/home/report/ReportActionCompose/SuggestionEmoji.tsx
-
src/pages/home/report/ReportActionCompose/SilentCommentUpdater/index.android.tsx
-
src/pages/home/report/ReportActionCompose/SilentCommentUpdater/index.tsx
-
Remove remaining withOnyx HOCs from the project | Batch 7 (PR)
-
src/pages/EnablePayments/AddBankAccount/substeps/ConfirmationStep.tsx
Several attempts were made in the past, so we'll have to revisit this one.
Just cleanup, remove written references to withOnyx, comments, etc. MUST be the last issue to be worked on!
- README.md
- mocks/react-native-onyx.ts
- contributingGuides/STYLE.md
- src/components/TagPicker/index.tsx
- src/libs/ReportUtils.ts
- src/libs/actions/App.ts
- src/pages/home/report/PureReportActionItem.tsx
- src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx
- tests/actions/EnforceActionExportRestrictions.ts
cc @roryabraham
Issue Owner
Current Issue Owner: @CortneyOfstadMetadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
fabioh8010 commentedon Jun 18, 2025
@roryabraham Do you think we can offload this work to the community, and we act as reviewers? Seems something straightforward enough for some external contributors to take it.
roryabraham commentedon Jun 19, 2025
Yes, that sounds good. Maybe we can do a standard bounty of $100/component for this, because most of these will be pretty quick and easy.
That said, I think my preference would be to start this after F1, So the week of June 30th
fabioh8010 commentedon Jul 1, 2025
@roryabraham Maybe we can return to this ticket now?
I created some batches (updated them today) of files I think we can do together in each issue (instead of 1 issue per component) and I put in the issue description. WDYT?
roryabraham commentedon Jul 3, 2025
Sounds good, let's get started on it @fabioh8010. I added this to the
#qualityproject since we have evidence thatuseOnyxis better for performance thanwithOnyxfabioh8010 commentedon Jul 7, 2025
@roryabraham How do you want to proceed? Can I create the GH issues for each batch and then we announce in open-source channel?
fabioh8010 commentedon Jul 11, 2025
@roryabraham
I created all the issues, details in the issue description
#65961
#65962
#65963
#65964
#65966
#65967
#65968
#65970
#65971
Please let me know once you add the labels, and I will announce on the channel!
fabioh8010 commentedon Jul 15, 2025
All the issues (except #65971 because is on hold) are already assigned to a contributor 🎉 I will actively check and review the PRs.
roryabraham commentedon Aug 19, 2025
currently blocked on AuthScreens, which I'm trying to push forward by requesting Applause QA
19 remaining items
roryabraham commentedon Oct 2, 2025
@CortneyOfstad the only TODO for you here will be to pay @jjcoffee $250 for his review of #71369, after that PR has been deployed to production for 1 week
[-]Remove remaining withOnyx HOCs from the project[/-][+][Due for payment 2025-10-13] Remove remaining withOnyx HOCs from the project[/+]melvin-bot commentedon Oct 6, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.23-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-10-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 6, 2025
@jjcoffee @CortneyOfstad The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
CortneyOfstad commentedon Oct 7, 2025
Hey @jjcoffee can you complete the checklist when you have a chance? Thank you!
jjcoffee commentedon Oct 10, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A - feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
melvin-bot commentedon Oct 13, 2025
Payment Summary
Upwork Job
BugZero Checklist (@CortneyOfstad)
CortneyOfstad commentedon Oct 13, 2025
Payment Summary
@jjcoffee to be paid $250 via NewDot
Regression Test
https://github.com/Expensify/Expensify/issues/556869
JmillsExpensify commentedon Oct 14, 2025
$250 approved for @jjcoffee