You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-07-25] [$250] Remove remaining withOnyx HOCs from the project | Batch 7 #65968
const[personalBankAccountDraft]=useOnyx(ONYXKEYS.FORMS.PERSONAL_BANK_ACCOUNT_FORM_DRAFT,{canBeMissing: true});const[personalBankAccount]=useOnyx(ONYXKEYS.PERSONAL_BANK_ACCOUNT,{canBeMissing: true});// We are not using userWallet, so it can be removed.const[userWallet]=useOnyx(ONYXKEYS.USER_WALLET,{canBeMissing: true});
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
This is just an improvement, so no tests are necessary.
What alternative solutions did you explore? (Optional)
changed the title [-]Remove remaining withOnyx HOCs from the project | Batch 7[/-][+][$250] Remove remaining withOnyx HOCs from the project | Batch 7[/+]on Jul 14, 2025
📣 @linhvovan29546 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
Issue is ready for payment but no BZ is assigned. @kadiealexander you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
Activity
linhvovan29546 commentedon Jul 11, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Let's refactor the following files to use useOnyx instead of withOnyx
What is the root cause of that problem?
Improvement
What changes do you think we should make in order to solve the problem?
Remove withOnyx from these components as described in the OP and replace it with the useOnyx hook.
For example remove this HOC
App/src/pages/EnablePayments/EnablePaymentsPage.tsx
Line 95 in d9fe9ee
The update
App/src/pages/EnablePayments/EnablePaymentsPage.tsx
Line 33 in d9fe9ee
Apply similar updates to the remaining components.
App/src/pages/EnablePayments/OnfidoPrivacy.tsx
Line 38 in d9fe9ee
App/src/pages/EnablePayments/OnfidoStep.tsx
Line 32 in d9fe9ee
App/src/pages/EnablePayments/AddBankAccount/substeps/ConfirmationStep.tsx
Line 38 in d9fe9ee
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
This is just an improvement, so no tests are necessary.
What alternative solutions did you explore? (Optional)
N/A
[-]Remove remaining withOnyx HOCs from the project | Batch 7[/-][+][$250] Remove remaining withOnyx HOCs from the project | Batch 7[/+]melvin-bot commentedon Jul 14, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021944840359649772614
melvin-bot commentedon Jul 14, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (
External)melvin-bot commentedon Jul 14, 2025
📣 @linhvovan29546 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
12 remaining items
melvin-bot commentedon Jul 25, 2025
Issue is ready for payment but no BZ is assigned. @kadiealexander you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
melvin-bot commentedon Jul 28, 2025
@allroundexperts Whoops! This issue is 2 days overdue. Let's get this updated quick!
linhvovan29546 commentedon Jul 31, 2025
@kadiealexander Could you please handle the payment when you have a chance? Thank you!
kadiealexander commentedon Jul 31, 2025
Payments needed:
@allroundexperts please complete the checklist!
kadiealexander commentedon Aug 5, 2025
@allroundexperts bump on this
kadiealexander commentedon Aug 8, 2025
Bumped @allroundexperts in Slack.
allroundexperts commentedon Aug 8, 2025
@kadiealexander No checklist is needed here. This was a code improvement.
trjExpensify commentedon Jan 5, 2026
approved $250 for @allroundexperts.