Skip to content

Deploy Checklist: New Expensify 2021-12-06 #6605

Closed

Description

@OSBotify

Release Version: 1.1.18-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

cc @Expensify/applauseleads

Activity

  1. MelvinBot commented on Dec 6, 2021

    @MelvinBot
    Contributor

    📣 @applausebot You have been assigned to this job by @OSBotify!
    Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  2. roryabraham commented on Dec 6, 2021

    @roryabraham
    Contributor

    Checked off a number of PRs which were already CP'd to staging and then deployed to production, and thus should not be included in this checklist. Also checked off #6536, which is listed as No QA.

  3. mvtglobally commented on Dec 6, 2021

    @mvtglobally

    Starting QA

  4. isagoico commented on Dec 7, 2021

    @isagoico

    Posting this here as well - https://expensify.slack.com/archives/C9YU7BX5M/p1638900800215400

    We're currently unable to access build 1.1.18-1 on Android. Build available in Playstore is 1.1.17-7 (seems there was an issue surrounding the last deploy for 1.1.18-1)

  5. isagoico commented on Dec 7, 2021

    @isagoico

    Checking off #6544 > #6627 (comment)

  6. marcaaron commented on Dec 7, 2021

    @marcaaron
    Contributor

    I think #6620 can be checked off now. Issue is resolved for me on staging when re-testing.

  7. roryabraham commented on Dec 8, 2021

    @roryabraham
    Contributor

    Looks like the fix to #6528 is being CP'd to staging in 1.1.18-3 here

  8. roryabraham commented on Dec 8, 2021

    @roryabraham
    Contributor

    So to recap where we'll ideally be after 1.1.18-3 is finished deploying:

    • We should be able to retest any deploy blockers and they should all be resolved.
    • These regression TC's should be unblocked:
      • Create group and User search steps
      • Bank Account TCs
    • I see nothing in the Google Play Console that might indicate why the Android builds wouldn't be available. Reached out for clarification in slack. Hopefully we'll be able to get this sorted.
  9. mvtglobally commented on Dec 8, 2021

    @mvtglobally
  10. mvtglobally commented on Dec 8, 2021

    @mvtglobally

    #6620 is resolved, we are re-testing blocked steps

  11. mvtglobally commented on Dec 8, 2021

    @mvtglobally

    Regression is Completed
    TR steps re-tested

    Blocked PRs re-tested too
    Checking off #6542, #6524, #6230, #6477

    New issue #6640 From PR #6582. We didn't mark it as Deploy Blocker as its repro in PROD. Is it PROD PR? @roryabraham @chiragsalian let us know

    #6557 (comment) - Can we check it off ?

  12. roryabraham commented on Dec 8, 2021

    @roryabraham
    Contributor

    #6557 (comment) has been reverted, so we can check it off

  13. mvtglobally commented on Dec 8, 2021

    @mvtglobally

    @roryabraham
    Only #6582 is pending now with issue #6640.
    Should we consider it a blocker or we can check off and close this checklist?

  14. roryabraham commented on Dec 8, 2021

    @roryabraham
    Contributor

    What about #6528?

  15. roryabraham commented on Dec 8, 2021

    @roryabraham
    Contributor

    I think #6582 and #6640 should not be treated as blockers since email responses aren't formatted correctly on production anyways. So we can probably check off #6582 on this checklist despite the fact it didn't really pass QA cc @chiragsalian

    So I think the only other question is #6528. I verified that it's fixed in iOS 1.1.18-3 but need someone to retest on Android

  16. mvtglobally commented on Dec 8, 2021

    @mvtglobally

    @roryabraham its a pass on Android image

  17. parasharrajat commented on Dec 8, 2021

    @parasharrajat
    Member

    It seems like this Checklist is ready to deploy.

  18. roryabraham commented on Dec 8, 2021

    @roryabraham
    Contributor

    :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions