Skip to content

Search - Some users are not prioritized over chats or rooms #6627

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing #6544

Action Performed:

  1. Open app and login
  2. Open the Search page.
  3. Search for something.
  4. verify search results

Expected Result:

Users appear first in the result list over group chats or rooms

Actual Result:

Some users appear after group chats or rooms

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.18.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5362931_mesagge1

Bug5362931_Pr_6544.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub
Issue was found when executing #6544

Activity

  1. OSBotify commented on Dec 7, 2021

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. MelvinBot commented on Dec 7, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. Jag96 commented on Dec 7, 2021

    @Jag96
    Contributor
  4. parasharrajat commented on Dec 7, 2021

    @parasharrajat
    Member

    I am not able to reproduce this on staging. From the vid, it seems the search is not even working.

  5. marcochavezf commented on Dec 7, 2021

    @marcochavezf
    Contributor

    I think I was able to reproduce the issue, the users marco+test2@expensifail.com and marco+test3@expensifail.com are appearing below the group chats:

    Screen Shot 2021-12-07 at 14 35 05

    There's no error in the console log of staging, but when I test locally I see these errors (not sure if it's related):

    Screen Shot 2021-12-07 at 14 36 38

    I will continue investigating.

  6. parasharrajat commented on Dec 7, 2021

    @parasharrajat
    Member

    It may be only causing issues for only email entries.

  7. marcochavezf commented on Dec 7, 2021

    @marcochavezf
    Contributor

    It may be only causing issues for only email entries.

    ah are you referring to the console errors or the users that are appearing below the group chats?
    Oh I see, the users that appear below are the email entries (no report chat created for those users). So seems the users that are not prioritized in the video are email entries, thus this is not an issue introduced by a recent change.

    👋🏽 @Jag96 what could be the next action for this issue? do we remove the deploy blocker label?

  8. isagoico commented on Dec 7, 2021

    @isagoico

    I think that the users that appear below the group chats are user that don't have a existing conversation with the logged in user.

  9. Jag96 commented on Dec 7, 2021

    @Jag96
    Contributor

    👋🏽 @Jag96 what could be the next action for this issue? do we remove the deploy blocker label?

    @marcochavezf I think we can remove the deploy blocker label here since this seems like a case we missed in #6544 instead of a regression. I've posted in slack to double-check how we want to handle this case, but I think we can just make this a follow up to fix the missed case.

    Removing the deploy blocker label and updating to daily and leaving assigned to me for now, but @isagoico I think we can check off #6544 if there aren't any regressions with search.

  10. removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Dec 7, 2021
  11. 48 remaining items

  12. roryabraham commented on Jan 24, 2022

    @roryabraham
    Contributor

    The fix for this was deployed to production 6 days ago. There were some comments on the PR but it sounds like an unrelated bug. So @adelekennedy I think we should be good to pay this out tomorrow.

  13. adelekennedy commented on Jan 24, 2022

    @adelekennedy
    Contributor

    Noted! Have it on my calendar to pay out on 1/25 - then I will close the job

  14. mvtglobally commented on Jan 25, 2022

    @mvtglobally

    @adelekennedy @roryabraham Can you check below video. We seem to be able to repro the issue.

    6627.mp4

    Also, we noticed that exact search match is not always displayed on Top. Not sure if its related to this PR
    Web_6627-2201

  15. adelekennedy commented on Jan 30, 2022

    @adelekennedy
    Contributor

    Double checking here @roryabraham the job is closed and paid out - but do we need to reopen the job?

  16. roryabraham commented on Jan 31, 2022

    @roryabraham
    Contributor

    Honestly, I can't keep track of all the expected behavior in the labyrinth that is OptionsListUtils. I think that we should close this and add a new issue to:

    1. First, clearly and thoroughly define the results ordering, accounting for:
      1. DM's, group chats, policy default rooms, workspace chats, user-created rooms
      2. How the order might change for the New Chat or New Group pages, and for users that don't yet have Expensify accounts.
    2. Create unit tests to cover all those expected results.
    3. Attempt to DRY up and generalize all the logic we have now.
    4. Patch logic as necessary to make tests pass.

    Thoughts? cc @parasharrajat

  17. parasharrajat commented on Feb 1, 2022

    @parasharrajat
    Member

    Ok, nice thoughts @roryabraham. We should certainly do that. But #6627 (comment) is a different issue.

    it is not the order of options. I think QA is saying that the search is not working properly. The exact match should come first.

    So the search should also look into the personalDetails (contacts) with respect to Recent reports(chats). This should be a separate issue and thus we can close this and create a new one. Also, plan the order properly (based on your thoughts) and then fix it.

  18. removed their assignment
    on Feb 2, 2022
  19. roryabraham commented on Feb 5, 2022

    @roryabraham
    Contributor

    Created a follow-up: #7582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions