You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Search - Some users are not prioritized over chats or rooms #6627
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
It may be only causing issues for only email entries.
ah are you referring to the console errors or the users that are appearing below the group chats?
Oh I see, the users that appear below are the email entries (no report chat created for those users). So seems the users that are not prioritized in the video are email entries, thus this is not an issue introduced by a recent change.
👋🏽 @Jag96 what could be the next action for this issue? do we remove the deploy blocker label?
👋🏽 @Jag96 what could be the next action for this issue? do we remove the deploy blocker label?
@marcochavezf I think we can remove the deploy blocker label here since this seems like a case we missed in #6544 instead of a regression. I've posted in slack to double-check how we want to handle this case, but I think we can just make this a follow up to fix the missed case.
Removing the deploy blocker label and updating to daily and leaving assigned to me for now, but @isagoico I think we can check off #6544 if there aren't any regressions with search.
The fix for this was deployed to production 6 days ago. There were some comments on the PR but it sounds like an unrelated bug. So @adelekennedy I think we should be good to pay this out tomorrow.
Honestly, I can't keep track of all the expected behavior in the labyrinth that is OptionsListUtils. I think that we should close this and add a new issue to:
First, clearly and thoroughly define the results ordering, accounting for:
DM's, group chats, policy default rooms, workspace chats, user-created rooms
How the order might change for the New Chat or New Group pages, and for users that don't yet have Expensify accounts.
Create unit tests to cover all those expected results.
Attempt to DRY up and generalize all the logic we have now.
it is not the order of options. I think QA is saying that the search is not working properly. The exact match should come first.
So the search should also look into the personalDetails (contacts) with respect to Recent reports(chats). This should be a separate issue and thus we can close this and create a new one. Also, plan the order properly (based on your thoughts) and then fix it.
Activity
OSBotify commentedon Dec 7, 2021
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:MelvinBot commentedon Dec 7, 2021
Triggered auto assignment to @marcochavezf (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.Jag96 commentedon Dec 7, 2021
cc @parasharrajat
parasharrajat commentedon Dec 7, 2021
I am not able to reproduce this on staging. From the vid, it seems the search is not even working.
marcochavezf commentedon Dec 7, 2021
I think I was able to reproduce the issue, the users
marco+test2@expensifail.comandmarco+test3@expensifail.comare appearing below the group chats:There's no error in the console log of staging, but when I test locally I see these errors (not sure if it's related):
I will continue investigating.
parasharrajat commentedon Dec 7, 2021
It may be only causing issues for only email entries.
marcochavezf commentedon Dec 7, 2021
ah are you referring to the console errors or the users that are appearing below the group chats?Oh I see, the users that appear below are the email entries (no report chat created for those users). So seems the users that are not prioritized in the video are email entries, thus this is not an issue introduced by a recent change.
👋🏽 @Jag96 what could be the next action for this issue? do we remove the deploy blocker label?
isagoico commentedon Dec 7, 2021
I think that the users that appear below the group chats are user that don't have a existing conversation with the logged in user.
Jag96 commentedon Dec 7, 2021
@marcochavezf I think we can remove the deploy blocker label here since this seems like a case we missed in #6544 instead of a regression. I've posted in slack to double-check how we want to handle this case, but I think we can just make this a follow up to fix the missed case.
Removing the deploy blocker label and updating to daily and leaving assigned to me for now, but @isagoico I think we can check off #6544 if there aren't any regressions with search.
48 remaining items
roryabraham commentedon Jan 24, 2022
The fix for this was deployed to production 6 days ago. There were some comments on the PR but it sounds like an unrelated bug. So @adelekennedy I think we should be good to pay this out tomorrow.
adelekennedy commentedon Jan 24, 2022
Noted! Have it on my calendar to pay out on 1/25 - then I will close the job
mvtglobally commentedon Jan 25, 2022
@adelekennedy @roryabraham Can you check below video. We seem to be able to repro the issue.
6627.mp4
Also, we noticed that exact search match is not always displayed on Top. Not sure if its related to this PR

adelekennedy commentedon Jan 30, 2022
Double checking here @roryabraham the job is closed and paid out - but do we need to reopen the job?
roryabraham commentedon Jan 31, 2022
Honestly, I can't keep track of all the expected behavior in the labyrinth that is
OptionsListUtils. I think that we should close this and add a new issue to:New ChatorNew Grouppages, and for users that don't yet have Expensify accounts.Thoughts? cc @parasharrajat
parasharrajat commentedon Feb 1, 2022
Ok, nice thoughts @roryabraham. We should certainly do that. But #6627 (comment) is a different issue.
it is not the order of options. I think QA is saying that the search is not working properly. The exact match should come first.
So the search should also look into the personalDetails (contacts) with respect to Recent reports(chats). This should be a separate issue and thus we can close this and create a new one. Also, plan the order properly (based on your thoughts) and then fix it.
roryabraham commentedon Feb 5, 2022
Created a follow-up: #7582