Skip to content

[$250] Concierge Chat - The "Review your workspace settings" task doesn’t auto-complete #67648

Open

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.88-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2148171/test-runs/TR-328/folder/12015338/40253510/816207886
Email or phone of affected tester (no customers): biruknew45+29dded2@gmail.com
Issue reported by: Applause Internal Team
Device used: Web, mweb, android
App Component: Other

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Create a new user
  3. Select the purpose "Track and budget expenses"
  4. Click on "Continue" then Click on "Create Workspace"
  5. Finish the flow
  6. Go to concierge chat, verify there is "Review your workspace settings" task.
  7. Go to the Workspace settings and modify something
  8. Return back to the concierge chat

Expected Result:

After completing the steps in the "Review your workspace settings" task, the task should be automatically marked as completed.

Actual Result:

After completing the required steps, the "Review your workspace settings" task remains incomplete.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6904985_1754038003601.bandicam_2025-08-01_11-36-27-527.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021952614002181372040
  • Upwork Job ID: 1952614002181372040
  • Last Price Increase: 2025-08-05
  • Automatic offers:
    • FitseTLT | Contributor | 108410636
Issue OwnerCurrent Issue Owner: @FitseTLT

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 1, 2025
  2. melvin-bot commented on Aug 1, 2025

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. samranahm commented on Aug 1, 2025

    @samranahm
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-08-13 04:25:00 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The "Review your workspace settings" task doesn’t auto-complete

    What is the root cause of that problem?

    There is currently no logic to mark the task completed when we complete the steps for "Review your workspace settings" task

    What changes do you think we should make in order to solve the problem?

    We should use getFinishOnboardingTaskOnyxData

    App/src/libs/actions/Task.ts

    Lines 1311 to 1312 in c0ec500

    function getFinishOnboardingTaskOnyxData(taskName: IntroSelectedTask): OnyxData {
    const taskReportID = introSelected?.[taskName];

    when user visit workspace overview page and mark the task completed like we did for categories here

    function appendSetupCategoriesOnboardingData(onyxData: OnyxData) {
    const finishOnboardingTaskData = getFinishOnboardingTaskOnyxData('setupCategories');

    we need to update the type for reviewWorkspaceSettings and also add this into IntroSelected

    type IntroSelectedTask = 'viewTour' | 'createWorkspace' | 'setupCategories';

    type IntroSelectedTask = 'viewTour' | 'createWorkspace' | 'setupCategories' | 'reviewWorkspaceSettings';

    and on any first change to workspace either overview page or any other workspace setting change we can call

        getFinishOnboardingTaskOnyxData(CONST.ONBOARDING_TASK_TYPE.REVIEW_WORKSPACE_SETTINGS);

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. FitseTLT commented on Aug 1, 2025

    @FitseTLT
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Concierge Chat - The "Review your workspace settings" task doesn’t auto-complete

    What is the root cause of that problem?

    1. The REVIEW_WORKSPACE_SETTINGS type onboarding task steps is obsolete it tells the steps for the old case where the workspace settings was under settings tab

      App/src/languages/en.ts

      Lines 2411 to 2415 in 1dfb9cb

      description: ({workspaceSettingsLink}) =>
      "Here's how to review and update your workspace settings:\n" +
      '1. Click the settings tab.\n' +
      '2. Click *Workspaces* > [Your workspace].\n' +
      `[Go to your workspace](${workspaceSettingsLink}). We'll track them in the #admins room.`,
    2. We are not completing REVIEW_WORKSPACE_SETTINGS type onboarding task on updating or viewing workspace settings

    What changes do you think we should make in order to solve the problem?

    1. We should update the copy to align with the current step where the workspace has its own tab independently

      App/src/languages/en.ts

      Lines 2411 to 2415 in 1dfb9cb

      description: ({workspaceSettingsLink}) =>
      "Here's how to review and update your workspace settings:\n" +
      '1. Click the settings tab.\n' +
      '2. Click *Workspaces* > [Your workspace].\n' +
      `[Go to your workspace](${workspaceSettingsLink}). We'll track them in the #admins room.`,
    2. We will need to update appendSetupCategoriesOnboardingData function to be more generic and accept task name so that it will be used for other onboarding tasks here
      function appendSetupCategoriesOnboardingData(onyxData: OnyxData) {
      const finishOnboardingTaskData = getFinishOnboardingTaskOnyxData('setupCategories');
      onyxData.optimisticData?.push(...(finishOnboardingTaskData.optimisticData ?? []));
      onyxData.successData?.push(...(finishOnboardingTaskData.successData ?? []));
      onyxData.failureData?.push(...(finishOnboardingTaskData.failureData ?? []));
      return onyxData;
      }
    function appendFinishOnboardingTaskOnyxData(onyxData: OnyxData, taskName:IntroSelectedTask) {
        const finishOnboardingTaskData = getFinishOnboardingTaskOnyxData(taskName);
        onyxData.optimisticData?.push(...(finishOnboardingTaskData.optimisticData ?? []));
        onyxData.successData?.push(...(finishOnboardingTaskData.successData ?? []));
        onyxData.failureData?.push(...(finishOnboardingTaskData.failureData ?? []));
        return onyxData;
    }
    

    We can avoid the code appending onyxData because the completeTask is already applying the optimistice data to onyx here

    API.write(WRITE_COMMANDS.COMPLETE_TASK, parameters, {optimisticData, successData, failureData});
    return {optimisticData, successData, failureData};

    so we don't need to apply the onyx data again so we can refactor that 👍 .
    Then we update the current usages of appendSetupCategoriesOnboardingData by passing setupCategories task name and then we will use this function to this issue for the task name CONST.ONBOARDING_TASK_TYPE.REVIEW_WORKSPACE_SETTINGS and complete the job on updating workspace settings like for instance updateGeneralSettings updateWorkspaceDescription updateAddress, etc. Altenatively we can complete the task if a user opens the onboarding workspace overview page (or WORKSPACE_INITIAL or any workspace page) with useEffect for example but that's not what we do for setupCategories onboarding.

    We can do similar fixes for other onboarding tasks if needed.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    We can test that update settings of workspaces like updateGeneralSettings complete REVIEW_WORKSPACE_SETTINGS type onboarding tasks

    What alternative solutions did you explore? (Optional)

    This way of calling an independent completeTask on the onboarding task is a bit of a workaround to avoid additional BE changes but if we want to follow our 1-1-1 API rule then we will need to only update the optimistic data in onyx from FE without making COMPLETE_TASK API request and update the respective APIs like UPDATE_WORKSPACE_GENERAL_SETTINGS to complete the onboarding tasks on BE and push updates.

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 5, 2025
  6. changed the title [-]Concierge Chat - The "Review your workspace settings" task doesn’t auto-complete[/-] [+][$250] Concierge Chat - The "Review your workspace settings" task doesn’t auto-complete[/+] on Aug 5, 2025
  7. melvin-bot commented on Aug 5, 2025

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 5, 2025
  9. melvin-bot commented on Aug 5, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

  10. 166 remaining items

  11. jeffrey-graham commented on Nov 7, 2026

    @jeffrey-graham
  12. melvin-bot commented on Nov 7, 2026

    @melvin-bot
  13. melvin-bot commented on Nov 16, 2026

    @melvin-bot

    @FitseTLT / @situchan

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.39-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  14. FitseTLT commented on Nov 17, 2026

    @FitseTLT
    Contributor

    last pr pending

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorSkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions