Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.88-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2148171/test-runs/TR-328/folder/12015338/40253510/816207886
Email or phone of affected tester (no customers): biruknew45+29dded2@gmail.com
Issue reported by: Applause Internal Team
Device used: Web, mweb, android
App Component: Other
Action Performed:
- Go to https://staging.new.expensify.com/
- Create a new user
- Select the purpose "Track and budget expenses"
- Click on "Continue" then Click on "Create Workspace"
- Finish the flow
- Go to concierge chat, verify there is "Review your workspace settings" task.
- Go to the Workspace settings and modify something
- Return back to the concierge chat
Expected Result:
After completing the steps in the "Review your workspace settings" task, the task should be automatically marked as completed.
Actual Result:
After completing the required steps, the "Review your workspace settings" task remains incomplete.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6904985_1754038003601.bandicam_2025-08-01_11-36-27-527.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021952614002181372040
- Upwork Job ID: 1952614002181372040
- Last Price Increase: 2025-08-05
- Automatic offers:
- FitseTLT | Contributor | 108410636
Issue Owner
Current Issue Owner: @FitseTLTMetadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Aug 1, 2025
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.samranahm commentedon Aug 1, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-08-13 04:25:00 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
The "Review your workspace settings" task doesn’t auto-complete
What is the root cause of that problem?
There is currently no logic to mark the task completed when we complete the steps for "Review your workspace settings" task
What changes do you think we should make in order to solve the problem?
We should use
getFinishOnboardingTaskOnyxDataApp/src/libs/actions/Task.ts
Lines 1311 to 1312 in c0ec500
when user visit workspace overview page and mark the task completed like we did for categories here
App/src/libs/actions/Policy/Category.ts
Lines 88 to 89 in c0ec500
we need to update the type for
reviewWorkspaceSettingsand also add this intoIntroSelectedApp/src/types/onyx/IntroSelected.ts
Line 5 in 748dfe1
and on any first change to workspace either overview page or any other workspace setting change we can call
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
FitseTLT commentedon Aug 1, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Concierge Chat - The "Review your workspace settings" task doesn’t auto-complete
What is the root cause of that problem?
App/src/languages/en.ts
Lines 2411 to 2415 in 1dfb9cb
REVIEW_WORKSPACE_SETTINGStype onboarding task on updating or viewing workspace settingsWhat changes do you think we should make in order to solve the problem?
App/src/languages/en.ts
Lines 2411 to 2415 in 1dfb9cb
appendSetupCategoriesOnboardingDatafunction to be more generic and accept task name so that it will be used for other onboarding tasks hereApp/src/libs/actions/Policy/Category.ts
Lines 88 to 94 in 1dfb9cb
We can avoid the code appending onyxData because the completeTask is already applying the optimistice data to onyx here
App/src/libs/actions/Task.ts
Lines 484 to 485 in 1dfb9cb
so we don't need to apply the onyx data again so we can refactor that 👍 .
Then we update the current usages of appendSetupCategoriesOnboardingData by passing
setupCategoriestask name and then we will use this function to this issue for the task nameCONST.ONBOARDING_TASK_TYPE.REVIEW_WORKSPACE_SETTINGSand complete the job on updating workspace settings like for instanceupdateGeneralSettingsupdateWorkspaceDescriptionupdateAddress, etc. Altenatively we can complete the task if a user opens the onboarding workspace overview page (or WORKSPACE_INITIAL or any workspace page) with useEffect for example but that's not what we do for setupCategories onboarding.We can do similar fixes for other onboarding tasks if needed.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We can test that update settings of workspaces like updateGeneralSettings complete REVIEW_WORKSPACE_SETTINGS type onboarding tasks
What alternative solutions did you explore? (Optional)
This way of calling an independent completeTask on the onboarding task is a bit of a workaround to avoid additional BE changes but if we want to follow our 1-1-1 API rule then we will need to only update the optimistic data in onyx from FE without making
COMPLETE_TASKAPI request and update the respective APIs like UPDATE_WORKSPACE_GENERAL_SETTINGS to complete the onboarding tasks on BE and push updates.[-]Concierge Chat - The "Review your workspace settings" task doesn’t auto-complete[/-][+][$250] Concierge Chat - The "Review your workspace settings" task doesn’t auto-complete[/+]melvin-bot commentedon Aug 5, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021952614002181372040
melvin-bot commentedon Aug 5, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (
External)166 remaining items
jeffrey-graham commentedon Nov 7, 2026
melvin-bot commentedon Nov 7, 2026
melvin-bot commentedon Nov 16, 2026
@FitseTLT / @situchan
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.39-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
FitseTLT commentedon Nov 17, 2026
last pr pending