Skip to content

Part 4 - Fix review workspace settings onboarding task completion - #106399

Merged
robertjchen merged 1 commit into
Expensify:mainfrom
FitseTLT:fix-review-workspace-settings-update-part-4
Nov 13, 2026
Merged

robertjchen merged 1 commit into
Expensify:mainfrom
FitseTLT:fix-review-workspace-settings-update-part-4

Conversation

@FitseTLT

@FitseTLT FitseTLT commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

The "Review your workspace settings" onboarding task wasn't being marked complete when admins made various workspace-settings changes, because many backend write commands never passed the completedTaskReportActionID the backend needs to complete it optimistically.

This PR (Part 4) extends the established wiring pattern from Parts 1-3 to the commands confirmed via live testing to actually complete the task: category auto-categorize-new-expenses, tag enable/disable, tag list rename, create tag, and rename an individual tag.

Fixed Issues

$ #67648
PROPOSAL: N/A (direct engineering continuation of Parts 1-3, not a community proposal)

Tests

Precondition: use an account/workspace where the Concierge "Review your workspace settings" onboarding task is still outstanding (visible unchecked in the LHN/Concierge chat). This task only appears for accounts invited as admin to an existing workspace (newDotAdmin — assigned server-side, not from the "Get started" picker). Once you have one, no need to create a new workspace per test: just reopen the task (uncheck it in the Concierge chat) after each verification and retest.

  1. Enable the Categories and Tags features on the workspace (Workspace Settings > More features) if not already enabled.
  2. With a fresh outstanding task, go to Workspace Settings > Categories > overflow (⋯) menu > toggle "Auto-categorize new expenses". Verify the task ticks immediately (no delay/refresh needed).
  3. With a fresh outstanding task, go to Workspace Settings > Tags > toggle a single tag enabled/disabled from its row. Verify the task ticks.
  4. With a fresh outstanding task, bulk-enable or bulk-disable multiple tags from the Tags table. Verify the task ticks exactly once (not once per tag).
  5. With a fresh outstanding task, edit the tag list's custom name (Workspace Settings > Tags > tag list settings page) and Save. Verify the task ticks.
  6. With a fresh outstanding task, create a new tag (Workspace Settings > Tags > Add tag). Verify the task ticks.
  7. With a fresh outstanding task, rename an individual tag via the inline table edit (tap the tag's name directly in the Tags table). Verify the task ticks.
  8. With a fresh outstanding task, rename an individual tag via its dedicated edit page (tap into the tag > Name > edit > Save). Verify the task ticks.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
2026-11-09.19-13-54.mp4

@FitseTLT
FitseTLT requested review from a team as code owners November 9, 2026 16:59
@melvin-bot
melvin-bot Bot requested review from situchan and trjExpensify and removed request for a team November 9, 2026 16:59
@melvin-bot

melvin-bot Bot commented Nov 9, 2026

Copy link
Copy Markdown

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team November 9, 2026 17:00
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T17:15:39.239333Z 1099f9d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/libs/actions/Policy/Tag.ts 77.80% <100.00%> (+0.25%) ⬆️
...s/workspace/categories/WorkspaceCategoriesPage.tsx 77.63% <100.00%> (ø)
src/pages/workspace/tags/DynamicEditTagPage.tsx 0.00% <0.00%> (ø)
...es/workspace/tags/DynamicWorkspaceEditTagsPage.tsx 0.00% <0.00%> (ø)
...rc/pages/workspace/tags/WorkspaceCreateTagPage.tsx 0.00% <0.00%> (ø)
src/pages/workspace/tags/WorkspaceTagsPage.tsx 77.13% <60.00%> (+0.05%) ⬆️
src/libs/actions/Policy/Category.ts 52.22% <0.00%> (ø)
src/libs/actions/Policy/InlineEdit.ts 52.25% <0.00%> (-0.48%) ⬇️
...es/workspace/tags/DynamicWorkspaceViewTagsPage.tsx 58.43% <25.00%> (+0.25%) ⬆️
...rc/pages/workspace/tags/DynamicTagSettingsPage.tsx 0.00% <0.00%> (ø)
... and 49 files with indirect coverage changes

@trjExpensify
trjExpensify removed their request for review November 10, 2026 00:36
@trjExpensify

Copy link
Copy Markdown
Contributor

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

@situchan

situchan commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
1.mov
2.mov
3.mov
4.mov
5.mov

@melvin-bot
melvin-bot Bot requested a review from robertjchen November 10, 2026 17:33

@robertjchen robertjchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robertjchen

Copy link
Copy Markdown
Contributor

closing and re-opening to re-trigger some stuck GH actions

@robertjchen robertjchen reopened this Nov 12, 2026
@robertjchen
robertjchen merged commit e49e4ae into Expensify:main Nov 13, 2026
38 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 robertjchen has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/robertjchen in version: 9.5.38-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR fixes onboarding task completion after existing workspace settings changes, restoring expected behavior without adding a feature or making existing article instructions incorrect.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.39-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants