Repository navigation
Closed
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 9.1.89-21
Compare Changes: production...staging
💡 Deployer FYI: This checklist was generated using a new process. PR list from original method and detail logging can be found in the most recent deploy workflow labeled
staging, in thecreateChecklistaction. Please tag @Julesssss with any issues.
This release contains changes from the following pull requests:
- [NoQA] Implemented over trip limit violation #63248
- Conditionally show/hide columns #63501
- Removing violations for duplicate transactions. #65107
- Hover-to-view for receipt thumbnails #65184
- Fix - Add Expense back navigation lacks top padding #65236
- [Avatars - Reports] Use centralized logic for report actions avatars everywhere in the app #65740
- Vacation delegate ALL features (add, remove, view) #65838
- fix: clear after row flickers #66013
- Reanimated modal for validate code action modal #66046
- Fix - Connect bank account-You appear to be offline is not displayed when starting over #66208
- Fix - 2FA- 2FA verifying page is not fully displayed because keyboard open #66213
- Fix share extension ivalid file type by adding
image/heictoSHARE_FILE_MIMETYPE#66636 - feat: standardize pay button for expenses and IOUs #66790
- Merge empty tag and category subtitle translations #66795
- Improve navigation behavior when opening expenses from report #66852
- Migrate ComparePlansModal #66868
- Fix horizontal padding when opening a receipt while creating expenses with Multi-Scan #66889
- Fix/65916 Added imported contacts to new chat page #66910
- fix: onTextContextMenuItem crash #66925
- [Part 3]: Remove usage of Onyx.connect for ONYXKEYS.COUNTRY_CODE #66941
- [Part 4]: Remove usage of Onyx.connect for ONYXKEYS.COUNTRY_CODE #66947
- Fix canBeMissing alert for for key transactionsDraft_1 [No QA] #66970
- mWeb - Incorrect navigation to confirm details page & discard changes popup briefly visible #67010
- Fix/66602 - Report field shows a broken icon instead of the custom global create emoji #67030
- [NO QA] Update Uber.md #67044
- [No QA] Make search a read command #67114
- Task not auto completed after completing test drive through Reports tab #67124
- Refactor
toggleProfileToolto remove usage ofOnyx.Connect#67133 - Update Billing-Overview.md #67174
- Remove call to
getReportNameValuePairs()in method getIcons fromReportUtils.ts. #67178 - [No QA] Add a page to our docs about our routing philosophy #67188
- Unexpected error submitting this expense error during expense submit #67190
- fix: Workspace - Taxes - Can't press Enter on creating tax rate #67191
- Refactor function in Search.ts to remove usage of Onyx.Connect #67205
- do not allow changing card assignee from members page #67207
- feat: 65634 Reduce initial amount of items per page of selection list #67236
- Refactor TransactionItemRowRBRWithOnyx #67247
- Migrate BusinessTypeSelectorModal to use Reanimated modal #67249
- fix:66988: [Compose Box] Added removeClippedSubviews false to keep elements in virtual tree #67258
- reset to default query search if previous error #67295
- fix: Remove call to getReportNameValuePairs() in method canSeeDefaultRoom #67298
- Reports - Saved search tab is still highlighted after renaming and switching to another tab #67301
- Assign expense creator as the default assignee for expenses where no assignee is present #67306
- Expenses Deleted on OD Cause Blank Report View on ND #67308
- perf: move useOnyx from ReportActionItem to list component #67309
- Fix/65479 - Leave option is not shown for IOU invite #67338
- fix: currency not resetting to default currency on page reload while creating a new manual expense #67342
- Update Deleted Transaction report action copy #67365
- [NoQA] Add
webpack-dev-serverGC plugin & script for auto-restart on crash #67373 - Bump react-native-onyx to 2.0.130 #67381
- fix multi level tag issue #67389
- fix screen transition issue on payment currency selector #67391
- Refactored localeCompare in TagsOptionsListUtils #67397
- Refactored localeCompare in SidebarUtils #67399
- Refactored localeCompare in PolicyUtils #67402
- Refactored localeCompare in SearchUIUtils #67404
- fix: Remove full screen loader from RHP on magic code submit #67406
- Refactored localeCompare in ReportUtils (part 1) #67431
- fix: Extra space at end of magic code #67441
- allow task assignee to edit task after leaving group #67454
- fix: Contact name not displayed in expense #67457
- fix: Description link in expense thread is rendered as HTML tags #67460
- Create control workspace if its a control feature #67465
- fix: fallback avatar shown in reports page when RHP is open and page is not in focus #67470
- fix: autoRenew is not enabled in the control plan #67473
- Fix creating second scan expense unexpected error is shown #67479
- fix: Always navigate back from policy after deleting it #67482
- [NoQA] Fix ESLint warnings and update limit #67484
- fix: Members page - wrong description is shown on members import page after importing multi level tag . #67485
- [No QA]: refactor
libs/actions/OnyxUpdateManager/utils/index.tsto useOnyx. connectWithoutView#67532 - [No QA]: Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.DOWNLOAD in src/libs/actions/Download.ts #67537
- [No QA]: Remove Onyx.connect() for the key: ONYXKEYS.DEVICE_ID in src/libs/actions/Device/index.ts #66501 #67538
- [NoQA] Replaced Onyx.connect with Onyx.connectWithoutView in e2eLogin #67539
- [No QA]: Update waitForAppLoaded.ts to use
connectWithoutView#67543 - fix: expense - user avatar is shown in report in which expense is notadded #67549
- [NO QA] Increase failed checks limit after large refactored Signin page #67554
- [No QA] Improve onyx update logging #67581
- [No QA] Add missing deps #67582
- [NoQA] Testing: checkCoverageChanges.sh Update #67587
- [No QA] chore: remove call to getReportNameValuePairs in getMoneyRequestOptions #67600
- [NoQA] Test Coverage Refactoring and Fixes #67602
- [NoQA]
webpack-dev-serverGC Plugin & Script Follow-Up #67604 - fix: remove call to getReportNameValuePairs() in method reasonForReportToBeInOptionList #67612
- Update Connect-a-Personal-Bank-Account.md #67657
- fix:67343: Removed the sorting restriction when status is an array #67660
- [No QA] fix: typecheck #67695
- Fix PR 67030 - Emojis disappear after the user sends the message #67696
- [NoQA] Coverage: Fixed Template / Upstream Main / Baseline #67706
- [NoQA] Fix ESLint warning and update the max number #67708
- [CP Staging] Fix hybridApp Android magic code bug #67819
- [CP Staging] Add feed filter if default is unavailable #67825
- [CP Staging] Fix - Some emojis sent are not shown in conversation #67868
- [CP Staging] Revert "Bump react-native-onyx to 2.0.130" #67878
- [CP Staging][Avatars - Reports] Follow-ups to fix deploy blockers #67881
- [CP Staging] fix: prevent selectPaymentType from getting triggered twice #67902
- [CP staging] Fix app stuck on
Signing outdialog after signing out of classic on HybridApp #67905 - [CP Staging] Revert "Fix/65479 - Leave option is not shown for IOU invite" #67910
- [CP Staging][Avatars - Reports] Follow-ups to fix deploy blockers cont. #67913
- [CP Staging] Revert https://github.com/Expensify/App/pull/67295 #67915
- [CP Staging] fix: crash when submitting expense to workspace #67927
- [CP Staging] Revert "Hover-to-view for receipt thumbnails" #67950
- [CP Staging] Fix missing to field for first invoice #67963
- [CP Staging] Fix report creation bug #67966
- [CP Staging] Update condition to prevent scrolling to end when there is a new message #67982
- [CP Staging] Revert "Bring back new SignInPage" #67992
- [CP Staging][Avatars] Display subscript for single expenses & invoices in Workspace #67993
- [CP Staging] Revert "Fix creating second scan expense unexpected error is shown" #68006
- [CP Staging] Revert "Merge pull request #63501 from Expensify/youssef_auto_show_hide_columns" #68017
- 🍒 Cherry pick PR #68017 to staging 🍒 #68022
Internal QA:
Deploy Blockers:
- [Due for payment 2025-08-15] [RCA #65740] Reports - Workspace avatar shows fallback avatar in workspace list #67809
- Expense - App crashes after resolving duplicates #67810
- [Due for payment 2025-08-15] [$250] Expense - RHP shows not here page when it is dismissing after unreporting expense #67811
- [Due for payment 2025-08-15] [RCA #65178] Stuck after signing out of classic on HybridApp #67812
- [Due for payment 2025-08-20] [Due for payment 2025-08-15] Expense - Description field on the expense row shows HTML tags when description has mark down #67813
- [Due for payment 2025-08-15] [Ready for payment Aug 13th] [RCA #65178] Android - stuck at magic code step of sign in #67814
- [Due for payment 2025-08-15] [RCA #65740] Expense - Expense preview avatar shows fallback avatar when user has previous chat #67815
- Reports - Receipt preview shows 403 error when hovering over receipt while it is uploading #67827
- [Due for payment 2025-08-15] [$250] Reports - Total and Action column is on the middle of expense row briefly after submit invoice #67829
- [RCA #66790] Expense - LHN preview shows "workspace paid" instead of "workspace paid amount" #67830
- Expense - Expense which is not selected still persists after resolving duplicates #67832
- Expense - Expenses are not sorted after clicking on Description table header #67834
- [Due for payment 2025-08-15] [RCA #66790] Expense - Mark as paid is registered twice when paying IOU report and error shows up #67835
- [Due for payment 2025-08-15] [RCA #63501] Expense - Total column is not on the right end of table in IOU report when merchant is absent #67836
- Workspace icon and User icon still shown after deleting WS #67838
- [Due for payment 2025-08-15] [RCA #65740] Room - Unable to open room avatar in full screen #67840
- [Due for payment 2025-08-15] Reports - Task - Missing Description table title, Share in and Assignee header are misaligned #67841
- [Due for payment 2025-08-15] [RCA #65740] Workspace settings - Members are displayed with a fallback avatar in Add Approval Workflow #67842
- [Due for payment 2025-08-15] Reports - Expense submitted offline, doesn´t appear until turning internet connection on. #67843
- [Due for payment 2025-08-15] [RCA #65740] FAB - Fallback avatars when there's no default Workspace when creating or moving report #67844
- [Due for payment 2025-08-15] Reports - New message button appears and disappears when expense RHP is opened #67845
- [Due for payment 2025-08-22] [RCA #65740] Report - When moving report to another WS offline, previous avatar is still shown on preview #67846
- [$250] Search-When searching with "type:chat" query, user is navigated to Reports/ Expenses #67847
- [Due for payment 2025-09-04] [RCA #65178] iOS - App opens OD with no email ID and crashes in Settings after logging in via public room #67848
- [Due for payment 2025-08-15] [RCA #65178] Android - App is stuck at splash screen when relaunching app after opening login via public room #67849
- [$250] Distance - App crashes after creating two distance expenses in the WS chat and opening report #67850
- [Due for payment 2025-08-15] [RCA #63501] Reports - Reports page results is empty after returning from inbox via browser back button #67852
- Reports - App crashes after clicking on table header title while expenses are selected #67854
- [Due for payment 2025-08-15] [RCA #65740] Chat - Tooltip of non-existing account does not show email #67856
- [Due for payment 2025-08-15] Chat - Some emojis sent are not shown in conversation #67862
- [Due for payment 2025-09-12] iOS - Login - Extra padding above "Done" row in language menu when accessed via public room #67863
- Expense - Leave option in empty report is always shown for non-admin approver #67864
- Thread - The thumbnail of the conversation doesn't contain a smaller thumbnail of the WS #67865
- [PAY][$250] Expense - Transaction thread does not scroll down to show the sent message in Reports #67867
- [RCA #67479] Scan receipt - It's not here page when edit amount split expense in DM group #67876
- [Due for payment 2025-08-15] [RCA #65740] Invoice - Message sent by sender & receiver show the same invoice room avatar #67879
- [Due for payment 2025-08-15] [RCA #66790] Reports - App crash when employee send an expense to WS admin #67903
- [$250] Warning: Trying to apply "merge" console errors when finishing onboarding #67906
- Email - The invited user redirects to the Home page instead of the created room #67920
- [Due for payment 2025-08-15] Search does not respect RHP-applied filters on the Reports > Expenses view #67923
- [RCA #66790] Expense - Not here page opens when trying to pay IOU via workspace after reset app #67929
- Android - App is stuck on splash screen when switching from ND to OD and back to ND #67939
- [Due for payment 2025-09-04] Android - User signed out of app when updating to '9.1.89-7' #67949
- [Due for payment 2025-08-22] [RCA #65740] Chat - User avatar shows fallback avatar in the reaction modal #67955
- [Due for payment 2025-08-20] [RCA #65740] Expense - New workspace on confirm page shows a fallback avatar when sharing with accountant #67956
- [Due for payment 2025-08-22] [RCA #65740] Invoice - Workspace in Send from list is missing workspace avatar #67957
- [Due for payment 2025-08-20] [RCA #65740] Invoice - Not here page opens when opening one of the avatars in B2B invoice room #67958
- [Due for payment 2025-08-15] [RCA #65740] IOU - Workspace avatar is missing in the header of the each WS expense and in details #67975
- [Due for payment 2025-08-22] [$50] IOU - Payer pay IOU, Amount page in Submitter turns into 'It's not here" #67983
Deployer verifications:
- I checked Firebase Crashlytics for this release version and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked Firebase Crashlytics for the previous release version and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Metadata
Metadata
Assignees
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
github-actions commentedon Aug 4, 2025
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.1.89-1 🚀
IuliiaHerets commentedon Aug 5, 2025
Regression is at 84% completed
Blockers:
#67809
#67810
#67811
#67812
#67813
#67814
#67815
#67827
#67829
#67830
#67832
#67834
#67835
#67836
#67838
#67840
#67841
#67842
#67843
#67844
#67845
#67846
#67847
#67848
#67849
#67850
#67852
#67854
#67856
#67862
#67863
#67864
#67865
Unchecked PRs:
#63501 - pending validation on all,
#65184 - pending validation on all,
#65236 - pending validation on mWeb and Native apps,
#65740 - pending validation on all,
#66046 - pending validation on Web, mWeb, Desktop and iOS,
#66208 - pending validation on Desktop and Native apps,
#66790 - pending validation on all,
#66852 - pending validation on Native apps,
#66947 - faced with #60770 on mWeb and Android, pending validation on Desktop,
#67030 - failed with original issue in Android app (comment),
#67178 - failed with #67838,
#67191 - pending validation on Desktop and Native apps,
#67207 - pending validation on all,
#67249 - pending validation on all,
#67295 - pending validation on Native apps,
#67298 - pending validation on Desktop,
#67301 - pending validation on Android,
#67306 - pending validation on all,
#67308 - pending validation on Desktop and Native apps,
#67309 - pending validation on Desktop,
#67338 - pending validation on Desktop,
#67342 - pending validation on Android,
#67365 - failed with #67861, pending validation on Desktop,
#67381 - pending validation on Desktop,
#67399 - pending validation on mWeb and Android,
#67404 - pending validation on mWeb and Android,
#67406 - pending validation on Android,
#67441 - pending validation on mWeb,
#67454 - pending validation on Desktop and iOS,
#67457 - pending validation on all,
#67460 - pending validation on Android,
#67470 - pending validation on all,
#67473 - pending validation on mWeb, Desktop and Native apps,
#67479 - pending validation on all,
#67482 - pending validation on Android,
#67612 - pending validation on Desktop,
#67660 - faced with #67837.
cristipaval commentedon Aug 5, 2025
Checking off #67338 - I reverted it to fix #67864
kavimuru commentedon Aug 5, 2025
Regression is at 96% progress.
Unchecked PRs:
#63501 Pending validation on all the platforms
#65184 Pending validation on all but web
#65236 Pending validation on mweb android and iOS
#65740 Pending validation on all the platforms
#66208 Pending validation android and iOS
#66790 Pending validation on all the platforms
#66852 Pending validation on iOS
#66947 Pending validation on Desktop
#67178 failing with #67838
#67306 Pending validation on all the platforms
#67365 Failing with #67861 repro in PROD checking it off
#67406 Pending validation on Android
#67441 Pending validation on mweb
#67479 Pending validation on mweb and iOS
roryabraham commentedon Aug 5, 2025
Demoted #67867
grgia commentedon Aug 5, 2025
It's been a day!
🌥️ 🌤️ ☀️
⬇️ - demoted
🍒 - fix merged & CPd
🍒 Reports - Workspace avatar shows fallback avatar in workspace list #67809
🍒 Expense - Expense preview avatar shows fallback avatar when user has previous chat #67815
🍒Room - Unable to open room avatar in full screen #67840
🍒 FAB - Fallback avatars when there’s no default Workspace when creating or moving report #67844
🍒 Workspace settings - Members are displayed with a fallback avatar in Add Approval Workflow #67842
⬇️ Thread - The thumbnail of the conversation doesn’t contain a smaller thumbnail of the WS #67865
🍒Invoice - Message sent by sender & receiver show the same invoice room avatar #67879
⬇️ Workspace icon and User icon still shown after deleting WS #67838
⬇️ Report - When moving report to another WS offline, previous avatar is still shown on preview #67846
🍒 Chat - Tooltip of non-existing account does not show email #67856
🍒 Expense - LHN preview shows "workspace paid" instead of "workspace paid amount" #67830
🍒 Expense - Mark as paid is registered twice when paying IOU report and error shows up
#67835
🍒 Reports - App crash when employee send an expense to WS admin #67903
grgia commentedon Aug 5, 2025
QA'd #67881, checking off
Julesssss commentedon Aug 5, 2025
Hey @jasperhuangg, as mentioned here we'll be reverting the big mobile signin page changes. We resolved the early reported issues, but some more were reported. This will need to be done tomorrow as there are many changes across Mobile-Expensify and App with recent additions that prevent a simple revert from being prepared. This should resolve the following:
kavimuru commentedon Aug 5, 2025
Regression is 99% progress
Unchecked PRs:
#63501 pending validation on mweb, android, iOS and Desktop
#65184 Pending validation on mweb, android and iOS
#65740 Pending validation on mweb, android and iOS failing on web with bug #67962 repro in PROD
#66208 Pending validation on iOS
#66790 Pending validation on web, desktop android and iOS
#67306 (comment)
Julesssss commentedon Aug 5, 2025
Signing outdialog after signing out of classic on HybridApp #67905kavimuru commentedon Aug 6, 2025
Regression is 99% progress
Unchecked PRs:
#63501 pending validation on Desktop
#65740 Pending validation on mweb, android failing with bug #67962
#66790 Pending validation on desktop
#67306 (comment)
grgia commentedon Aug 6, 2025
I've tested and confirmed issues that have been fixed, continuing down list
grgia commentedon Aug 6, 2025
confirmed #67852 is fixed
jasperhuangg commentedon Aug 6, 2025