Skip to content

Support Self DM whisper actions work when transaction thread isn't created + Manager McTest expense correct work support #67889

Closed

Description

@iwiznia

Coming from https://expensify.slack.com/archives/C01GTK53T8Q/p1754312353125749?thread_ts=1754046904.633659&cid=C01GTK53T8Q

Related to #58828

Support Self DM whisper actions work when transaction thread isn't created + Manager McTest expense correct work support

Activity

  1. self-assigned this
    on Aug 8, 2025
  2. roryabraham commented on Aug 8, 2025

    @roryabraham
    Contributor

    going to help shepherd this while @iwiznia is OOO

  3. melvin-bot commented on Aug 11, 2025

    @melvin-bot

    @iwiznia, @hungvu193, @VickyStash, @roryabraham Whoops! This issue is 2 days overdue. Let's get this updated quick!

  4. VickyStash commented on Aug 12, 2025

    @VickyStash
    Contributor

    Not overdue, will be implemented in the order described here.

  5. 1 remaining item

  6. VickyStash commented on Aug 18, 2025

    @VickyStash
    Contributor

    Not overdue, should be taken into work when this PR is merged

  7. VickyStash commented on Aug 19, 2025

    @VickyStash
    Contributor

    Context: before we tried to implement no transaction thread creation in one PR. But it was reverted due to regressions several time, so we decided to split the work into pieces.

    The last PR that was reverted: #63931 (you can check some the updates there)

    More detailed description of the scope of work:

    First of all, test how Self DM expenses and Manager McTest expenses work when no optimistic transaction thread report is created:

    1. Turn on the noOptimisticTransactionThreads beta.
    2. In the troubleshoot section turn on Block transaction thread report creation toggle (you can also turn it on in the troubleshoot modal CMD + D)
    3. Open Self DM chat and create an expense. Test all of the flows you can think of. Fix any issues you find.
    4. Open the Manager McTest chat and create an expense. Test all of the flows you can think of. Fix any issues you find.

    Flows to pay attention to (regressions previous time):
    #63493
    #63511

    Fixes I had you can check here: #63931 (comment)

  8. VickyStash commented on Aug 20, 2025

    @VickyStash
    Contributor

    I'm starting to work on this one!

  9. VickyStash commented on Aug 20, 2025

    @VickyStash
    Contributor

    @hungvu193 It tests well for me on the main, including previously reported regressions:
    #63493
    #63511

    Can you please check it on your side as well?

  10. hungvu193 commented on Aug 20, 2025

    @hungvu193
    Contributor

    @hungvu193 It tests well for me on the main, including previously reported regressions: #63493 #63511

    Can you please check it on your side as well?

    Yep, I also couldn't reproduce

  11. VickyStash commented on Aug 21, 2025

    @VickyStash
    Contributor

    Great, then we can skip it for now and do another check before beta flag removal (all of the functionality is implemented)!

  12. melvin-bot commented on Aug 26, 2025

    @melvin-bot

    @iwiznia, @hungvu193, @VickyStash, @roryabraham Eep! 4 days overdue now. Issues have feelings too...

  13. roryabraham commented on Aug 27, 2025

    @roryabraham
    Contributor

    While I don't know that this explicitly needs to be on HOLD, I believe it's effectively on HOLD as @VickyStash and gang are primarily focused on #68536

  14. VickyStash commented on Aug 27, 2025

    @VickyStash
    Contributor

    This issue already tests well after this PR: #68290 was merged. Most likely we won't need to do anything else here

  15. roryabraham commented on Aug 27, 2025

    @roryabraham
    Contributor

    ok, great. Let's close it out then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions