You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Support Self DM whisper actions work when transaction thread isn't created + Manager McTest expense correct work support #67889
Context: before we tried to implement no transaction thread creation in one PR. But it was reverted due to regressions several time, so we decided to split the work into pieces.
The last PR that was reverted: #63931 (you can check some the updates there)
More detailed description of the scope of work:
First of all, test how Self DM expenses and Manager McTest expenses work when no optimistic transaction thread report is created:
Turn on the noOptimisticTransactionThreads beta.
In the troubleshoot section turn on Block transaction thread report creation toggle (you can also turn it on in the troubleshoot modal CMD + D)
Open Self DM chat and create an expense. Test all of the flows you can think of. Fix any issues you find.
Open the Manager McTest chat and create an expense. Test all of the flows you can think of. Fix any issues you find.
Flows to pay attention to (regressions previous time): #63493 #63511
While I don't know that this explicitly needs to be on HOLD, I believe it's effectively on HOLD as @VickyStash and gang are primarily focused on #68536
Activity
roryabraham commentedon Aug 8, 2025
going to help shepherd this while @iwiznia is OOO
melvin-bot commentedon Aug 11, 2025
@iwiznia, @hungvu193, @VickyStash, @roryabraham Whoops! This issue is 2 days overdue. Let's get this updated quick!
VickyStash commentedon Aug 12, 2025
Not overdue, will be implemented in the order described here.
1 remaining item
VickyStash commentedon Aug 18, 2025
Not overdue, should be taken into work when this PR is merged
VickyStash commentedon Aug 19, 2025
Context: before we tried to implement no transaction thread creation in one PR. But it was reverted due to regressions several time, so we decided to split the work into pieces.
The last PR that was reverted: #63931 (you can check some the updates there)
More detailed description of the scope of work:
First of all, test how Self DM expenses and Manager McTest expenses work when no optimistic transaction thread report is created:
noOptimisticTransactionThreadsbeta.Block transaction thread report creation toggle(you can also turn it on in the troubleshoot modal CMD + D)Flows to pay attention to (regressions previous time):
#63493
#63511
Fixes I had you can check here: #63931 (comment)
VickyStash commentedon Aug 20, 2025
I'm starting to work on this one!
VickyStash commentedon Aug 20, 2025
@hungvu193 It tests well for me on the main, including previously reported regressions:
#63493
#63511
Can you please check it on your side as well?
hungvu193 commentedon Aug 20, 2025
Yep, I also couldn't reproduce
VickyStash commentedon Aug 21, 2025
Great, then we can skip it for now and do another check before beta flag removal (all of the functionality is implemented)!
melvin-bot commentedon Aug 26, 2025
@iwiznia, @hungvu193, @VickyStash, @roryabraham Eep! 4 days overdue now. Issues have feelings too...
roryabraham commentedon Aug 27, 2025
While I don't know that this explicitly needs to be on HOLD, I believe it's effectively on HOLD as @VickyStash and gang are primarily focused on #68536
VickyStash commentedon Aug 27, 2025
This issue already tests well after this PR: #68290 was merged. Most likely we won't need to do anything else here
roryabraham commentedon Aug 27, 2025
ok, great. Let's close it out then