Skip to content

[Due for payment 2025-11-26] [Multiple PRs] Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.POLICY_TAGS in src/libs/actions/Policy/Tag.ts #69022

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @shubham1206agra

Activity

  1. self-assigned this
    on Aug 22, 2025
  2. tgolen commented on Aug 22, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 22, 2025
  4. melvin-bot commented on Aug 22, 2025

    @melvin-bot

    Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. 109 remaining items

  6. melvin-bot commented on Dec 16, 2025

    @melvin-bot

    This issue has not been updated in over 15 days. @tgolen, @strepanier03, @dariusz-biela, @shubham1206agra, @Guccio163 eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  7. shubham1206agra commented on Dec 16, 2025

    @shubham1206agra
    Contributor

    @Guccio163 Bump here

  8. melvin-bot commented on Jan 26, 2026

    @melvin-bot

    Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  9. melvin-bot commented on Apr 9, 2026

    @melvin-bot

    @tgolen, @youssef-lr, @strepanier03, @dariusz-biela, @shubham1206agra, @Guccio163, this Monthly task hasn't been acted upon in 6 weeks; closing.

    If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

  10. reopened this on Apr 10, 2026
  11. tgolen commented on Apr 10, 2026

    @tgolen
    ContributorAuthor

    I looked through the PRs and I agree with $2500.

  12. mallenexpensify commented on Apr 13, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @shubham1206agra due $2500 via NewDot

    Hid two payment summaries above, didn't see any posts for those payments being approved so we should be all set, me thinks.

  13. JmillsExpensify commented on May 1, 2026

    @JmillsExpensify
    Contributor

    $2,500 approved for @shubham1206agra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringImprovementItem broken or needs improvement.MonthlyKSv2Not a priority

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions