Repository navigation
refactor: isolates deletePolicyTags from Onyx.connect data - #70642
Merged
Conversation
war-in
approved these changes
Sep 16, 2025
Comment on lines
+648
to
+649
| const fakePolicy = createRandomPolicy(0); | ||
| const result = deletePolicyTags(fakePolicy.id, ['tag1'], {}); |
Contributor
There was a problem hiding this comment.
Do we have to create the fake policy here? 🤔 Can't we just pass some random string?
Contributor
Author
There was a problem hiding this comment.
Thanks, you're right.
And you actually gave me the idea that this test isn't the best.
I'm replacing it with two others:
- should not modify Onyx data when policyTags is empty
- should not modify Onyx data when tagsToDelete do not exist
Comment on lines
-683
to
+674
| .then( | ||
| () => | ||
| new Promise<void>((resolve) => { | ||
| const connection = Onyx.connect({ | ||
| key: `${ONYXKEYS.COLLECTION.POLICY_TAGS}${fakePolicy.id}`, | ||
| waitForCollectionCallback: false, | ||
| callback: (policyTags) => { | ||
| Onyx.disconnect(connection); | ||
| // Verify optimistic data | ||
| let updatePolicyTags: PolicyTagLists | undefined; | ||
| await TestHelper.getOnyxData({ | ||
| key: `${ONYXKEYS.COLLECTION.POLICY_TAGS}${fakePolicy.id}`, | ||
| callback: (val) => (updatePolicyTags = val), | ||
| }); |
- should not modify Onyx data when policyTags is empty - should not modify Onyx data when tagsToDelete do not exist
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Reviewer Checklist
Screenshots/VideosScreen.Recording.2025-09-18.at.11.33.57.PM.mov |
shubham1206agra
approved these changes
Sep 18, 2025
Contributor
|
🚀 Deployed to staging by https://github.com/tgolen in version: 9.2.16-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.2.16-14 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This PR is part of a refactor to remove
Onyx.connectfrom thesrc/libs/actions/Policy/Tag.tsfile and replace it withuseOnyx.It isolates the
deletePolicyTagsfunction from theOnyx.connectdata.To ensure this refactor doesn't break anything, it adds automated tests to the
deletePolicyTagsfunction.Fixed Issues
This PR partially addresses these issues:
$ #69022
PROPOSAL:
Tests
Prerequisites:
Offline tests
N/A Same as in the Tests section
QA Steps
Same as in the Tests section
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Nagranie.z.ekranu.2025-09-16.o.12.26.05.mov