Skip to content

[Due for payment 2026-04-20] [Due for payment 2026-03-31] [Merge] Enable users to select tax rate when merging expenses, auto-calculate tax amount. #70058

Closed

Description

@garrettmknight

Part of the Merge Expenses project

Main issue: https://github.com/Expensify/Expensify/issues/496985

Feature Description

When merging two expenses that have tax rates selected, we'll do the following:

  • To ensure there are no conflicts between the user selecting a tax rate and a tax amount that doesn’t compute, we’ll only allow users to select ‘tax rate’ in the details to keep.
  • Where tax rates for the two expenses differ, allow the user to select the tax rate in the details page.
  • Show the resulting tax in the confirm page, applying the tax rate to the selected amount.

This method can still result in some conflicts, but they also exist on Classic:

  • The selected tax rate could be invalid based on the workspace the selected report is on.
  • The selected tax rate could conflict with category rules for tax rates.

Manual Test Steps

  1. Create two expenses with different expense amounts and tax rates
  2. More > Merge
  3. Select one of the tax rates and an amount in the details selector page
  4. In the cofirm page, ensure that the rate and amount are used to calculate the resulting tax amount.

Automated Tests

Issue OwnerCurrent Issue Owner: @hoangzinh

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 8, 2025
  2. melvin-bot commented on Sep 8, 2025

    @melvin-bot

    Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. moved this to Second Cohort - CRITICAL in [#whatsnext] #migrateon Sep 8, 2025
  4. RachCHopkins commented on Sep 11, 2025

    @RachCHopkins
    Contributor

    Can someone tell me please, who is the C+ on this one?

  5. dominictb commented on Sep 11, 2025

    @dominictb
    Contributor

    I'll implement this while @hoangzinh is the C+.

  6. melvin-bot commented on Sep 15, 2025

    @melvin-bot

    @hoangzinh Whoops! This issue is 2 days overdue. Let's get this updated quick!

  7. 89 remaining items

  8. melvin-bot commented on Apr 10, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  9. melvin-bot commented on Apr 10, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  10. jponikarchuk commented on Apr 10, 2026

    @jponikarchuk

    Deploy Blocker #87616 was identified to be related to the PR #84769 that attempted to fix this issue.

  11. lanitochka17 commented on Apr 10, 2026

    @lanitochka17

    Deploy Blocker ##87640 was identified to be related to the PR ##84769 that attempted to fix this issue.

  12. melvin-bot commented on Apr 10, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  13. changed the title [-][Due for payment 2026-03-31] [Merge] Enable users to select tax rate when merging expenses, auto-calculate tax amount.[/-] [+][Due for payment 2026-04-20] [Due for payment 2026-03-31] [Merge] Enable users to select tax rate when merging expenses, auto-calculate tax amount.[/+] on Apr 13, 2026
  14. melvin-bot commented on Apr 13, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Apr 13, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.58-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-04-20. 🎊

    For reference, here are some details about the assignees on this issue:

    • @hoangzinh requires payment through NewDot Manual Requests
    • @dominictb does not require payment (Contractor)
  16. melvin-bot commented on Apr 13, 2026

    @melvin-bot

    @hoangzinh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions