Skip to content

[Due for payment 2025-09-22] Expense - "Moved this expense to" without report number seen after merging track expense. #70338

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.9-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #68204
Email or phone of affected tester (no customers): ibellicotest+1769@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 / Android 12 / Chrome ( mWeb) - Windows 11 / Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Account has at least two workspaces.
Prerequisite 2: Account has a Self DM.

  1. Open the staging.new.expensify.com website.
  2. Open any workspace chat.
  3. Create a manual expense.
  4. Return to "Inbox"
  5. Create a new manual expense and submit it to Self DM.
  6. Tap on "Submit to someone" below the expense.
  7. Submit the expense to a workspace different than the used on step 2.
  8. Navigate to workspace where track expense was submitted.
  9. Open the report.
  10. Tap on "More" and select "Merge"
  11. Select the expense created on step 3 and tap on "Continue"
  12. Select all the details of expense created on step 3 and finish the merging process.
  13. When redirected to chat, navigate to the report of the remaining expense.
  14. Note that two "Moved this expense to" messages are displayed, but one of them doesn´t show any report number.

Expected Result:

When merging a track expense, the "Moved this expense" message generated, should still show a report number.

Actual Result:

When merging a track expense, two "Moved this expense to" system messages are seen, but only the second one displays a report number in it.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Image
Bug6941025_1757548423467.Merge.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @VictoriaExpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Sep 11, 2025
  2. melvin-bot commented on Sep 11, 2025

    @melvin-bot

    Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Sep 11, 2025

    @melvin-bot

    Triggered auto assignment to @mollfpr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Sep 11, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Sep 11, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. francoisl commented on Sep 11, 2025

    @francoisl
    Contributor
  7. hoangzinh commented on Sep 11, 2025

    @hoangzinh
    Contributor

    @dominictb @youssef-lr, When expenses are merged multiple times, the previous toReportID may reference a deleted report, making it impossible to retrieve the report name for display here

    const movedTransactionOriginalMessage = getOriginalMessage(action as OnyxTypes.ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.MOVED_TRANSACTION>) ?? {};
    const {toReportID} = movedTransactionOriginalMessage as OriginalMessageMovedTransaction;
    const toReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${toReportID}`];
    children = (
    <ReportActionItemBasicMessage message="">
    <RenderHTML html={`<comment><muted-text>${getMovedTransactionMessage(toReport)}</muted-text></comment>`} />
    </ReportActionItemBasicMessage>
    );

    I fixed it by rendering an empty row for those report actions in this commit. Let me know if it doesn't make sense to you guys.

  8. 1 remaining item

  9. melvin-bot commented on Sep 11, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  10. melvin-bot commented on Sep 11, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  11. melvin-bot commented on Sep 11, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Sep 15, 2025
  13. changed the title [-]Expense - "Moved this expense to" without report number seen after merging track expense.[/-] [+][Due for payment 2025-09-22] Expense - "Moved this expense to" without report number seen after merging track expense.[/+] on Sep 15, 2025
  14. melvin-bot commented on Sep 15, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Sep 15, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.13-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-09-22. 🎊

  16. melvin-bot commented on Sep 15, 2025

    @melvin-bot

    @mollfpr @VictoriaExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions