Skip to content

[Due for payment 2025-10-15] [$250] Workspace - In Select features to copy, Rules section text is partially hidden #71762

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.22-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): galefish@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch app
  2. Create a workspace with rules enabled
  3. Enable max exp amt, age, receipt required amount, prohibited expenses, attendees tracking
  4. Go to workspace lists - 3 dots - Duplicate workspace
  5. Tap next
  6. Note Rules section

Expected Result:

In Select features to copy, Rules section text must not be partially hidden

Actual Result:

In Select features to copy, Rules section text is partially hidden

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6962690_1759398207698.Screenrecorder-2025-10-02-15-06-57-730.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021973787511775367985
  • Upwork Job ID: 1973787511775367985
  • Last Price Increase: 2025-10-02
  • Automatic offers:
    • situchan | Reviewer | 108988126
    • daledah | Contributor | 108988130
Issue OwnerCurrent Issue Owner: @bfitzexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 2, 2025
  2. melvin-bot commented on Oct 2, 2025

    @melvin-bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nyomanjyotisa commented on Oct 2, 2025

    @nyomanjyotisa
    Member

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Workspace - In Select features to copy, Rules section text is partially hidden

    What is the root cause of that problem?

    In WorkspaceDuplicateSelectFeaturesForm , Rules section generates very long alternateText by concatenating all rule names with rules.join(', '). Meanwhile SelectionList uses the default alternateTextNumberOfLines={2} which is insufficient to display long rule lists

    What changes do we think we should make in order to solve the problem?

    We should increase the alternateTextNumberOfLines in the SelectionList

                            alternateTextNumberOfLines={4}

    The number can be adjusted based on requirements

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    None

  4. moved this to Bugs and Follow Up Issues in #expensify-bugson Oct 2, 2025
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 2, 2025
  6. changed the title [-]Workspace - In Select features to copy, Rules section text is partially hidden[/-] [+][$250] Workspace - In Select features to copy, Rules section text is partially hidden[/+] on Oct 2, 2025
  7. melvin-bot commented on Oct 2, 2025

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 2, 2025
  9. melvin-bot commented on Oct 2, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

  10. daledah commented on Oct 2, 2025

    @daledah
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    In Select features to copy, Rules section text is partially hidden

    What is the root cause of that problem?

    Bug Text is partially hidden only appears in navite device

    we don't pass alternateTextNumberOfLines to this selection list

    <SelectionList
    shouldSingleExecuteRowSelect
    sections={[{data: listData}]}
    ListItem={MultiSelectListItem}
    onSelectRow={updateSelectedItems}
    isAlternateTextMultilineSupported
    addBottomSafeAreaPadding
    showConfirmButton
    confirmButtonText={translate('common.continue')}
    onConfirm={onConfirmSelectList}
    />

    we uses the default alternateTextNumberOfLines={2}

    And we have CSS height constraints rather than text truncation

    MultiSelectListItem was using styles.optionRowCompact which has a fixed height of 52px (variables.optionRowHeightCompact)

    wrapperStyle={[wrapperStyle, styles.optionRowCompact]}

    The fixed 52px height was insufficient to accommodate the long alternateText for Rules, causing the text to be visually cut off even though numberOfLines was set to allow multiple lines

    What changes do you think we should make in order to solve the problem?

    we should implement a dynamic wrapper style in MultiSelectListItem to allow the container to expand based on content rather than being constrained by fixed dimensions

    const dynamicWrapperStyle = isAlternateTextMultilineSupported 
        ? [wrapperStyle, styles.optionRow, {minHeight: undefined}] // we can use bigger height or minHeight in this style
        : [wrapperStyle, styles.optionRowCompact];
    

    then pass this as wrapperStyle here

    wrapperStyle={[wrapperStyle, styles.optionRowCompact]}

    if we want to show all alternative text, we can pass alternateTextNumberOfLines as 0. A value of 0 means unlimited lines, allowing the text to be displayed in full.

        alternateTextNumberOfLines={0}
    

    Result:

    Image

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  11. situchan commented on Oct 2, 2025

    @situchan
    Contributor

    @daledah's proposal looks good to me.
    🎀 👀 🎀 C+ reviewed

  12. 8 remaining items

  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 3, 2025
  14. changed the title [-][$250] Workspace - In Select features to copy, Rules section text is partially hidden[/-] [+][Due for payment 2025-10-15] [$250] Workspace - In Select features to copy, Rules section text is partially hidden[/+] on Oct 8, 2025
  15. melvin-bot commented on Oct 8, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Oct 8, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.26-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-10-15. 🎊

    For reference, here are some details about the assignees on this issue:

  17. melvin-bot commented on Oct 8, 2025

    @melvin-bot

    @situchan @bfitzexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  18. situchan commented on Oct 15, 2025

    @situchan
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/61170/files#r2431386737

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Create a workspace with rules enabled
    2. Enable max exp amt, age, receipt required amount, prohibited expenses, attendees tracking
    3. Go to workspace lists - 3 dots - Duplicate workspace
    4. Tap next
    5. Observe Rules section
    6. Verify that in Select features to copy, Rules section text is fully displayed

    Do we agree 👍 or 👎

  19. bfitzexpensify commented on Oct 21, 2025

    @bfitzexpensify
    Contributor

    Payment summary:

    @situchan paid $250 via Upwork (Reviewer) ✅
    @daledah rpaid $250 via Upwork (contributor) ✅

  20. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions