You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-10-15] [$250] Workspace - In Select features to copy, Rules section text is partially hidden #71762
Version Number: 9.2.22-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):galefish@gmail.com Issue reported by: Applause - Internal Team
Please re-state the problem that we are trying to solve in this issue.
Workspace - In Select features to copy, Rules section text is partially hidden
What is the root cause of that problem?
In WorkspaceDuplicateSelectFeaturesForm , Rules section generates very long alternateText by concatenating all rule names with rules.join(', '). Meanwhile SelectionList uses the default alternateTextNumberOfLines={2} which is insufficient to display long rule lists
What changes do we think we should make in order to solve the problem?
We should increase the alternateTextNumberOfLines in the SelectionList
alternateTextNumberOfLines={4}
The number can be adjusted based on requirements
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
changed the title [-]Workspace - In Select features to copy, Rules section text is partially hidden[/-][+][$250] Workspace - In Select features to copy, Rules section text is partially hidden[/+]on Oct 2, 2025
The fixed 52px height was insufficient to accommodate the long alternateText for Rules, causing the text to be visually cut off even though numberOfLines was set to allow multiple lines
What changes do you think we should make in order to solve the problem?
we should implement a dynamic wrapper style in MultiSelectListItem to allow the container to expand based on content rather than being constrained by fixed dimensions
const dynamicWrapperStyle = isAlternateTextMultilineSupported
? [wrapperStyle, styles.optionRow, {minHeight: undefined}] // we can use bigger height or minHeight in this style
: [wrapperStyle, styles.optionRowCompact];
if we want to show all alternative text, we can pass alternateTextNumberOfLines as 0. A value of 0 means unlimited lines, allowing the text to be displayed in full.
alternateTextNumberOfLines={0}
Result:
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-][$250] Workspace - In Select features to copy, Rules section text is partially hidden[/-][+][Due for payment 2025-10-15] [$250] Workspace - In Select features to copy, Rules section text is partially hidden[/+]on Oct 8, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.26-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@situchan@bfitzexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Oct 2, 2025
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nyomanjyotisa commentedon Oct 2, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace - In Select features to copy, Rules section text is partially hidden
What is the root cause of that problem?
In
WorkspaceDuplicateSelectFeaturesForm, Rules section generates very longalternateTextby concatenating all rule names withrules.join(', '). MeanwhileSelectionListuses the defaultalternateTextNumberOfLines={2}which is insufficient to display long rule listsWhat changes do we think we should make in order to solve the problem?
We should increase the
alternateTextNumberOfLinesin theSelectionListThe number can be adjusted based on requirements
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
None
[-]Workspace - In Select features to copy, Rules section text is partially hidden[/-][+][$250] Workspace - In Select features to copy, Rules section text is partially hidden[/+]melvin-bot commentedon Oct 2, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021973787511775367985
melvin-bot commentedon Oct 2, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (
External)daledah commentedon Oct 2, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
In Select features to copy, Rules section text is partially hidden
What is the root cause of that problem?
Bug
Text is partially hiddenonly appears in navite devicewe don't pass
alternateTextNumberOfLinesto this selection listApp/src/pages/workspace/duplicate/WorkspaceDuplicateSelectFeaturesForm.tsx
Lines 331 to 341 in 8f1f87a
we uses the default alternateTextNumberOfLines={2}
And we have CSS height constraints rather than text truncation
MultiSelectListItem was using styles.optionRowCompact which has a fixed height of 52px (variables.optionRowHeightCompact)
App/src/components/SelectionListWithSections/MultiSelectListItem.tsx
Line 56 in 7c95cff
The fixed 52px height was insufficient to accommodate the long alternateText for Rules, causing the text to be visually cut off even though numberOfLines was set to allow multiple lines
What changes do you think we should make in order to solve the problem?
we should implement a dynamic wrapper style in
MultiSelectListItemto allow the container to expand based on content rather than being constrained by fixed dimensionsthen pass this as
wrapperStylehereApp/src/components/SelectionListWithSections/MultiSelectListItem.tsx
Line 56 in 7c95cff
if we want to show all alternative text, we can pass
alternateTextNumberOfLinesas0. A value of 0 means unlimited lines, allowing the text to be displayed in full.Result:
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
situchan commentedon Oct 2, 2025
@daledah's proposal looks good to me.
🎀 👀 🎀 C+ reviewed
8 remaining items
[-][$250] Workspace - In Select features to copy, Rules section text is partially hidden[/-][+][Due for payment 2025-10-15] [$250] Workspace - In Select features to copy, Rules section text is partially hidden[/+]melvin-bot commentedon Oct 8, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 8, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.26-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-10-15. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 8, 2025
@situchan @bfitzexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
situchan commentedon Oct 15, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/61170/files#r2431386737
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
bfitzexpensify commentedon Oct 21, 2025
Payment summary:
@situchan paid $250 via Upwork (Reviewer) ✅
@daledah rpaid $250 via Upwork (contributor) ✅