Repository navigation
fix: In Select features to copy, Rules section text is partially hidden - #71805
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This comment was marked as resolved.
This comment was marked as resolved.
Reviewer Checklist
Screenshots/Videos |
| onFocus={onFocus} | ||
| shouldSyncFocus={shouldSyncFocus} | ||
| wrapperStyle={[wrapperStyle, styles.optionRowCompact]} | ||
| wrapperStyle={dynamicWrapperStyle} |
There was a problem hiding this comment.
Let's make code simple.
| wrapperStyle={dynamicWrapperStyle} | |
| wrapperStyle={[wrapperStyle, styles.optionRowCompact, isAlternateTextMultilineSupported && {height: undefined}]} |
And undo defining dynamicWrapperStyle
|
Screenshots seem good to me 👍 |
| optionRowExpanded: { | ||
| paddingTop: 12, | ||
| paddingBottom: 12, | ||
| minHeight: undefined, |
There was a problem hiding this comment.
If we decide to define new style key, minHeight: undefined is needed?
There was a problem hiding this comment.
That makes sense 😅 I updated.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.2.24-0 🚀
|
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.2.26-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.2.26-7 🚀
|






Explanation of Change
Fixed Issues
$ #71762
PROPOSAL: #71762 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop