You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Reports - Filters become unresponsive after deleting an expense on "Chats" section. #72383
Note that no action is triggered when tapping on the exposed filters.
Navigate to another section and return to "Chats" again.
Tap on any of the exposed filters.
Note that filters become responsive again.
Expected Result:
User should still be able to apply any filter on "Chats" section on "Reports" after deleting an expense.
Actual Result:
Filters on "Chats" section on "Reports" become unresponsive after deleting an expense. User has to navigate to another section and return, to make filters responsive again.
Please re-state the problem that we are trying to solve in this issue.
Filters become unresponsive after deleting an expense in the "Chats" section under "Reports".
What is the root cause of that problem?
In navigateBackOnDeleteTransaction function , when the user is in the Search/Reports tab (SEARCH_FULLSCREEN_NAVIGATOR), the function detects this and dismisses the modal
However, it immediately returns early without completing the navigation flow
This leaves the Search page in an incomplete state where the UI doesn't properly re-render and filters become unresponsive
The user must navigate away and return to restore functionality
What changes do you think we should make in order to solve the problem?
inside the condition where we check for SEARCH_FULLSCREEN_NAVIGATORhere - we should remove the early return that skips the Navigation.goBack(backRoute) call
Ensure both Navigation.dismissModal() and Navigation.goBack() execute to properly clean up the navigation stack:
if(lastFullScreenRoute?.name===NAVIGATORS.SEARCH_FULLSCREEN_NAVIGATOR){// When deleting from Search, we need to dismiss the modal AND navigate back properly// to avoid leaving the search page in an unresponsive stateNavigation.dismissModal();Navigation.isNavigationReady().then(()=>{Navigation.goBack(backRoute);});return;}
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
Please re-state the problem that we are trying to solve in this issue.
Filters on "Chats" section on "Reports" become unresponsive after deleting an expense. User has to navigate to another section and return, to make filters responsive again.
What is the root cause of that problem?
After confirm delete, we navigate back when modal is not yet closed:
was added in #63996 to fix the issue where we can open 2 dropdown buttons at the same time. But it accidentally also affects behaviour if there's other modals. So we can limit the logic to only apply when DropdownButton is already rendered on screen.
Add a previous value for willAlertModalBecomeVisible in DropdownButton:
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
I think this issue can’t be reproduced anymore because #75640
has been merged, which uses the same solution I proposed: willAlertModalBecomeVisible(false); // add this back
Activity
melvin-bot commentedon Oct 11, 2025
Triggered auto assignment to @RachCHopkins (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.abzokhattab commentedon Oct 11, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Filters become unresponsive after deleting an expense in the "Chats" section under "Reports".
What is the root cause of that problem?
navigateBackOnDeleteTransactionfunction , when the user is in the Search/Reports tab (SEARCH_FULLSCREEN_NAVIGATOR), the function detects this and dismisses the modalWhat changes do you think we should make in order to solve the problem?
inside the condition where we check for
SEARCH_FULLSCREEN_NAVIGATORhere - we should remove the early return that skips theNavigation.goBack(backRoute)callNavigation.dismissModal()andNavigation.goBack()execute to properly clean up the navigation stack:What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
NA
daledah commentedon Oct 13, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Filters on "Chats" section on "Reports" become unresponsive after deleting an expense. User has to navigate to another section and return, to make filters responsive again.
What is the root cause of that problem?
After confirm delete, we navigate back when modal is not yet closed:
App/src/components/MoneyRequestHeader.tsx
Line 440 in 89c45c9
App/src/components/MoneyRequestHeader.tsx
Line 458 in 89c45c9
So the confirm modal is forcefully removed from the component stack, lead to the cleanup logic here is not called properly:
App/src/components/Modal/BaseModal.tsx
Lines 321 to 328 in 89c45c9
So
willAlertModalBecomeVisibleremainstrue, which prevents us from opening the dropdown button here:App/src/components/Search/FilterDropdowns/DropdownButton.tsx
Lines 69 to 71 in 89c45c9
What changes do you think we should make in order to solve the problem?
We should navigate only after modal is closed.
Remove this line
App/src/components/MoneyRequestHeader.tsx
Line 458 in 89c45c9
And use
onModalHideprop instead:Additional fix to prevent similar issues appear in the future:
This logic
App/src/components/Search/FilterDropdowns/DropdownButton.tsx
Lines 69 to 71 in 89c45c9
was added in #63996 to fix the issue where we can open 2 dropdown buttons at the same time. But it accidentally also affects behaviour if there's other modals. So we can limit the logic to only apply when
DropdownButtonis already rendered on screen.Add a previous value for
willAlertModalBecomeVisibleinDropdownButton:Then update here
App/src/components/Search/FilterDropdowns/DropdownButton.tsx
Lines 69 to 71 in 89c45c9
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
RachCHopkins commentedon Oct 14, 2025
Took a while to repro but I got there!
melvin-bot commentedon Oct 14, 2025
Current assignee @RachCHopkins is eligible for the Bug assigner, not assigning anyone new.
35 remaining items
melvin-bot commentedon Nov 18, 2025
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
huult commentedon Nov 21, 2025
I think this issue can’t be reproduced anymore because #75640
has been merged, which uses the same solution I proposed:
willAlertModalBecomeVisible(false); // add this backshubham1206agra commentedon Nov 21, 2025
@RachCHopkins Can you please close this issue?
melvin-bot commentedon Nov 25, 2025
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
mvtglobally commentedon Nov 30, 2025
Issue not reproducible during KI retests. (Second week)
shubham1206agra commentedon Dec 1, 2025
@RachCHopkins Please close this issue.
melvin-bot commentedon Dec 2, 2025
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
melvin-bot commentedon Dec 9, 2025
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸