Repository navigation
reports-From and date bottom modal able to be opened together by tapp… - #63996
Conversation
…ing both tabs quickly
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-06-15.at.18.15.41.movAndroid: mWeb ChromeScreen.Recording.2025-06-15.at.18.15.04.moviOS: HybridAppScreen.Recording.2025-06-15.at.17.51.36.mp4iOS: mWeb SafariScreen.Recording.2025-06-15.at.17.54.57.movMacOS: Chrome / SafariScreen.Recording.2025-06-15.at.18.12.24.movScreen.Recording.2025-06-15.at.17.20.22.movMacOS: DesktopScreen.Recording.2025-06-15.at.17.20.46.mov |
|
@suneox All good? |
Actually, it still fails when using a touch tool with a delay < 50ms, but I don't think this would occur in real-world scenarios so overall it still LGTM |
dangrous
left a comment
There was a problem hiding this comment.
One change, feel free to push back if it's dumb haha
|
@dangrous Fixed! |
|
@nkdengineer There is a code conflict in this PR |
|
@dangrous I resolved the conflicts |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/dangrous in version: 9.1.71-0 🚀
|
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.71-11 🚀
|
| const toggleOverlay = () => { | ||
| setIsOverlayVisible((previousValue) => !previousValue); | ||
| setIsOverlayVisible((previousValue) => { | ||
| if (!previousValue && willAlertModalBecomeVisible) { |
There was a problem hiding this comment.
Coming from a DB, willAlertModalBecomeVisible was always true in native apps, thus it caused tapping on other dropdowns ("Status", "Date", "From") to be unable to open
More details here: #64871 (comment)
…ing both tabs quickly
Explanation of Change
Fixed Issues
$ #63409
PROPOSAL: #63409 (comment)
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-06-11.at.23.00.14.mov
Android: mWeb Chrome
Screen.Recording.2025-06-11.at.22.55.48.mov
iOS: Native
Screen.Recording.2025-06-11.at.23.36.55.mov
iOS: mWeb Safari
Screen.Recording.2025-06-11.at.22.59.24.mov
MacOS: Chrome / Safari
Screen.Recording.2025-06-11.at.22.51.56.mov
MacOS: Desktop
Screen.Recording.2025-06-11.at.23.07.43.mov