Skip to content

[Due for payment 2026-08-25] Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.POLICY_TAGS in src/libs/actions/IOU.ts #72721

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. tgolen commented on Oct 24, 2025

    @tgolen
    ContributorAuthor

    This will be worked on eventually

  2. tgolen commented on Nov 3, 2025

    @tgolen
    ContributorAuthor

    This will be worked on eventually

  3. tgolen commented on Nov 13, 2025

    @tgolen
    ContributorAuthor

    This will be worked on eventually

  4. 248 remaining items

  5. MelvinBot commented on Aug 18, 2026

    @MelvinBot
    Contributor

    Here are the PRs linked to this issue (via body references, i.e. their "Fixed Issues"), all part of the ONYXKEYS.COLLECTION.POLICY_TAGS removal in the IOU actions. 34 PRs — 33 merged, 1 open.

    Setup / groundwork

    PR Title
    #72678 refactor: move getPolicyTagsData to IOU and Transaction files

    Onyx.connect() removals (merged)

    PR Function / file
    #86957 detachReceipt — IOU/index.ts
    #87236 getMoneyRequestInformation — IOU/index.ts
    #88302 getUpdateMoneyRequestParams — UpdateMoneyRequest.ts
    #88463 replaceReceipt — IOU/index.ts
    #88515 createSplitsAndOnyxData — IOU/index.ts
    #89084 requestMoney — TrackExpense.ts
    #89617 convertBulkTrackedExpensesToIOU — TrackExpense.ts
    #89759 updateSplitTransactions — SplitTransactionUpdate.ts
    #90353 createDistanceRequest — Split.ts
    #90455 splitBill, splitBillAndOpenReport, createDistanceRequest — IOU/index.ts
    #94297 createExpenseByType — Duplicate.ts
    #94300 handleMoneyRequestStepDistanceNavigation
    #94605 getOnyxTargetTransactionData
    #94614 updateMoneyRequestDate
    #94616 updateMoneyRequestMerchant
    #94618 updateMoneyRequestTag
    #94621 updateMoneyRequestCategory
    #94624 updateMoneyRequestDescription
    #94625 updateMoneyRequestAmountAndCurrency
    #95716 createTransaction
    #95738 duplicateReport
    #95793 updateMoneyRequestBillable
    #95794 updateMoneyRequestReimbursable
    #95795 updateMoneyRequestAttendees
    #95797 updateMoneyRequestTaxAmount
    #95798 updateMoneyRequestTaxRate
    #95800 updateMoneyRequestDistance
    #95801 updateMoneyRequestDistanceRate
    #95803 updateSplitTransactions
    #97077 splitBill, splitBillAndOpenReport, createDistanceRequest — IOU/index.ts
    #98035 getPerDiemExpenseInformation — PerDiem.ts
    #98309 Resolve PER_DIEM policyTags in createExpenseByType
    #98400 getPolicyTags cleanup

    Open

    PR Title
    #98012 perf: defer the split-save API.write behind the destination layout
    Excluded cross-references

    These showed up in the issue timeline but only reference it in a comment (not their body / Fixed Issues) and are unrelated to the POLICY_TAGS work, so I left them out: #80237 (NVP_RECENT_WAYPOINTS), #92357, #95215, #98160.

  6. parasharrajat commented on Aug 18, 2026

    @parasharrajat
    Member

    @tgolen There are a total of 33 PRs for this issue. One open PR is not related. Can you please review the compensation for this?

  7. tgolen commented on Aug 18, 2026

    @tgolen
    ContributorAuthor

    Looks like there is a pretty big mix of small and regular PRs. This is how I split it out:

    Total: $6,250 (16 × $250 = $4,000, 18 × $125 = $2,250)

    If you'd like to know exactly which ones I marked as $125, let me know! Also, if there were any you felt were worth more than $250, I can take a look. There were two that were on the bigger side: #90455 (712 lines) and #88463 (539 lines)

  8. parasharrajat commented on Aug 18, 2026

    @parasharrajat
    Member

    This sounds good to me. Thanks.

  9. melvin-bot commented on Aug 21, 2026

    @melvin-bot

    @parasharrajat Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  10. changed the title [-]Remove `Onyx.connect()` for the key: `ONYXKEYS.COLLECTION.POLICY_TAGS` in `src/libs/actions/IOU.ts`[/-] [+][Due for payment 2026-08-25] Remove `Onyx.connect()` for the key: `ONYXKEYS.COLLECTION.POLICY_TAGS` in `src/libs/actions/IOU.ts`[/+] on Aug 25, 2026
  11. removed
    Skip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.
    on Aug 25, 2026
  12. amyevans commented on Aug 25, 2026

    @amyevans
    Contributor

    @mallenexpensify could you help with payments here please?

  13. mallenexpensify commented on Aug 26, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @parasharrajat due $6,250 via NewDot

  14. garrettmknight commented on Sep 18, 2026

    @garrettmknight
    Contributor

    $6,250 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions