You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-11-19] [$250] Tag - The search bar is displayed when the number of tag < 8 #73079
Please re-state the problem that we are trying to solve in this issue.
The search bar is displayed when the number of tag < 8
What is the root cause of that problem?
we are using enabledTags variable (filtered for UI rendering purposes) to decide business logic (show search bar), instead of using original data policyTagList.tags
Note: we should do the same with other picker that has the same problem
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Please re-state the problem that we are trying to solve in this issue.
When a workspace has fewer than eight enabled tags, the tag picker should hide the search bar but it doesn't.
What is the root cause of that problem?
The component decides if the search input should appear by counting every tag returned from Onyx, even the entries that are disabled. After you turn off tags, the disabled items are still counted, so the app believes there are eight or more tags and keeps the search field visible.
What changes do you think we should make in order to solve the problem?
Update the tag counter to look only at enabled tags and move the calculation into a memoized helper so it stays in sync with the tag list. That way, once the active tags drop under the limit, the search input hides.
changed the title [-]Tag - The search bar is displayed when the number of tag < 8[/-][+][$250] Tag - The search bar is displayed when the number of tag < 8[/+]on Oct 27, 2025
changed the title [-][$250] Tag - The search bar is displayed when the number of tag < 8[/-][+][Due for payment 2025-11-19] [$250] Tag - The search bar is displayed when the number of tag < 8[/+]on Nov 12, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.54-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@jayeshmangwani@brianlee-expensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not that CRITICAL
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Go to Workspaces.
Create a new workspace.
Turn on Tags.
Import a list of more than 8 tags.
Turn off all tags except 4.
Navigate to the Workspace Expenses.
Start creating a manual expense.
Enter the amount and click Next.
Click on the Tag field.
Verify that the search bar disappears when the number of enabled tags is fewer than 8.
Activity
melvin-bot commentedon Oct 21, 2025
Triggered auto assignment to @brianlee-expensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Oct 21, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The search bar is displayed when the number of tag < 8
What is the root cause of that problem?
we are using
enabledTagsvariable (filtered for UI rendering purposes) to decide business logic (show search bar), instead of using original datapolicyTagList.tagsApp/src/components/TagPicker.tsx
Lines 108 to 110 in fd0eabf
What changes do you think we should make in order to solve the problem?
We should update this logic to use
getCountOfEnabledTagsOfListfunction like the way we did in category picker hereApp/src/components/CategoryPicker.tsx
Lines 67 to 69 in fd0eabf
Note: we should do the same with other picker that has the same problem
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
ShridharGoel commentedon Oct 21, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a workspace has fewer than eight enabled tags, the tag picker should hide the search bar but it doesn't.
What is the root cause of that problem?
The component decides if the search input should appear by counting every tag returned from Onyx, even the entries that are disabled. After you turn off tags, the disabled items are still counted, so the app believes there are eight or more tags and keeps the search field visible.
App/src/components/TagPicker.tsx
Lines 107 to 110 in fd0eabf
What changes do you think we should make in order to solve the problem?
Update the tag counter to look only at enabled tags and move the calculation into a memoized helper so it stays in sync with the tag list. That way, once the active tags drop under the limit, the search input hides.
Change in
src/components/TagPicker.tsx:brianlee-expensify commentedon Oct 27, 2025
verified reproducible on new.expensify.com
2025-10-26_20-39-17.1.mp4
[-]Tag - The search bar is displayed when the number of tag < 8[/-][+][$250] Tag - The search bar is displayed when the number of tag < 8[/+]melvin-bot commentedon Oct 27, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021982653574093305010
melvin-bot commentedon Oct 27, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (
External)brianlee-expensify commentedon Oct 27, 2025
may be related to this previous issue: #69348
34 remaining items
[-][$250] Tag - The search bar is displayed when the number of tag < 8[/-][+][Due for payment 2025-11-19] [$250] Tag - The search bar is displayed when the number of tag < 8[/+]melvin-bot commentedon Nov 12, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 12, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.54-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-11-19. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 12, 2025
@jayeshmangwani @brianlee-expensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
brianlee-expensify commentedon Nov 19, 2025
@jayeshmangwani can you complete the bugzero checklist and confirm whether a regression test is required for this?
ShridharGoel commentedon Nov 19, 2025
@brianlee-expensify Can we please have the payment summary here since it is due for payment?
jayeshmangwani commentedon Nov 20, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Use available tags count based on selection in TagPicker component #69829
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not that CRITICAL
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Do we agree 👍 or 👎
jayeshmangwani commentedon Nov 20, 2025
@brianlee-expensify , yes, I think we can add a new regression test case for this.
brianlee-expensify commentedon Nov 22, 2025
Payment Summary
Contributor: @ShridharGoel due $250 via NewDot
Contributor+: @jayeshmangwani due $250 via NewDot
trjExpensify commentedon Dec 3, 2025
approved $250 for @jayeshmangwani