Skip to content

[Due for payment 2025-12-11] [$250] Expense - Not here page opens after deleting report #74731

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.48-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: #73691
Email or phone of affected tester (no customers): niushdsiushbiusdh@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Create an empty report
  4. Open the empty report
  5. Go to Reports > Reports
  6. Open the empty report
  7. Go back to Inbox
  8. On the empty report, click More > Delete
  9. Delete the report

Expected Result:

Not here page will not open after deleting the report

Actual Result:

Not here page opens after deleting the report

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6999637_1762791786364.6.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021990495316363245539
  • Upwork Job ID: 1990495316363245539
  • Last Price Increase: 2025-11-17
  • Automatic offers:
    • dominictb | Reviewer | 109588576
    • daledah | Contributor | 109588579
Issue OwnerCurrent Issue Owner: @garrettmknight

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 10, 2025
  2. melvin-bot commented on Nov 10, 2025

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. daledah commented on Nov 10, 2025

    @daledah
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Not here page opens after deleting the report

    What is the root cause of that problem?

    We are not handling backToRoute for deleteReport case like we did with deleteExpense here

    Navigation.goBack(route.params?.backTo);
    // eslint-disable-next-line @typescript-eslint/no-deprecated
    InteractionManager.runAfterInteractions(() => {
    deleteAppReport(moneyRequestReport?.reportID);
    });

    const backToRoute = route.params?.backTo ?? (chatReport?.reportID ? ROUTES.REPORT_WITH_ID.getRoute(chatReport.reportID) : undefined);
    Navigation.goBack(backToRoute);

    => Navigation.goBack(route.params?.backTo) is called => the navigation just pops the current screen from the stack because route.params?.backTo is undefined => the user navigated to the Reports tab => page not found is displayed because (report is deleted)

    What changes do you think we should make in order to solve the problem?

    We should handle backToRoute for deleteReport like we did with deleteExpense in MoneyReportHeader

        const backToRoute = route.params?.backTo ?? (chatReport?.reportID ? ROUTES.REPORT_WITH_ID.getRoute(chatReport.reportID) : undefined);
        Navigation.goBack(backToRoute);
    

    Navigation.goBack(route.params?.backTo);

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 17, 2025
  5. changed the title [-]Expense - Not here page opens after deleting report[/-] [+][$250] Expense - Not here page opens after deleting report[/+] on Nov 17, 2025
  6. melvin-bot commented on Nov 17, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 17, 2025
  8. melvin-bot commented on Nov 17, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @dominictb (External)

  9. daledah commented on Nov 24, 2025

    @daledah
    Contributor

    @dominictb what do you think about my proposal?

  10. 15 remaining items

  11. changed the title [-][$250] Expense - Not here page opens after deleting report[/-] [+][Due for payment 2025-12-11] [$250] Expense - Not here page opens after deleting report[/+] on Dec 4, 2025
  12. melvin-bot commented on Dec 4, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Dec 4, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.71-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-12-11. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Dec 4, 2025

    @melvin-bot

    @dominictb @garrettmknight The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. melvin-bot commented on Dec 15, 2025

    @melvin-bot

    @garrettmknight Eep! 4 days overdue now. Issues have feelings too...

  16. dominictb commented on Dec 16, 2025

    @dominictb
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/71169/changes#r2623703208

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Go to workspace chat
    2. Create an empty report
    3. Open the empty report
    4. Go to Reports > Reports
    5. Open the empty report
    6. Go back to Inbox
    7. On the empty report, click More > Delete
    8. Delete the report
    9. Verify that: Not here page will not open after deleting the report
    10. Go back to Reports and verify that the "Not here page" isn't shown

    Do we agree 👍 or 👎

  17. melvin-bot commented on Dec 17, 2025

    @melvin-bot

    @garrettmknight 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  18. garrettmknight commented on Dec 19, 2025

    @garrettmknight
    Contributor

    Payment Summary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions