Repository navigation
fix: Not here page opens after deleting report - #75960
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-11-28.at.16.22.32-compressed.movAndroid: mWeb ChromeScreen.Recording.2025-11-28.at.16.23.58.moviOS: HybridAppScreen.Recording.2025-11-26.at.17.35.29-compressed.moviOS: mWeb SafariScreen.Recording.2025-11-26.at.17.37.22.movMacOS: Chrome / SafariScreen.Recording.2025-11-28.at.16.25.13.mov |
@daledah please complete this part of the checklist. I see and error in the iOS: Native, Android: Native, and the Android: mWeb Chrome videos. Crossing off the items without actually doing the steps is considered breaking rule 2, so please be mindful of this moving forward |
|
@dominictb any reason you didn't upload videos for android? |
|
Can we add a step 10. to the test steps and test again to make sure it's working, I don't think any of the videos are showing this:
|
heyjennahay
left a comment
There was a problem hiding this comment.
No concern with product change
This error isn't related to this PR. I'm also reproducing on main ios.mov
i added step 10 and added the new video for Web |
|
I updated the recordings in checklist |
@daledah Did you report it or open an issue for it to be fixed? |
|
🚀 Deployed to staging by https://github.com/cead22 in version: 9.2.71-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.71-5 🚀
|
Explanation of Change
Expense - Not here page opens after deleting report
Fixed Issues
$ #74731
PROPOSAL: #74731 (comment)
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios-mweb.mov
MacOS: Chrome / Safari
Screen.Recording.2025-11-28.at.15.51.29.mov