You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-01-15] [$250] Workspace - Delete banner still display after clicking on the Got it button in Overview #78514
What alternative solutions did you explore? (Optional)
Or we can setIsDeleteModalOpen(false); in confirmDelete function even if it's online
setIsDeleteModalOpen(false);
deleteWorkspace({...
...
if (isOffline) {
goBackFromInvalidPolicy();
}
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Workspace - Delete banner still display after clicking on the Got it button in Overview[/-][+][$250] Workspace - Delete banner still display after clicking on the Got it button in Overview[/+]on Dec 29, 2025
⚠️@yatin-italy Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.
I like @ryntgh 's approach #78514 (comment) of setting setIsDeleteModalOpen to false in the effect when we enable setIsDeleteWorkspaceErrorModalOpen. Let’s go with that.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.95-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@jayeshmangwani@mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not that CRITICAL to add a new checklist or the need discussion
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Dec 29, 2025
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.daledah commentedon Dec 29, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The Delete banner at step 5 still displays
What is the root cause of that problem?
We don't
setIsDeleteModalOpenwhen the user confirm delete if it's onlineApp/src/pages/workspace/WorkspaceOverviewPage.tsx
Lines 234 to 237 in a1e04dd
then on
hideDeleteWorkspaceErrorModalwe also don'tsetIsDeleteModalOpenasfalseWhat changes do you think we should make in order to solve the problem?
We should also
setIsDeleteModalOpenasfalseinhideDeleteWorkspaceErrorModalfunctionWhat alternative solutions did you explore? (Optional)
Or we can
setIsDeleteModalOpen(false);inconfirmDeletefunction even if it's onlineReminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
ryntgh commentedon Dec 29, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace - Delete banner still display after clicking on the Got it button in Overview
What is the root cause of that problem?
When the delete operation fails, the effect opens the error modal but doesn't close the delete modal
App/src/pages/workspace/WorkspaceOverviewPage.tsx
Lines 275 to 285 in 9e3ecbb
Meanwhile, in
WorkspacesListPage, the same effect properly closes the delete modal (setIsDeleteModalOpen(false)) before showing the error modalApp/src/pages/workspace/WorkspacesListPage.tsx
Lines 320 to 329 in 9e3ecbb
What changes do you think we should make in order to solve the problem?
We should close the delete modal before opening the error modal in
WorkspaceOverviewPageApp/src/pages/workspace/WorkspaceOverviewPage.tsx
Lines 275 to 285 in 9e3ecbb
What alternative solutions did you explore? (Optional)
NA
[-]Workspace - Delete banner still display after clicking on the Got it button in Overview[/-][+][$250] Workspace - Delete banner still display after clicking on the Got it button in Overview[/+]melvin-bot commentedon Dec 29, 2025
Job added to Upwork: https://www.upwork.com/jobs/~022005772487710361501
melvin-bot commentedon Dec 29, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (
External)mallenexpensify commentedon Dec 29, 2025
Spent too long trying to repro, marked at
Externalgithub-actions commentedon Dec 30, 2025
jayeshmangwani commentedon Dec 31, 2025
Thanks to both of you for the proposals above.
I like @ryntgh 's approach #78514 (comment) of setting
setIsDeleteModalOpentofalsein the effect when we enablesetIsDeleteWorkspaceErrorModalOpen. Let’s go with that.🎀 👀 🎀 C+ reviewed
16 remaining items
melvin-bot commentedon Jan 8, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.95-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-01-15. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 8, 2026
@jayeshmangwani @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
jayeshmangwani commentedon Jan 15, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: fix: Reports - Filters become unresponsive after deleting the workspace. #74856 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not that CRITICAL to add a new checklist or the need discussion
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/589253
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-7921-a7bb-a9dc-477a03f681f4mallenexpensify commentedon Jan 16, 2026
Payment Summary
Contributor: @ryntgh paid $250 via Upwork
Contributor+: @jayeshmangwani due $250 via NewDot
@ryntgh can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~022005772487710361501
^ Test case created
ryntgh commentedon Jan 16, 2026
@mallenexpensify Thanks! I've accepted the offer
melvin-bot commentedon Jan 20, 2026
@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
mallenexpensify commentedon Jan 21, 2026
Paid @ryntgh , thx. paid, summary updated above.
trjExpensify commentedon Jan 21, 2026
approved $250 for @jayeshmangwani.