Repository navigation
fix: Reports - Filters become unresponsive after deleting the workspace. - #74856
Conversation
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
What was actually broken
Root cause in simple words
What changed in this branch
Why this fixes both issues
|
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
The analysis sounds good to me. But we need to fix this:
|
|
I need some time to find a solution. I’ll try to resolve it over the weekend and provide updates on Monday. |
|
I was unable to find a solution for the bug above, will share my findings today. |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
I was finally able to get a solution for the "not found" page bug and pushed the changes. I'll share the recordings for confirmation today. |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@dominictb everything is fixed now and this is ready for review. Thanks for waiting. |
heyjennahay
left a comment
There was a problem hiding this comment.
No concern with product change
|
@dominictb bump |
|
@Krishna2323 we have a couple of tests failing. @dominictb let's please review this PR when you're online |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-12-02.at.17.31.02.movAndroid: mWeb ChromeScreen.Recording.2025-12-02.at.17.33.17.moviOS: HybridAppScreen.Recording.2025-12-02.at.17.23.32.moviOS: mWeb SafariScreen.Recording.2025-12-02.at.17.25.01.movMacOS: Chrome / SafariScreen.Recording.2025-12-02.at.17.19.46.mov |
|
@Krishna2323 You might have missed these comments #74856 (comment) |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@dominictb handles all. Thanks! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.2.72-0 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.2.72-2 🚀
|
| return; | ||
| } | ||
| setIsDeleteModalOpen(false); | ||
|
|
There was a problem hiding this comment.
Coming from this issue #78514, removing setIsDeleteModalOpen from here caused that issue.
Explanation of Change
Fixed Issues
$ #74616
PROPOSAL: #74616 (comment)
Tests
Steps to Reproduce:
Offline tests
QA Steps
Same as tests
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_native.mp4
Android: mWeb Chrome
android_chrome.mp4
iOS: Native
ios_native.mp4
iOS: mWeb Safari
ios_safari.mp4
MacOS: Chrome / Safari
web_chrome.mp4