You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Subscription - The search bar display nothing after clicking "view payment history" #78539
Version Number: 9.2.88-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#78043 Email or phone of affected tester (no customers):poipio514+employee1@gmail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Windows 11 / Chrome App Component: User Settings
Action Performed:
Precondition:
Log in with an account that has an active Expensify subscription (I run the snippet in the steps execution)
Navigate to account
steps:
Open the Subscription page
run the following in the JS console: Onyx.merge('account', {hasPurchases: true});
Click View payment history
Expected Result:
the search bar should contains the query: type:expense merchant:Expensify
Actual Result:
The search bar display nothing after clicking "view payment history"
@jponikarchuk This is expected behaviour now since we apply the filter dynamically and not show the type:expense merchant:Expensify in search bar anymore, I forgot to update the test section on linked PR. We are good to close this one.
Please re-state the problem that we are trying to solve in this issue.
The search bar display nothing after clicking "view payment history"
What is the root cause of that problem?
The viewPurchases function navigated to the search page with a query but didn't set the search context flag that controls whether the search bar displays the query
What changes do you think we should make in order to solve the problem?
Added setSearchContext(true) in viewPurchases before navigation so the search bar displays the query (type:expense merchant:Expensify).
const viewPurchases = useCallback(() => {
const query = buildQueryStringFromFilterFormValues({
type: CONST.SEARCH.DATA_TYPES.EXPENSE,
status: CONST.SEARCH.STATUS.EXPENSE.ALL,
merchant: CONST.EXPENSIFY_MERCHANT,
});
// Set search context to show the query in the search bar
setSearchContext(true);
// rawQuery is needed to populate rawFilterList, which prevents useSuggestedSearchDefaultNavigation from auto-redirecting to actionable searches.
Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query, rawQuery: query}));
}, []);
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Agree with @mountiny, this was actually the existing behavior before #78043, so we keep it as-is to maintains consistency. If needed, I can raise a PR shortly to handle this.
cc: @eVoloshchak what you think.
@trjExpensify@JmillsExpensify do you have any feedback on this whether it's expected and therefore we should keep it this way, or it's an opportunity to optimise?
The PR for #77537 was fundamentally a bug with the search result changing to something different on navigating.
More broadly, the update to not having query language in the search bar by default anymore did this I assume. I don't think we need to do anything here though. I can see the screenshot has Filters (1) and so within the filters sidebar, the Merchant field will be populated with "Expensify".
Activity
samranahm commentedon Dec 29, 2025
@jponikarchuk This is expected behaviour now since we apply the filter dynamically and not show the
type:expense merchant:Expensifyin search bar anymore, I forgot to update the test section on linked PR. We are good to close this one.daledah commentedon Dec 29, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The search bar display nothing after clicking "view payment history"
What is the root cause of that problem?
The
viewPurchasesfunction navigated to the search page with a query but didn't set the search context flag that controls whether the search bar displays the queryApp/src/pages/settings/Subscription/CardSection/CardSection.tsx
Lines 81 to 90 in 599c8ce
What changes do you think we should make in order to solve the problem?
Added
setSearchContext(true)inviewPurchasesbefore navigation so the search bar displays the query(type:expense merchant:Expensify).App/src/pages/settings/Subscription/CardSection/CardSection.tsx
Lines 81 to 90 in 599c8ce
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
mountiny commentedon Dec 30, 2025
@samranahm @nkuoch @trjExpensify Isnt it a bit confusing if we do not show anything in the search bar? How will the user know what its showing to them
melvin-bot commentedon Dec 30, 2025
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.samranahm commentedon Dec 30, 2025
Agree with @mountiny, this was actually the existing behavior before #78043, so we keep it as-is to maintains consistency. If needed, I can raise a PR shortly to handle this.
cc: @eVoloshchak what you think.
melvin-bot commentedon Jan 3, 2026
@laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
laurenreidexpensify commentedon Jan 5, 2026
@trjExpensify @JmillsExpensify do you have any feedback on this whether it's expected and therefore we should keep it this way, or it's an opportunity to optimise?
trjExpensify commentedon Jan 6, 2026
The PR for #77537 was fundamentally a bug with the search result changing to something different on navigating.
More broadly, the update to not having query language in the search bar by default anymore did this I assume. I don't think we need to do anything here though. I can see the screenshot has
Filters (1)and so within the filters sidebar, the Merchant field will be populated with "Expensify".Happy to defer to @JmillsExpensify though!
JmillsExpensify commentedon Jan 6, 2026
Agree with Tom!
trjExpensify commentedon Jan 6, 2026
Let's close it then!