You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense - Converted amount is the same as unconverted amount for unedited split #80170
Version Number: 9.3.6-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#79547 Email or phone of affected tester (no customers):oijiojnojinjijijio@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.1 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Create an expense in foreign currency.
Open the expense report.
Click More > Split > Save.
Open any split.
Go offline.
Click Amount.
Edit the split and save it.
Open the unedited split
Expected Result:
Converted amount should remain unchanged for unedited split.
Actual Result:
Converted amount is the same as unconverted amount for unedited split.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #79547 - "fix: Report - Total amount shown as '0,00' when splitting expense offline after currency change" by @TaduJR (High confidence) Related Issues: Fixed #78814 but introduced this new regression
Recommendation: REVERT
PR #79547 introduced logic to calculate proportional convertedAmount for split transactions, but it has a critical bug: when editing ANY split transaction, the convertedAmount gets recalculated for ALL splits (including unedited ones) based on the original transaction. This causes unedited splits to show incorrect converted amounts.
Labels: This is a Frontend bug. The fix needs to happen in the App repository. Keeping DeployBlockerCash label. Removing DeployBlocker label as this does not block the backend/Web deploy.
📋 Detailed Analysis
Evidence
The reproduction steps clearly show:
Split an expense in foreign currency offline
Edit ONE split
Open an UNEDITED split
The converted amount is incorrectly changed to match the unconverted amount
This matches exactly what PR #79547 changed. The PR added logic to calculate convertedAmount proportionally when splitting expenses.
Verification
The bug is in /home/runner/work/App/App/src/libs/actions/IOU/index.ts at lines 3235-3247, which was added by PR #79547:
if(isSplitExpense&&existingTransaction){const{convertedAmount: originalConvertedAmount, ...existingTransactionWithoutConvertedAmount}=existingTransaction;optimisticTransaction=fastMerge(existingTransactionWithoutConvertedAmount,optimisticTransaction,false);// Calculate proportional convertedAmount for the split based on the original conversion rateconstoriginalAmount=Number(existingTransaction.modifiedAmount)||existingTransaction.amount;constsplitAmount=Number(optimisticTransaction.modifiedAmount)||optimisticTransaction.amount;if(originalConvertedAmount&&originalAmount&&splitAmount){optimisticTransaction.convertedAmount=Math.round((originalConvertedAmount*splitAmount)/originalAmount);}}
Root Cause
When updateSplitTransactions is called (line 13858 in the same file), it passes existingTransaction: originalTransaction to getMoneyRequestInformation. This causes the above code to execute for EVERY split transaction being processed, not just new ones.
The problem is that:
existingTransaction is the parent/original transaction that was split
The code recalculates convertedAmount for ALL splits based on this original transaction
When editing one split offline, this recalculation incorrectly runs for unedited splits too
Unedited splits should maintain their existing convertedAmount, not have it recalculated
The fix should distinguish between:
Creating NEW split transactions (where convertedAmount calculation is correct)
Updating EXISTING split transactions (where convertedAmount should only be recalculated if the amount changed)
This issue doesn’t seem to be caused by the #79547 change set but isn’t reproducible on the latest prod so waiting for @TaduJR to revert locally and confirm.
When Transaction_Split is called, the backend should either:
Not return the original transaction in onyxData, OR
Return the original transaction with its correct convertedAmount preserved
What is the actual behavior of the backend?
The backend returns the original transaction in onyxData with convertedAmount incorrectly set equal to amount, overwriting the client's correct foreign currency conversion value.
Activity
melvin-bot commentedon Jan 22, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #79547
melvin-bot commentedon Jan 22, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Jan 22, 2026
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jan 22, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Jan 22, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #79547 - "fix: Report - Total amount shown as '0,00' when splitting expense offline after currency change" by @TaduJR (High confidence)
Related Issues: Fixed #78814 but introduced this new regression
Recommendation: REVERT
PR #79547 introduced logic to calculate proportional convertedAmount for split transactions, but it has a critical bug: when editing ANY split transaction, the convertedAmount gets recalculated for ALL splits (including unedited ones) based on the original transaction. This causes unedited splits to show incorrect converted amounts.
Labels: This is a Frontend bug. The fix needs to happen in the App repository. Keeping
DeployBlockerCashlabel. RemovingDeployBlockerlabel as this does not block the backend/Web deploy.📋 Detailed Analysis
Evidence
The reproduction steps clearly show:
This matches exactly what PR #79547 changed. The PR added logic to calculate
convertedAmountproportionally when splitting expenses.Verification
The bug is in
/home/runner/work/App/App/src/libs/actions/IOU/index.tsat lines 3235-3247, which was added by PR #79547:Root Cause
When
updateSplitTransactionsis called (line 13858 in the same file), it passesexistingTransaction: originalTransactiontogetMoneyRequestInformation. This causes the above code to execute for EVERY split transaction being processed, not just new ones.The problem is that:
existingTransactionis the parent/original transaction that was splitconvertedAmountfor ALL splits based on this original transactionconvertedAmount, not have it recalculatedThe fix should distinguish between:
lakchote commentedon Jan 22, 2026
cc @TaduJR @suneox coming from #79547
suneox commentedon Jan 22, 2026
This issue doesn’t seem to be caused by the #79547 change set but isn’t reproducible on the latest prod so waiting for @TaduJR to revert locally and confirm.
CleanShot.2026-01-22.at.13.38.24.mp4
TaduJR commentedon Jan 22, 2026
BE issue not regression from #79547
What is the expected behavior of the backend?
When
Transaction_Splitis called, the backend should either:onyxData, ORconvertedAmountpreservedWhat is the actual behavior of the backend?
The backend returns the original transaction in
onyxDatawithconvertedAmountincorrectly set equal toamount, overwriting the client's correct foreign currency conversion value.What data are you passing to the backend?
Endpoint:
Transaction_SplitOriginal transaction state before API call:
{ "transactionID": "3807893813045614263", "amount": -1000, "currency": "USD", "convertedAmount": -3673 }What data is the backend returning?
The backend returns the original transaction with incorrect
convertedAmount:{ "key": "transactions_3807893813045614263", "onyxMethod": "merge", "value": { "amount": -1000, "convertedAmount": -1000, 🚨💥 "currency": "USD", "transactionID": "3807893813045614263" } }What data do you think the backend should be returning?
Either:
onyxDataresponse, ORconvertedAmount:{ "key": "transactions_3807893813045614263", "onyxMethod": "merge", "value": { "amount": -1000, "convertedAmount": -3673, "currency": "USD", "transactionID": "3807893813045614263" } }lakchote commentedon Jan 22, 2026
Demoting as it's a BE issue (see post above)
lakchote commentedon Jan 26, 2026
@TaduJR you can resume working on your PR
melvin-bot commentedon Feb 16, 2026
This issue has not been updated in over 14 days. @lakchote, @laurenreidexpensify eroding to Weekly issue.
lakchote commentedon Feb 16, 2026
Should have been fixed by https://github.com/Expensify/Auth/pull/19435 and #74189.
Closing the issue.