You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Rules - Rules are not applied to all merchants after saving merchant with an asterisk (*) #81107
Version Number: 9.3.11-17 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#80915 Email or phone of affected tester (no customers):ibellicotest+2250@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome App Component: Money Requests
Action Performed:
Prerequisite: Account has at least one workspace.
Open the Expensify app.
Navigate to "Account" > "Expense Rules"
Tap on "New Rule"
On "If expense contains" tap on "Merchant"
Note that a "Type (*) to create a rule that applies to all merchants" message is visible below input.
Type an asterisk (*) and save.
On "Then apply these updates", add any category, description and any report name.
Save the created rule.
Navigate to workspace chat.
Create a manual expense with any merchant.
Note that rules are not applied.
Delete the just created expense.
Create a new manual expense with an asterisk (*) as merchant.
Note that rules are not applied to the expense.
Expected Result:
When user creates a rule and saves the merchant as an asterisk (*) in "If expense contains", the created rule should be applied to expenses created with any merchant.
Actual Result:
Rules are not applied to any merchant after creating a new rule and saving merchant as an asterisk (*) in "If expense contains".
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
This appears to be a backend bug where the rule matching logic does not properly handle wildcard () merchant matching. The App correctly allows users to create rules with () as the merchant (with the hint "Type (*) to create a rule that applies to all merchants"), but when expenses are created, the backend is not applying these wildcard rules.
Why this is a backend bug:
No App PR introduced broken logic - this is a new feature working as designed on the frontend
The App successfully saves rules with (*) merchant
The bug occurs during expense creation when the backend attempts to match and apply rules
The fix requires backend changes to implement proper wildcard merchant matching
Labels: DeployBlockerCash label should be REMOVED since this requires a backend fix, not an App revert.
Detailed Analysis
Evidence
The issue clearly states:
Users can create a rule with (*) as merchant
The UI shows "Type (*) to create a rule that applies to all merchants"
Rules are saved successfully
When creating expenses (with any merchant OR with (*) as merchant), rules are NOT applied
Feature Context
Personal expense rules is a NEW feature (version 9.3.11-17, N/A in production):
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #79659 - "Expense rules phase 2" by @situchan (High confidence) Fix PR: #81177 - "Update "use *" to "use ."" by @JS00001 (Already merged to main) Related Issues: Part of #75903
Recommendation: DEMOTE
This issue has already been fixed in PR #81177, which corrected the merchant hint text from "*" to "." to match OldDot/Classic behavior. The fix is merged to main but not yet in the current staging deploy.
The fix will automatically be included in the next staging deploy
This is a new feature (N/A in production per the issue description)
The feature works correctly with the proper wildcard character "."
The original PR author marked this as NAB (Not A Blocker) after the fix was merged
Labels: REMOVE DeployBlockerCash - this does not need to block the current App deploy since the fix is already in main and will ship in the next cycle.
Detailed Analysis
Evidence
Timeline of events:
PR Expense rules phase 2 #79659 (Jan 22): Introduced expense rules phase 2 with create/edit/delete functionality, including merchant hint text saying "Type * to create a rule that applies to all merchants"
Root cause:
The frontend code in PR #79659 incorrectly told users to use "*" as the wildcard character for merchant matching. However, the backend (inherited from OldDot/Classic) expects "." as the wildcard character. This was a frontend documentation/UX bug, not a backend logic bug.
This was a frontend UX bug where the hint text did not match the backend implementation:
Frontend (incorrect): Told users to type "*" for wildcard matching
Backend (correct): Expected "." for wildcard matching (as used in OldDot/Classic)
Fix: Updated frontend hint text to match backend expectation
The backend rule matching logic was working correctly all along - it just required the correct wildcard character that OldDot has always used.
Current Status
The issue is already resolved in the codebase. The fix (PR #81177) is merged to main and will be included in the next staging deploy. No further action is needed except to remove the deploy blocker label since this does not warrant blocking the current deploy.
Classification: Frontend bug Causing PR: #79659 - Expense rules phase 2 by @situchan (High confidence) Fix PR: #81177 - Update wildcard from * to . by @JS00001 (Already merged to main) Related Issues: Part of #75903
Recommendation: DEMOTE
This issue has already been fixed in PR #81177, which corrected the merchant hint text from * to . to match OldDot/Classic behavior. The fix is merged to main but not yet in the current staging deploy.
The fix will automatically be included in the next staging deploy
This is a new feature (N/A in production per the issue description)
The feature works correctly with the proper wildcard character .
The original PR author marked this as NAB (Not A Blocker) after the fix was merged
Labels: REMOVE DeployBlockerCash - this does not need to block the current App deploy since the fix is already in main and will ship in the next cycle.
Detailed Analysis
Evidence
Timeline of events:
PR Expense rules phase 2 #79659 (Jan 22): Introduced expense rules phase 2 with merchant hint text saying Type * to create a rule that applies to all merchants
Root cause:
The frontend code in PR #79659 incorrectly told users to use * as the wildcard character for merchant matching. However, the backend (inherited from OldDot/Classic) expects . as the wildcard character. This was a frontend documentation/UX bug, not a backend logic bug.
This was a frontend UX bug where the hint text did not match the backend implementation:
Frontend (incorrect): Told users to type * for wildcard matching
Backend (correct): Expected . for wildcard matching (as used in OldDot/Classic)
Fix: Updated frontend hint text to match backend expectation
The backend rule matching logic was working correctly all along - it just required the correct wildcard character that OldDot has always used.
Current Status
The issue is already resolved in the codebase. The fix (PR #81177) is merged to main and will be included in the next staging deploy. No further action is needed except to remove the deploy blocker label since this does not warrant blocking the current deploy.
Per my investigation, this issue has been fixed in PR #81177 (merged to main on Feb 2). However, I am NOT removing the DeployBlockerCash label because:
The label was re-added by @pecanoro (internal employee) on Feb 2 with the reasoning: "it's a feature that is not on production and we shouldn't deploy something that is not working"
Per protocol, deploy blocker labels added by internal employees should not be automatically removed
Activity
melvin-bot commentedon Jan 31, 2026
@JS00001 recently merged #80915, but they are OOO right now, so I'll auto-assign someone else.
melvin-bot commentedon Jan 31, 2026
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 31, 2026
Triggered auto assignment to @pecanoro (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 31, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 31, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Jan 31, 2026
Investigation Summary
Classification: Backend bug
Causing PR: N/A - No App PR caused this issue (Low confidence)
Related PRs:
Recommendation: NEEDS INVESTIGATION
This appears to be a backend bug where the rule matching logic does not properly handle wildcard () merchant matching. The App correctly allows users to create rules with () as the merchant (with the hint "Type (*) to create a rule that applies to all merchants"), but when expenses are created, the backend is not applying these wildcard rules.
Why this is a backend bug:
Labels: DeployBlockerCash label should be REMOVED since this requires a backend fix, not an App revert.
Detailed Analysis
Evidence
The issue clearly states:
Feature Context
Personal expense rules is a NEW feature (version 9.3.11-17, N/A in production):
Root Cause
The rule matching logic lives in the backend. When a user creates an expense, the backend should:
The backend is failing to recognize (*) as a wildcard that should match all merchants. This is not an App bug because:
SetNameValuePairAPI callsRecommended Action
Tag backend engineers to investigate and fix the wildcard merchant matching logic in the rule application system. The frontend is working correctly.
22 remaining items
melvin-bot commentedon Feb 9, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #80915
github-actions commentedon Feb 9, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Feb 9, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #80915
melvin-bot commentedon Feb 9, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Feb 9, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Feb 9, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Feb 9, 2026
💬 A slack conversation has been started in #expensify-open-source
OSBotify commentedon Feb 9, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #79659 - "Expense rules phase 2" by @situchan (High confidence)
Fix PR: #81177 - "Update "use *" to "use ."" by @JS00001 (Already merged to main)
Related Issues: Part of #75903
Recommendation: DEMOTE
This issue has already been fixed in PR #81177, which corrected the merchant hint text from "*" to "." to match OldDot/Classic behavior. The fix is merged to main but not yet in the current staging deploy.
Why DEMOTE:
Labels: REMOVE DeployBlockerCash - this does not need to block the current App deploy since the fix is already in main and will ship in the next cycle.
Detailed Analysis
Evidence
Timeline of events:
Root cause:
The frontend code in PR #79659 incorrectly told users to use "*" as the wildcard character for merchant matching. However, the backend (inherited from OldDot/Classic) expects "." as the wildcard character. This was a frontend documentation/UX bug, not a backend logic bug.
Verification
I verified that:
merchantHint: 'Type . to create a rule that applies to all merchants'Root Cause
This was a frontend UX bug where the hint text did not match the backend implementation:
The backend rule matching logic was working correctly all along - it just required the correct wildcard character that OldDot has always used.
Current Status
The issue is already resolved in the codebase. The fix (PR #81177) is merged to main and will be included in the next staging deploy. No further action is needed except to remove the deploy blocker label since this does not warrant blocking the current deploy.
pecanoro commentedon Feb 9, 2026
Ok, Melvin didn't remove my label so that's good! Closing again
OSBotify commentedon Feb 9, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #79659 - Expense rules phase 2 by @situchan (High confidence)
Fix PR: #81177 - Update wildcard from * to . by @JS00001 (Already merged to main)
Related Issues: Part of #75903
Recommendation: DEMOTE
This issue has already been fixed in PR #81177, which corrected the merchant hint text from * to . to match OldDot/Classic behavior. The fix is merged to main but not yet in the current staging deploy.
Why DEMOTE:
Labels: REMOVE DeployBlockerCash - this does not need to block the current App deploy since the fix is already in main and will ship in the next cycle.
Detailed Analysis
Evidence
Timeline of events:
Root cause:
The frontend code in PR #79659 incorrectly told users to use * as the wildcard character for merchant matching. However, the backend (inherited from OldDot/Classic) expects . as the wildcard character. This was a frontend documentation/UX bug, not a backend logic bug.
Verification
I verified that:
Root Cause
This was a frontend UX bug where the hint text did not match the backend implementation:
The backend rule matching logic was working correctly all along - it just required the correct wildcard character that OldDot has always used.
Current Status
The issue is already resolved in the codebase. The fix (PR #81177) is merged to main and will be included in the next staging deploy. No further action is needed except to remove the deploy blocker label since this does not warrant blocking the current deploy.
pecanoro commentedon Feb 9, 2026
Ok, Melvin didn't remove my label so that's good! Closing again
OSBotify commentedon Feb 9, 2026
Update on Label Decision
Per my investigation, this issue has been fixed in PR #81177 (merged to main on Feb 2). However, I am NOT removing the DeployBlockerCash label because:
Context for decision makers:
Recommendation: Internal team should decide whether to: