You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-02-12] [$250] Login - Unable to sign in with magic link #81109
Change the magic link to staging and paste in any messenger app (changing magic link to staging is optional)
Tap on the magic link from the main device
Expected Result:
User should be successfully signed in to the account
Actual Result:
User navigated to the app and remains on the “Enter magic code” screen without being signed in. The issue occurs with both staging and production magic links
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #78261 - "fix: Signing with magic link doesnt lead to 2FA page for account with 2FA enabled" by @nkdengineer (High confidence) Related Issues: #77410 (original issue that PR #78261 fixed)
Recommendation: REVERT
PR #78261 should be reverted as it has broken the magic link sign-in flow for users. While the PR successfully fixed the SAML + 2FA flow, it introduced a regression that prevents users from signing in via magic links.
PR #78261 modified src/pages/signin/SignInPage.tsx by adding "&& !hasValidateCode" to the shouldShowChooseSSOOrMagicCode condition on line 105. This change was intended to fix issue #77410 where SAML + 2FA users clicking a magic link would see the "Choose SSO or Magic Code" screen instead of going directly to the 2FA prompt.
However, this change appears to have introduced a regression in the magic link sign-in flow for regular users (and possibly SAML users as well), causing them to remain stuck on the "Enter magic code" screen without being signed in.
The addition of "&& !hasValidateCode" to the shouldShowChooseSSOOrMagicCode condition altered the sign-in page display logic in a way that appears to break the magic link authentication flow. When a user clicks a magic link:
On native apps, ValidateLoginPage calls signInWithValidateCodeAndNavigate
If authentication requires additional steps or fails, the user is navigated back to SignInPage
SignInPage should display the appropriate form based on the authentication state
The modified condition may be preventing the correct form from being displayed or causing the automatic sign-in process to fail
The exact mechanism of failure requires further investigation, but the timing, affected area, and symptoms all point to PR #78261 as the root cause.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.14-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@hungvu193@laurenreidexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Open app, logout if logged in
Type a valid login email
Tap on Continue button
Change the magic link to staging and paste in any messenger app (changing magic link to staging is optional)
Activity
melvin-bot commentedon Jan 31, 2026
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 31, 2026
Triggered auto assignment to @carlosmiceli (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 31, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 31, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Jan 31, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #78261 - "fix: Signing with magic link doesnt lead to 2FA page for account with 2FA enabled" by @nkdengineer (High confidence)
Related Issues: #77410 (original issue that PR #78261 fixed)
Recommendation: REVERT
PR #78261 should be reverted as it has broken the magic link sign-in flow for users. While the PR successfully fixed the SAML + 2FA flow, it introduced a regression that prevents users from signing in via magic links.
Labels: Keeping DeployBlockerCash label (App deploy remains blocked)
Detailed Analysis
Evidence
PR #78261 modified src/pages/signin/SignInPage.tsx by adding "&& !hasValidateCode" to the shouldShowChooseSSOOrMagicCode condition on line 105. This change was intended to fix issue #77410 where SAML + 2FA users clicking a magic link would see the "Choose SSO or Magic Code" screen instead of going directly to the 2FA prompt.
However, this change appears to have introduced a regression in the magic link sign-in flow for regular users (and possibly SAML users as well), causing them to remain stuck on the "Enter magic code" screen without being signed in.
Verification
Root Cause
The addition of "&& !hasValidateCode" to the shouldShowChooseSSOOrMagicCode condition altered the sign-in page display logic in a way that appears to break the magic link authentication flow. When a user clicks a magic link:
The exact mechanism of failure requires further investigation, but the timing, affected area, and symptoms all point to PR #78261 as the root cause.
35 remaining items
melvin-bot commentedon Feb 5, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Feb 5, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.14-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-02-12. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Feb 5, 2026
@hungvu193 @laurenreidexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
laurenreidexpensify commentedon Feb 9, 2026
Offer sent to @mohammadjafarinejad in upwork
mohammadjafarinejad commentedon Feb 10, 2026
@laurenreidexpensify, I didn't receive the offer. Could you please send it again?
laurenreidexpensify commentedon Feb 12, 2026
@mohammadjafarinejad can you check now? thanks
mohammadjafarinejad commentedon Feb 13, 2026
@laurenreidexpensify Accepted
hungvu193 commentedon Feb 13, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: [Home Page] Remove Beta Gate for Release 1 #80965
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
hungvu193 commentedon Feb 13, 2026
@laurenreidexpensify Could you post the payment summary here? Thank you
laurenreidexpensify commentedon Feb 13, 2026
Payment Summary