Skip to content

[Due for payment 2026-02-12] [$250] Login - Unable to sign in with magic link #81109

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.11-17
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-3953/folder/13176924/41237540/1160418246?p=2
Email or phone of affected tester (no customers): applausetester+omqq1@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: iPhone 15 Pro Max/iOS 26.2, Pixel 6/Android 16
App Component: User Settings

Action Performed:

Precondition: user is logged out

  1. Open app
  2. Type a valid login email
  3. Tap on Continue button
  4. Change the magic link to staging and paste in any messenger app (changing magic link to staging is optional)
  5. Tap on the magic link from the main device

Expected Result:

User should be successfully signed in to the account

Actual Result:

User navigated to the app and remains on the “Enter magic code” screen without being signed in. The issue occurs with both staging and production magic links

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022019156918202124259
  • Upwork Job ID: 2019156918202124259
  • Last Price Increase: 2026-02-04
Issue OwnerCurrent Issue Owner: @laurenreidexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 31, 2026
  2. melvin-bot commented on Jan 31, 2026

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jan 31, 2026

    @melvin-bot

    Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jan 31, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jan 31, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Jan 31, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #78261 - "fix: Signing with magic link doesnt lead to 2FA page for account with 2FA enabled" by @nkdengineer (High confidence)
    Related Issues: #77410 (original issue that PR #78261 fixed)

    Recommendation: REVERT

    PR #78261 should be reverted as it has broken the magic link sign-in flow for users. While the PR successfully fixed the SAML + 2FA flow, it introduced a regression that prevents users from signing in via magic links.

    Labels: Keeping DeployBlockerCash label (App deploy remains blocked)

    Detailed Analysis

    Evidence

    PR #78261 modified src/pages/signin/SignInPage.tsx by adding "&& !hasValidateCode" to the shouldShowChooseSSOOrMagicCode condition on line 105. This change was intended to fix issue #77410 where SAML + 2FA users clicking a magic link would see the "Choose SSO or Magic Code" screen instead of going directly to the 2FA prompt.

    However, this change appears to have introduced a regression in the magic link sign-in flow for regular users (and possibly SAML users as well), causing them to remain stuck on the "Enter magic code" screen without being signed in.

    Verification

    Root Cause

    The addition of "&& !hasValidateCode" to the shouldShowChooseSSOOrMagicCode condition altered the sign-in page display logic in a way that appears to break the magic link authentication flow. When a user clicks a magic link:

    1. On native apps, ValidateLoginPage calls signInWithValidateCodeAndNavigate
    2. If authentication requires additional steps or fails, the user is navigated back to SignInPage
    3. SignInPage should display the appropriate form based on the authentication state
    4. The modified condition may be preventing the correct form from being displayed or causing the automatic sign-in process to fail

    The exact mechanism of failure requires further investigation, but the timing, affected area, and symptoms all point to PR #78261 as the root cause.

  7. 35 remaining items

  8. melvin-bot commented on Feb 5, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on Feb 5, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.14-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-02-12. 🎊

    For reference, here are some details about the assignees on this issue:

  10. melvin-bot commented on Feb 5, 2026

    @melvin-bot

    @hungvu193 @laurenreidexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. laurenreidexpensify commented on Feb 9, 2026

    @laurenreidexpensify
    Contributor

    Offer sent to @mohammadjafarinejad in upwork

  12. mohammadjafarinejad commented on Feb 10, 2026

    @mohammadjafarinejad
    Contributor

    @laurenreidexpensify, I didn't receive the offer. Could you please send it again?

  13. laurenreidexpensify commented on Feb 12, 2026

    @laurenreidexpensify
    Contributor

    @mohammadjafarinejad can you check now? thanks

  14. mohammadjafarinejad commented on Feb 13, 2026

    @mohammadjafarinejad
    Contributor
  15. hungvu193 commented on Feb 13, 2026

    @hungvu193
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: [Home Page] Remove Beta Gate for Release 1 #80965

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    Test:

    1. Open app, logout if logged in
    2. Type a valid login email
    3. Tap on Continue button
    4. Change the magic link to staging and paste in any messenger app (changing magic link to staging is optional)
    5. Tap on the magic link from the main device
    6. Verify that you can be logged in via the link.

    Do we agree 👍 or 👎

  16. hungvu193 commented on Feb 13, 2026

    @hungvu193
    Contributor

    @laurenreidexpensify Could you post the payment summary here? Thank you

  17. laurenreidexpensify commented on Feb 13, 2026

    @laurenreidexpensify
    Contributor

    Payment Summary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions