Repository navigation
fix: Login - Unable to sign in with magic link - #81488
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@hungvu193 Resolved. |
| SCREENS.CONNECTION_COMPLETE, | ||
| SCREENS.BANK_CONNECTION_COMPLETE, |
There was a problem hiding this comment.
TRANSITION_BETWEEN_APPS,
CONNECTION_COMPLETE
BANK_CONNECTION_COMPLETE
I've just checked and these screens are under AuthScreens. Why do you put them here?
Any reason for that?
There was a problem hiding this comment.
App/src/libs/Navigation/AppNavigator/PublicScreens.tsx
Lines 28 to 30 in 088ed06
Looks like we still can use SCREEN.HOMES as a default fallback 🤔
There was a problem hiding this comment.
Because PublicScreens.tsx no longer has NAVIGATORS.REPORTS_SPLIT_NAVIGATOR (as I explained in my proposal), we need to include all screens from PublicScreens.tsx so their fallbackRoute is HOME.
App/src/libs/Navigation/AppNavigator/PublicScreens.tsx
Lines 29 to 38 in 00bf03f
But most of the screens that we have in PublicScreens.tsx are also included in AuthScreens.tsx.
Maybe we should fallback the public screens to HOME only if the user is not authenticated? 🤔
There was a problem hiding this comment.
Looks like we still can use
SCREEN.HOMESas a default fallback 🤔
But I think if we do so, we may have a problem based on this comment
App/src/libs/Navigation/helpers/getAdaptedStateFromPath.ts
Lines 170 to 173 in 088ed06
There was a problem hiding this comment.
Cool. Thanks for the explanation. I think Yeah, we should fallback to home when they're not authenticated.
| // We will use it if the reportID is not defined. Router of this navigator has logic to fill it with a report. | ||
| const fallbackRoute = { | ||
| name: NAVIGATORS.REPORTS_SPLIT_NAVIGATOR, | ||
| name: isPublicScreenName(route?.name) ? SCREENS.HOME : NAVIGATORS.REPORTS_SPLIT_NAVIGATOR, |
There was a problem hiding this comment.
Let's leave a comment here to explain.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-02-05.at.17.50.32.movAndroid: mWeb ChromeScreen.Recording.2026-02-05.at.17.52.50.moviOS: HybridAppScreen.Recording.2026-02-05.at.17.34.47.moviOS: mWeb SafariScreen.Recording.2026-02-05.at.17.56.15.movMacOS: Chrome / SafariScreen.Recording.2026-02-05.at.17.47.31.mov |
hungvu193
left a comment
There was a problem hiding this comment.
LGTM
Just one NAB comment:
#81488 (comment)
|
🚧 @carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
fix: Login - Unable to sign in with magic link (cherry picked from commit 80b0d87) (cherry-picked to production by Julesssss)
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.13-1 🚀
|
|
Not repro, Chrome Staging - v9.3.13-1 Screen.Recording.2026-02-05.at.22.23.36.mp4Not repro, Chrome Prod- v9.3.12-1 Screen.Recording.2026-02-05.at.22.26.57.mp4Repro: staging/iOS/18.6.2/build: 9.312-1 ScreenRecording_02-05-2026.17-39-26_1.MP4Not Repro: prod/iOS/18.6.2/9.3.10-6 ScreenRecording_02-05-2026.17-42-50_1.MP4Repro, Honor x6b / Android 14 , Staging V9. 3.12-1 SVID_20260205_154324_1.1.mp4Not repro, Honor x6b /Android 14, Production V9. 3.10-6 SVID_20260205_153157_1.mp4 |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.14-0 🚀
|
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.15-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.15-10 🚀
|
Explanation of Change
Login - Unable to sign in with magic lin
Fixed Issues
$ #81109
PROPOSAL: #81109 (comment)
Tests
Precondition: user is logged out
Offline tests
None
QA Steps
Same as test.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android-web.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios-web.mp4
MacOS: Chrome / Safari
web.mp4