Skip to content

Travel - No trip expenses created in workspace chat #82593

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.3.20-2
Reproducible in staging?: Yes
Reproducible in production?: Unable to validate in Prod - Provide reasoning.
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13177079/test-cases/41237918
Email or phone of affected tester (no customers): new expensifail account
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: MacOS Monterey 12.7.4 / Chrome
App Component: Other

Action Performed:

Precondition2:

  1. Sign up new account in OldDot. Return to OldDot again after navigating to NewDot.
  2. Create Worksapce, open DevTools console and run:
    var settings = NVP.get('travelSettings') || {};
    settings.testAccount = true;
    NVP.set('travelSettings', settings);
  3. Enable Travel feature in worksapce > More features

STR:

  1. Start one-way flight
  2. Complete the booking flow on https://staging.travel.expensify.com/
  3. Open workspace chat

Expected Result:

There're 2 expenses:
one of the expenses is for the price of the flight
one of the expenses is for 15$
Both expenses have receipts and the details match to what was booked

Actual Result:

No expenses in worksapce chat

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @Ollyws

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 16, 2026
  2. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 16, 2026
  3. melvin-bot commented on Feb 16, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

  4. melvin-bot commented on Feb 16, 2026

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. melvin-bot commented on Feb 16, 2026

    @melvin-bot

    Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

  6. MelvinBot commented on Feb 18, 2026

    @MelvinBot
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    After booking a one-way flight through Expensify Travel (staging.travel.expensify.com), no expenses appear in the workspace chat. Expected behavior is two expenses (flight price + $15 booking fee), both with receipts matching the booking details.

    What is the root cause of that problem?

    After thorough investigation of the App codebase, trip expense creation is entirely server-side — the App frontend has zero logic for creating trip expenses and is purely a display layer. Here is how the flow works:

    1. User clicks "Book Travel" → App calls GenerateSpotnanaToken API → opens Spotnana portal (src/libs/actions/Link.ts:122-145)
    2. Booking happens on Spotnana's side (external to App)
    3. Spotnana sends a webhook to Expensify backend (Auth/Web-Expensify) — not visible in App code
    4. Backend processes webhook and creates: (a) trip room report (chatType='tripRoom') with tripData containing Spotnana payload (src/types/onyx/Report.ts:260-273), (b) IOU/expense reports with chatReportID → trip room, (c) transactions with receipt.reservationList, (d) TRIPPREVIEW action in workspace chat with linkedReportID → trip room (src/types/onyx/OriginalMessage.ts:1027-1036)
    5. All data arrives on client via Pusher OnyxUpdates (src/libs/actions/User.ts:926-951)

    No client-side filtering would hide trip expenses once they exist in Onyx:

    The root cause is almost certainly server-side (Auth/Web-Expensify backend): the Spotnana booking webhook is either not being received, not being processed correctly, or the backend is failing to create the trip room / expense reports / transactions / TRIPPREVIEW action after the booking completes. This could be specific to one-way flights (missing return leg data causing a validation failure) or to the staging environment's Spotnana integration.

    What changes do you think we should make in order to solve the problem?

    Since the issue is server-side, the investigation needs to move to the backend repos (Auth/Web-Expensify). Specific steps:

    1. Check backend logs for the Spotnana webhook receipt/processing after the test booking — verify whether the booking completion notification was received at all
    2. Check if a trip room was created for the booking — if no trip room exists, the webhook handler failed
    3. Check if the TRIPPREVIEW action was created in the workspace policy expense chat — if the trip room exists but no TRIPPREVIEW, the action creation logic has a bug
    4. Check if expense reports and transactions were created with proper linkage (chatReportID → trip room, receipt.reservationList populated)
    5. Investigate one-way flight edge case — the backend may have validation that expects return leg data and fails silently for one-way bookings

    If the issue is confirmed as a backend-only problem (no Onyx data created), no App changes are needed — the fix would be in Auth/Web-Expensify webhook processing.

    What alternative solutions did you explore? (Optional)

    Open Questions

    • What does the backend webhook handler do when processing a one-way flight booking from Spotnana? Is there missing error handling for flights without a return leg?
    • Is the $15 booking fee handled as a separate transaction or part of the flight transaction? If separate, there may be a different creation path for fee transactions.
    • Is this reproducible only on staging or also on production? The staging Spotnana integration may have a configuration issue.
    • Has this ever worked on staging, or is this the first time it was tested with the current Spotnana/backend setup?

    Next Steps for Contributor+ team: This issue appears to be a server-side (backend) bug, not an App frontend issue. The App code correctly renders trip data when it exists in Onyx — the data is simply not being created. Investigation should continue in Auth/Web-Expensify repos to trace the Spotnana webhook processing. Reply with @MelvinBot <your feedback> to refine this analysis.

  7. Ollyws commented on Feb 19, 2026

    @Ollyws
    Contributor

    I agree with Melvin, seems to be a backend issue @CortneyOfstad

  8. removed
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 20, 2026
  9. 12 remaining items

  10. added
    Hot PickReady for an engineer to pick up and run with
    on Feb 27, 2026
  11. melvin-bot commented on Mar 2, 2026

    @melvin-bot

    @CortneyOfstad @Ollyws this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  12. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    @Ollyws Still overdue 6 days?! Let's take care of this!

  13. melvin-bot commented on Mar 10, 2026

    @melvin-bot

    @Ollyws 10 days overdue. I'm getting more depressed than Marvin.

  14. CortneyOfstad commented on Mar 11, 2026

    @CortneyOfstad
    Contributor

    @Ollyws can you comment to clear the Overdue label?

  15. Ollyws commented on Mar 12, 2026

    @Ollyws
    Contributor

    👍

  16. mvtglobally commented on Mar 15, 2026

    @mvtglobally

    Issue not reproducible during KI retests. (First week)

  17. CortneyOfstad commented on Mar 16, 2026

    @CortneyOfstad
    Contributor

    I am unable to recreate either, so going to close as this appears to have been a one-off issue. Thank you!

  18. stitesExpensify commented on Mar 18, 2026

    @stitesExpensify
    Contributor

    FYI this was the cause of #fireroom-2026-02-27-travel-payloads, and was the only indicator that we had that Expensify Travel was completely broken for all customers. Since it wasn't escalated, 100% of our travel customers had a broken travel integration for 9 full days.

    In the future we need to make sure that we consider the implications of the bug and try to prioritize accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Hot PickReady for an engineer to pick up and run withInternalRequires API changes or must be handled by Expensify staffMelvin TriageAutomatic AI Analysis of an issue

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions