Skip to content

Remove unused reportActions prop from PureReportActionItem - #82263

Merged
rlinoz merged 6 commits into
mainfrom
rodrigo-improve-openreport-1
Feb 16, 2026
Merged

rlinoz merged 6 commits into
mainfrom
rodrigo-improve-openreport-1

Conversation

@rlinoz

@rlinoz rlinoz commented Feb 12, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

The reportActions prop (entire sorted array of all report actions) was threaded through 4+ component levels to PureReportActionItem where it was never used in the render body. Its only usage was a deepEqual comparison in the memo comparator.

The no-unused-prop-types was added here https://github.com/Expensify/App/pull/36934/changes#r1526813406 but the code referenced in that comment changed, see below.

This prop was originally used in a withOnyx HOC key function but that usage was removed when it was replaced by parentReportActionForTransactionThread here 69cfe20b8e6#diff-f0bdc7ab41060e24e6bcdc847f25185b372c5f9a072251fe5d3cae2a27887920L942

This is a minor improvement but seems to make OpenReport ~100ms faster.

Fixed Issues

$
PROPOSAL:

Tests

The test is mostly a smoke test to make sure nothing broke.

Have 2 tabs open with different accounts (submitter and approver)

  1. Create report and submit a report
  2. Verify the chats of both looks right
  3. Approve, pay, send messages
  4. Verify all report actions are correct
  5. React to a message
  6. Verify it displays correctly in both tabs

Edit comment test

  1. Send the last message in a chat, start editing it
  2. From the second account send a bunch of messages
  3. Go back to the first account, scroll up and finish editing the message
  4. Verify you are not scrolled back to the bottom since the mesasge is not the last anymore.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

The test is mostly a smoke test to make sure nothing broke.

Have 2 tabs open with different accounts (submitter and approver)

  1. Create report and submit a report
  2. Verify the chats of both looks right
  3. Approve, pay, send messages
  4. Verify all report actions are correct
  5. React to a message
  6. Verify it displays correctly in both tabs

Edit comment test

  1. Send the last message in a chat, start editing it
  2. From the second account send a bunch of messages
  3. Go back to the first account, scroll up and finish editing the message
  4. Verify you are not scrolled back to the bottom since the mesasge is not the last anymore.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

The reportActions prop (entire sorted array of all report actions) was
threaded through 4+ component levels to PureReportActionItem where it
was never used in the render body. Its only usage was a deepEqual
comparison in the memo comparator — an expensive O(n) check on 50-100+
objects that protected against a no-op re-render.

This prop was originally used in a withOnyx HOC key function but that
usage was removed in April 2024 when it was replaced by
parentReportActionForTransactionThread. The prop, eslint-disable, and
deepEqual were left behind as dead code.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rlinoz rlinoz self-assigned this Feb 12, 2026
rlinoz and others added 2 commits February 12, 2026 14:14
Remove reportActions from useCallback dependency arrays in
ReportActionsList and MoneyRequestReportActionsList, and fix a missed
test instance in PureReportActionItemTest.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@rlinoz
rlinoz marked this pull request as ready for review February 12, 2026 18:37
@rlinoz
rlinoz requested review from a team as code owners February 12, 2026 18:37
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and inimaga and removed request for a team February 12, 2026 18:38
@melvin-bot

melvin-bot Bot commented Feb 12, 2026

Copy link
Copy Markdown

@inimaga Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

1 similar comment
@melvin-bot

melvin-bot Bot commented Feb 12, 2026

Copy link
Copy Markdown

@inimaga Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 009eb24d41

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 2190 to 2193
prevProps.linkedReportActionID === nextProps.linkedReportActionID &&
deepEqual(prevProps.report?.fieldList, nextProps.report?.fieldList) &&
deepEqual(prevProps.transactionThreadReport, nextProps.transactionThreadReport) &&
deepEqual(prevProps.reportActions, nextProps.reportActions) &&
deepEqual(prevParentReportAction, nextParentReportAction) &&

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Compare index in memoized report action item

The memo comparator no longer has any fallback that changes when list ordering changes, but it still does not compare index, so an action can skip re-render when new actions are inserted ahead of it. In that case ReportActionItemMessageEdit keeps using a stale index for scrollToIndex(...) (see src/pages/inbox/report/ReportActionItemMessageEdit.tsx), which can scroll/focus the wrong row while editing if another message arrives. Please include index (or another ordering signal) in the comparator to keep edit-mode behavior in sync with reordered items.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, added index to comparison

The removed deepEqual on reportActions was accidentally preventing stale
index values — when new messages arrived, the array changed, every item
re-rendered, and picked up its updated position. Without that check,
index can go stale, causing scrollToIndex in ReportActionItemMessageEdit
to target the wrong row during editing.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rlinoz
rlinoz requested a review from Pujan92 February 12, 2026 19:41
@Pujan92

Pujan92 commented Feb 13, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-02-14.at.19.38.16.mov
Android: mWeb Chrome
iOS: HybridApp
Screen.Recording.2026-02-14.at.18.55.42.mov
iOS: mWeb Safari
Screen.Recording.2026-02-14.at.19.08.32.mov
MacOS: Chrome / Safari
Screen.Recording.2026-02-14.at.18.28.49.mov

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Product review isn't required on this PR.

@Pujan92

Pujan92 commented Feb 14, 2026

Copy link
Copy Markdown
Contributor

@rlinoz conflicts need to resovle

@rlinoz
rlinoz requested review from a team, stephanieelliott and tgolen as code owners February 16, 2026 13:05
@rlinoz

rlinoz commented Feb 16, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@rlinoz

rlinoz commented Feb 16, 2026

Copy link
Copy Markdown
Contributor Author

@Pujan92 solved

@rlinoz

rlinoz commented Feb 16, 2026

Copy link
Copy Markdown
Contributor Author

@rlinoz rlinoz requested review from https://github.com/orgs/Expensify/teams/design, stephanieelliott and tgolen as code owners 2 minutes ago

No idea how this happened?

@Pujan92 Pujan92 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well! 👍

@melvin-bot
melvin-bot Bot requested a review from nkuoch February 16, 2026 13:11
@melvin-bot

melvin-bot Bot commented Feb 16, 2026

Copy link
Copy Markdown

@nkuoch Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot

melvin-bot Bot commented Feb 16, 2026

Copy link
Copy Markdown

🎯 @Pujan92, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #82559.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@rlinoz

rlinoz commented Feb 16, 2026

Copy link
Copy Markdown
Contributor Author

Most people are OOO today, so I am merging this one before we get more conflicts.

I can address any other concern as a follow up!

@rlinoz
rlinoz merged commit c029b13 into main Feb 16, 2026
34 checks passed
@rlinoz
rlinoz deleted the rodrigo-improve-openreport-1 branch February 16, 2026 15:36
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Feb 17, 2026
93 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.21-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.21-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants