You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-22] Navigation - User does not navigate to concierge chat via link when login with new-old account #82818
// Don't want to call `openReport` again when logging out and then logging in
setIsAuthenticatedAtStartup(true);
}
App.openApp();
}
Since /concierge does not match the report route pattern (/r/:reportID), reportID is empty. The condition if (reportID && !isAuthenticatedAtStartup) fails, so only App.openApp() is called and the user lands on the home page.
What changes do you think we should make in order to solve the problem?
Add concierge route detection in AuthScreens.tsx to navigate users to concierge chat after login when they initially clicked a /concierge link.
Add concierge route handling after the report check
src/libs/Navigation/AppNavigator/AuthScreens.tsx
}elseif(initialURL?.includes(ROUTES.CONCIERGE)&&!isAuthenticatedAtStartup){// Navigate to concierge chat when logging in via concierge linkReport.navigateToConciergeChat(conciergeReportID,true);setIsAuthenticatedAtStartup(true);}
This reuses the existing navigateToConciergeChat function which handles creating a concierge chat if one does not exist.
What alternative solutions did you explore? (Optional)
Considered modifying ConciergePage.tsx to preserve the original destination before redirecting to login. Rejected because it adds complexity to the authentication flow and the simpler fix in AuthScreens.tsx directly addresses the gap in post-login navigation handling.
Files Modified:
src/libs/Navigation/AppNavigator/AuthScreens.tsx - Added concierge route detection and navigation after login
Testing Performed:
TypeScript compilation passes
Lint checks pass
Prettier formatting check passes
Verified the fix follows existing codebase patterns
Please re-state the problem that we are trying to solve in this issue.
User does not navigate to concierge chat via link and lands on home page instead.
What is the root cause of that problem?
When the user opens the concierge URL while logged out, the app shows the sign-in page. After sign-in, post-login deep link navigation is only run for anonymous users, so a normal (non-anonymous) user never gets navigated to the /concierge route and stays on the default post-login screen (home).
In openReportFromDeepLink, the route is correctly derived from the URL via getRouteFromLink
(e.g. 'concierge' for /concierge). The logic that performs the actual navigation after sign-in lives in handleDeeplinkNavigation, which calls Navigation.navigate(route, …) and would correctly open the concierge flow. However, that handler is only invoked when [isAnonymousUser()]
is true, so regular signed-in users who arrived via the concierge link never run this navigation and remain on home.
What changes do you think we should make in order to solve the problem?
Run post-login deep link navigation for all users who opened the app via a deep link while unauthenticated, not only for anonymous users. That way, opening /concierge and then signing in (with any account type) will trigger handleDeeplinkNavigation() and navigate to the concierge route, after which ConciergePage will redirect to the actual concierge chat.
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
@sobitneupane , please post your tests in the PR reviewer checklist post under the sections at the bottom. Reasoning, they're supposed to go there 🧌 , more so.. with me paying all issues, I have automation setup to navigate to that area to determine is tests have been completed. If I don't see tests there I'll be paying $125 for issues.
Activity
melvin-bot commentedon Feb 18, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (
External)melvin-bot commentedon Feb 18, 2026
Triggered auto assignment to @NicMendonca (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.MelvinBot commentedon Feb 18, 2026
I have failed to help you. I let you down and for that I am sorry. Please try again later.
Failure details: https://github.com/Expensify/Expensify/actions/runs/22146075383
HiepPP commentedon Feb 18, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
Users clicking the
/conciergelink while not authenticated land on the home page after logging in, instead of being navigated to the concierge chat.What is the root cause of that problem?
The post-login navigation flow in
AuthScreens.tsxonly handles report-based deep links viagetReportIDFromLink():App/src/libs/Navigation/AppNavigator/AuthScreens.tsx
Lines 272 to 279 in 3a0446b
Since
/conciergedoes not match the report route pattern (/r/:reportID),reportIDis empty. The conditionif (reportID && !isAuthenticatedAtStartup)fails, so onlyApp.openApp()is called and the user lands on the home page.What changes do you think we should make in order to solve the problem?
Add concierge route detection in
AuthScreens.tsxto navigate users to concierge chat after login when they initially clicked a/conciergelink.conciergeReportIDfrom Onyx statesrc/libs/Navigation/AppNavigator/AuthScreens.tsxsrc/libs/Navigation/AppNavigator/AuthScreens.tsxThis reuses the existing
navigateToConciergeChatfunction which handles creating a concierge chat if one does not exist.What alternative solutions did you explore? (Optional)
Considered modifying
ConciergePage.tsxto preserve the original destination before redirecting to login. Rejected because it adds complexity to the authentication flow and the simpler fix inAuthScreens.tsxdirectly addresses the gap in post-login navigation handling.Files Modified:
src/libs/Navigation/AppNavigator/AuthScreens.tsx- Added concierge route detection and navigation after loginTesting Performed:
abbasifaizan70 commentedon Feb 18, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
User does not navigate to concierge chat via link and lands on home page instead.
What is the root cause of that problem?
When the user opens the concierge URL while logged out, the app shows the sign-in page. After sign-in, post-login deep link navigation is only run for anonymous users, so a normal (non-anonymous) user never gets navigated to the
/conciergeroute and stays on the default post-login screen (home).In
openReportFromDeepLink, the route is correctly derived from the URL via getRouteFromLinkApp/src/libs/ReportUtils.ts
Lines 9594 to 9623 in 3b83796
(e.g.
'concierge'for/concierge). The logic that performs the actual navigation after sign-in lives inhandleDeeplinkNavigation, which callsNavigation.navigate(route, …)and would correctly open the concierge flow. However, that handler is only invoked when [isAnonymousUser()]App/src/libs/actions/Link.ts
Lines 367 to 369 in 3b83796
is true, so regular signed-in users who arrived via the concierge link never run this navigation and remain on home.
What changes do you think we should make in order to solve the problem?
Run post-login deep link navigation for all users who opened the app via a deep link while unauthenticated, not only for anonymous users. That way, opening
/conciergeand then signing in (with any account type) will triggerhandleDeeplinkNavigation()and navigate to the concierge route, after whichConciergePagewill redirect to the actual concierge chat.File:
App/src/libs/actions/Link.tsdangrous commentedon Feb 18, 2026
I can handle internal review on this one when ready!
dangrous commentedon Feb 20, 2026
@sobitneupane let us know what you think of the proposals when you can - thanks!
56 remaining items
melvin-bot commentedon May 20, 2026
@sobitneupane Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon May 21, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon May 22, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
sobitneupane commentedon May 25, 2026
BugZero Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: Create navigation guards + implement Onboarding Guard #79898 (comment)
Link to the comment on the Issue: [$500] Centralize navigation redirects with guard system #79974 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/640691
Regression Test Proposal
Test:
/conciergeto open the app (e.g., https://staging.new.expensify.com/concierge)Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-3c2b-a504-0ebf-c4dee85506f4sobitneupane commentedon May 25, 2026
This regression was introduced by the PR for this issue:
mallenexpensify commentedon May 25, 2026
Payment Summary
Contributor: @nkdengineer due $250 via NewDot
Contributor+: @sobitneupane due $250 via NewDot
^ Test case created. Thx
@sobitneupane , please post your tests in the PR reviewer checklist post under the sections at the bottom. Reasoning, they're supposed to go there 🧌 , more so.. with me paying all issues, I have automation setup to navigate to that area to determine is tests have been completed. If I don't see tests there I'll be paying $125 for issues.
twisterdotcom commentedon Jun 16, 2026
$250 approved for @nkdengineer in Report ID: R009bfMTMRr7.
Zapier Logs
Run ID: 00040eee-3e00-aff0-8fa0-80d4d9ba68d4SO: https://stackoverflowteams.com/c/expensify/questions/7582
JmillsExpensify commentedon Jul 28, 2026
$250 approved for @sobitneupane