Skip to content

[Due for payment 2026-09-16] [$250] Expense - Approve dropdown menu overlaps with composer #83264

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.25-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #70825
Email or phone of affected tester (no customers): jsodjsodnjoisjdosij@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create two expenses.
  4. Open the expense report.
  5. Hold one of the expenses.
  6. Go back to workspace chat.
  7. Click Submit.
  8. Click Approve button.

Expected Result:

Approve dropdown menu should appear above Approve button and will not overlap with composer.

Actual Result:

Approve dropdown menu overlaps with composer.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Image
Bug7086419_1771884481633.1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @truph01
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022026077250623471037
  • Upwork Job ID: 2026077250623471037
  • Last Price Increase: 2026-02-23

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Feb 23, 2026
  2. melvin-bot commented on Feb 23, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #70825

  3. melvin-bot commented on Feb 23, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Feb 23, 2026

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Feb 23, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Feb 23, 2026

    @MelvinBot
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    When a user opens an expense report with held expenses and clicks the Approve button, the dropdown menu (showing "Approve partial" / "Approve all" options) opens below the button and overlaps with the composer.

    What is the root cause of that problem?

    PR #70825 introduced the ExpenseHeaderApprovalButton component, which renders a ButtonWithDropdownMenu for the approve action when held expenses exist. However, it does not pass an anchorAlignment prop to ButtonWithDropdownMenu (src/components/ExpenseHeaderApprovalButton.tsx:123-134).

    ButtonWithDropdownMenu defaults to { vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOP } (src/components/ButtonWithDropdownMenu/index.tsx:22-26), which makes the popover open below the button. Since the Approve button sits near the bottom of the report preview card (just above the composer), the downward-opening dropdown overlaps the composer.

    By contrast, the sibling Pay button and Add Expense button in MoneyRequestReportPreviewContent both explicitly pass vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.BOTTOM so their dropdowns open above the button, away from the composer.

    What changes do you think we should make in order to solve the problem?

    In ExpenseHeaderApprovalButton, accept an anchorAlignment prop and forward it to ButtonWithDropdownMenu. Then, at each call site where the button appears near the composer (e.g., MoneyRequestReportPreviewContent), pass anchorAlignment with vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.BOTTOM so the dropdown opens upward, matching the existing pattern used by the Pay and Add Expense buttons.

    What alternative solutions did you explore? (Optional)

    An alternative would be to hardcode anchorAlignment={{ vertical: BOTTOM }} directly inside ExpenseHeaderApprovalButton. However, making it a prop is more flexible since the component is also used in MoneyReportHeader (the RHP view), where the default downward direction may be appropriate depending on the layout context.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.

  7. 9 remaining items

  8. MelvinBot commented on Feb 24, 2026

    @MelvinBot
    Contributor

    🤖 Draft PR created: #83292
    Please mark it as "Ready for review" when it is ready for review.

  9. marcochavezf commented on Feb 24, 2026

    @marcochavezf
    Contributor

    Seem this is fixed by the revert done here #83334

  10. marcochavezf commented on Feb 24, 2026

    @marcochavezf
    Contributor
  11. IuliiaHerets commented on Feb 24, 2026

    @IuliiaHerets

    @marcochavezf, not repro: MacOS 13.7.8/Chrome/v.v9.3.25-9

    00.mp4
  12. jponikarchuk commented on Sep 8, 2026

    @jponikarchuk

    Deploy Blocker #100639 was identified to be related to the PR #83667 that attempted to fix this issue.

  13. melvin-bot commented on Sep 8, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  14. added and removed
    ReviewingHas a PR in review
    on Sep 9, 2026
  15. changed the title [-][$250] Expense - Approve dropdown menu overlaps with composer[/-] [+][Due for payment 2026-09-16] [$250] Expense - Approve dropdown menu overlaps with composer[/+] on Sep 9, 2026
  16. melvin-bot commented on Sep 9, 2026

    @melvin-bot

    @truph01

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.74-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-09-16. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions