You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-09-16] [$250] Expense - Approve dropdown menu overlaps with composer #83264
Version Number: 9.3.25-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#70825 Email or phone of affected tester (no customers):jsodjsodnjoisjdosij@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Create two expenses.
Open the expense report.
Hold one of the expenses.
Go back to workspace chat.
Click Submit.
Click Approve button.
Expected Result:
Approve dropdown menu should appear above Approve button and will not overlap with composer.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
When a user opens an expense report with held expenses and clicks the Approve button, the dropdown menu (showing "Approve partial" / "Approve all" options) opens below the button and overlaps with the composer.
What is the root cause of that problem?
PR #70825 introduced the ExpenseHeaderApprovalButton component, which renders a ButtonWithDropdownMenu for the approve action when held expenses exist. However, it does not pass an anchorAlignment prop to ButtonWithDropdownMenu (src/components/ExpenseHeaderApprovalButton.tsx:123-134).
ButtonWithDropdownMenu defaults to { vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOP } (src/components/ButtonWithDropdownMenu/index.tsx:22-26), which makes the popover open below the button. Since the Approve button sits near the bottom of the report preview card (just above the composer), the downward-opening dropdown overlaps the composer.
By contrast, the sibling Pay button and Add Expense button in MoneyRequestReportPreviewContent both explicitly pass vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.BOTTOM so their dropdowns open above the button, away from the composer.
What changes do you think we should make in order to solve the problem?
In ExpenseHeaderApprovalButton, accept an anchorAlignment prop and forward it to ButtonWithDropdownMenu. Then, at each call site where the button appears near the composer (e.g., MoneyRequestReportPreviewContent), pass anchorAlignment with vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.BOTTOM so the dropdown opens upward, matching the existing pattern used by the Pay and Add Expense buttons.
What alternative solutions did you explore? (Optional)
An alternative would be to hardcode anchorAlignment={{ vertical: BOTTOM }} directly inside ExpenseHeaderApprovalButton. However, making it a prop is more flexible since the component is also used in MoneyReportHeader (the RHP view), where the default downward direction may be appropriate depending on the layout context.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.
changed the title [-][$250] Expense - Approve dropdown menu overlaps with composer[/-][+][Due for payment 2026-09-16] [$250] Expense - Approve dropdown menu overlaps with composer[/+]on Sep 9, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.74-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-09-16. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
melvin-bot commentedon Feb 23, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #70825
melvin-bot commentedon Feb 23, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Feb 23, 2026
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Feb 23, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Feb 23, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user opens an expense report with held expenses and clicks the Approve button, the dropdown menu (showing "Approve partial" / "Approve all" options) opens below the button and overlaps with the composer.
What is the root cause of that problem?
PR #70825 introduced the
ExpenseHeaderApprovalButtoncomponent, which renders aButtonWithDropdownMenufor the approve action when held expenses exist. However, it does not pass ananchorAlignmentprop toButtonWithDropdownMenu(src/components/ExpenseHeaderApprovalButton.tsx:123-134).ButtonWithDropdownMenudefaults to{ vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOP }(src/components/ButtonWithDropdownMenu/index.tsx:22-26), which makes the popover open below the button. Since the Approve button sits near the bottom of the report preview card (just above the composer), the downward-opening dropdown overlaps the composer.By contrast, the sibling Pay button and Add Expense button in
MoneyRequestReportPreviewContentboth explicitly passvertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.BOTTOMso their dropdowns open above the button, away from the composer.What changes do you think we should make in order to solve the problem?
In
ExpenseHeaderApprovalButton, accept ananchorAlignmentprop and forward it toButtonWithDropdownMenu. Then, at each call site where the button appears near the composer (e.g.,MoneyRequestReportPreviewContent), passanchorAlignmentwithvertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.BOTTOMso the dropdown opens upward, matching the existing pattern used by the Pay and Add Expense buttons.What alternative solutions did you explore? (Optional)
An alternative would be to hardcode
anchorAlignment={{ vertical: BOTTOM }}directly insideExpenseHeaderApprovalButton. However, making it a prop is more flexible since the component is also used inMoneyReportHeader(the RHP view), where the default downward direction may be appropriate depending on the layout context.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.9 remaining items
MelvinBot commentedon Feb 24, 2026
🤖 Draft PR created: #83292
Please mark it as "Ready for review" when it is ready for review.
marcochavezf commentedon Feb 24, 2026
Seem this is fixed by the revert done here #83334
marcochavezf commentedon Feb 24, 2026
Requested retest here https://expensify.slack.com/archives/C09V78U42D8/p1771954986327269
IuliiaHerets commentedon Feb 24, 2026
@marcochavezf, not repro: MacOS 13.7.8/Chrome/v.v9.3.25-9
00.mp4
jponikarchuk commentedon Sep 8, 2026
Deploy Blocker #100639 was identified to be related to the PR #83667 that attempted to fix this issue.
melvin-bot commentedon Sep 8, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-][$250] Expense - Approve dropdown menu overlaps with composer[/-][+][Due for payment 2026-09-16] [$250] Expense - Approve dropdown menu overlaps with composer[/+]melvin-bot commentedon Sep 9, 2026
@truph01
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.74-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-09-16. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]