Skip to content

Clarify Approval Options When Held Expenses Exist And Fix Regressions - #83667

Merged
marcochavezf merged 87 commits into
Expensify:mainfrom
mkzie2:mkzie2-issue/70383-2
Sep 8, 2026
Merged

marcochavezf merged 87 commits into
Expensify:mainfrom
mkzie2:mkzie2-issue/70383-2

Conversation

@mkzie2

@mkzie2 mkzie2 commented Feb 27, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #70383
$ #83259
$ #83261
$ #83264
PROPOSAL: #70383 (comment)

Tests

  1. Go to ND
  2. Go to WS chat
  3. Create 2 expenses
  4. Mark 1 of them as hold
  5. Submit
  6. Verify that we have 2 options to approve the expense (Partial and full)
  7. Verify that both ways to approve expense work correctly
  • Verify that no errors appear in the JS console

Offline tests

  1. Go to WS chat
  2. Create 2 expenses
  3. Mark 1 of them as hold
  4. Go offline
  5. Submit
  6. Verify that we have 2 options to approve the expense (Partial and full)
  7. Verify that both ways to approve expense work correctly

QA Steps

  1. Go to ND
  2. Go to WS chat
  3. Create 2 expenses
  4. Mark 1 of them as hold
  5. Submit
  6. Verify that we have 2 options to approve the expense (Partial and full)
  7. Verify that both ways to approve expense work correctly
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android.mov
Android: mWeb Chrome
android-web.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios-web.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov

@melvin-bot

melvin-bot Bot commented Feb 27, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@codecov

codecov Bot commented Feb 27, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/ButtonWithDropdownMenu/index.tsx 84.21% <100.00%> (+0.24%) ⬆️
...rc/components/Icon/chunks/expensify-icons.chunk.ts 0.00% <ø> (ø)
...eaderActions/MoneyReportHeaderSecondaryActions.tsx 0.66% <ø> (ø)
src/components/MoneyReportHeaderModalsContext.tsx 22.22% <ø> (ø)
...tReportView/SelectionToolbar/SelectionDropdown.tsx 64.28% <ø> (ø)
.../MoneyRequestReportView/SelectionToolbar/index.tsx 75.00% <ø> (ø)
src/components/PopoverMenu/index.tsx 93.05% <100.00%> (+0.66%) ⬆️
.../MoneyRequestReportPreview/ApproveActionButton.tsx 100.00% <100.00%> (ø)
...tReportPreview/MoneyRequestReportPreviewContext.ts 92.85% <ø> (ø)
...eportPreview/MoneyRequestReportPreviewProvider.tsx 94.36% <100.00%> (-0.16%) ⬇️
... and 14 more
... and 8 files with indirect coverage changes

@mkzie2
mkzie2 marked this pull request as ready for review March 16, 2026 06:25
@mkzie2
mkzie2 requested review from a team as code owners March 16, 2026 06:25
@melvin-bot
melvin-bot Bot requested review from heyjennahay and truph01 and removed request for a team March 16, 2026 06:25
@melvin-bot

melvin-bot Bot commented Mar 16, 2026

Copy link
Copy Markdown

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team March 16, 2026 06:25

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ce4af78465

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

return (
<Button
success
onPress={() => onApprove(true)}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Block restricted delegates before invoking approve action

When isDelegateAccessRestricted is true, this component renders the fallback Button and calls onApprove(true) directly, but the new onApprove handlers in MoneyReportHeader / MoneyRequestReportPreviewContent no longer perform the delegate-access guard before approveMoneyRequest. That regresses the previous behavior (showing the no-access modal) and lets restricted delegates trigger approval attempts instead of being stopped.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkzie2 Can you check?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated!

Comment thread src/components/MoneyReportHeader.tsx Outdated
} else if (isAnyTransactionOnHold) {
setIsHoldMenuVisible(true);
} else {
} else if (!isAnyTransactionOnHold) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Handle held-expense path in confirmApproval callback

The callback now performs approval only in the !isAnyTransactionOnHold branch, so held-expense reports fall through with no action. This callback is still used by payment/selection-mode approve paths (via confirmApproval passed into payment selection), and canApproveIOU() does not exclude held reports, so choosing approve from those menus becomes a silent no-op when any expense is on hold.

Useful? React with 👍 / 👎.

@truph01

truph01 commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

@mkzie2 This PR to fix regressions, should we have the original C+ review it?

@mkzie2

mkzie2 commented Mar 18, 2026

Copy link
Copy Markdown
Contributor Author

@truph01 Yeah this PR should be reviewed by @parasharrajat

@mkzie2

mkzie2 commented Mar 19, 2026

Copy link
Copy Markdown
Contributor Author

Looks like a flaky test

@MelvinBot

MelvinBot commented Sep 6, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Web test steps verification results: ✅ pass

Rechecked at 5676734. The blocker from my last review is fixed — useConfirmApproveReportAction no longer routes held-expense approvals through the pay modal; it now calls approveMoneyRequest({…, full}) directly (useConfirmApproveReportAction.ts:36-60). Verified live on web: the chat report-preview card now opens the correct Approve dropdown and both options actually approve, with no "Confirm payment amount" modal. Both other notes from that review are also resolved, and the only failing checks are Check independent approval and the author/reviewer checklist.

Report D approved after choosing the single option: Approved badge, Pay $30.00, both expenses unheld

Step Status
1. Report header Approve on a report with a held expense opens a dropdown with header copy plus "Approve only <non-held>" / "Approve <full>"Report A ($100 held + $50). Dialog read "Report contains held expenses. Approve only compliant expenses, or approve the entire report?" with exactly two buttons: Approve only $50.00 and Approve $150.00.
Report header Approve dropdown showing held-expense copy plus 'Approve only $50.00' and 'Approve $150.00'
✅
2. "Approve only" approves just the non-held expense; the held one stays held and unapprovedHeader flipped to Pay $50.00 / Approved and A2 reads "Approved". The held $100 expense moved to a new report still badged Outstanding with "This expense was put on hold" and its own unapproved Approve button.
After 'Approve only': report header shows Pay $50.00 / Approved and A2 detail shows Approved
Workspace chat: approved $50.00 report plus new Outstanding report holding A1 $100.00
✅
3. "Approve <full amount>" approves the whole report including the held expenseReport B ($200 held + $75). Picking Approve $275.00 flipped the header to Pay $275.00 / Approved, kept both expenses on the report, added an "approved" action and cleared the hold ("You: unheld this expense").
Report B approved in full: Pay $275.00, Approved badge, both expenses present, hold cleared
✅
4. RECHECK — chat report-preview card Approve opens the same dropdown, no "Confirm payment amount" modal, and actually approvesReport C ($300 held + $25). The card's Approve opened the same held-expense dropdown with Approve only $25.00 / Approve $325.00 — no payment modal, no silent close. Approve only $25.00 really approved (card became Pay $25.00, report badged Approved, POST /api/ApproveMoneyRequest returned 200). The full option was also exercised from a card and approved correctly.
Chat report-preview card Approve opens the held-expense dropdown - no payment modal
After 'Approve only $25.00' from the card: card shows Pay $25.00, held C1 split into a new Outstanding report
Report C header badge 'Approved' with Pay $25.00 and C2 marked Approved
Full 'Approve $300.00' chosen from a preview card: report badge flips to Approved
✅
5. A report where every expense is held shows only the full "Approve" option and does not approve silentlyReport D ($10 + $20, both held) showed "All expenses are on hold. Approve anyway?" with a single Approve $30.00 option — no "Approve only", and nothing was approved until it was picked. Observation, not a failure: on the report page header of an all-held report the primary button is "Remove hold" and Approve is absent from the header and its More menu, so this dropdown is only reachable from the chat preview card.
2-expense all-held report: dropdown shows only 'Approve $30.00' under 'All expenses are on hold. Approve anyway?'
All-held report preview card dropdown with the single 'Approve $300.00' option
All-held report page header shows 'Remove hold' as the primary action, with no Approve button
✅
6. No errors appear in the JS consoleConsole capture isn't exposed on the web agent-device platform, so this was checked indirectly: a 200-entry network dump across the run had zero non-200 responses (every ApproveMoneyRequest, HoldRequest and OpenReport returned 200), and no error banners, RBR badges or failure toasts appeared.
✅
Code-level confirmation of the three previous findings
  • Blocker (preview-card approve did nothing) — fixed as recommended. useConfirmApproveReportAction.ts has no hasHeldExpenses / onHoldMenuOpen branch left; it takes full from the dropdown and passes it straight to approveMoneyRequest.
  • shouldCallOnSelectedForSubMenuItem — gone. grep -rn 'shouldCallOnSelectedForSubMenuItem' src returns nothing.
  • shouldShowMarkAsDoneCopy ignored in the dropdown branch — moot. The prop no longer exists on ExpenseHeaderApprovalButton, and since the file is new in this PR there's nothing on main to regress against.
  • requestType / isApprove are not dead — src/hooks/useHoldMenuSubmit.ts is no longer in the PR diff, and Search.ts:371 still opens the hold menu with REPORT_ACTION_TYPE.APPROVE, so HoldMenuModalWrapper still renders the approve copy for the Search/Spends page. That matches the agreed scope of leaving Search on the modal.
  • Translations — confirmApprovalWithHeldAmount / confirmApprovalAllHoldAmount / approveOnly are correct in all locales, including the nl / pl / pt-BR files that previously carried Japanese copy.

view run · no recording available

@parasharrajat

Copy link
Copy Markdown
Member

Looks pretty good to me now.

@parasharrajat

parasharrajat commented Sep 6, 2026 •

Copy link
Copy Markdown
Member

BUG: Bulk menu on android show the header text above back arrow.

Steps:

  1. On native app, Select all expense.
  2. Click selected dropdown then approve option.
image

@mkzie2

mkzie2 commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

@parasharrajat I updated 👍

@parasharrajat

Copy link
Copy Markdown
Member

I see no changes @mkzie2

@mkzie2

mkzie2 commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

@parasharrajat I got an connection error earlier with git without realized, just pushed now.

})}
isSplitButton={false}
shouldAlwaysShowDropdownMenu
shouldPutHeaderTextAfterBackButton

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it OK to pass this prop for all options? or should we just add it for approval menu

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parasharrajat I think it's fine to remove the prop, I added it earlier to fix a bug but is no longer the case now. WHat do you think?

@parasharrajat

Copy link
Copy Markdown
Member

Looks good.

@parasharrajat parasharrajat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots

🔲 iOS / native

🔲 iOS / Safari

06.09.2026_14.44.39_REC.mp4

🔲 MacOS / Chrome

06.09.2026_14.30.22_REC.mp4

🔲 Android / native

06.09.2026_14.58.48_REC.mp4
08.09.2026_20.41.43_REC.mp4

🎀 👀 🎀 C+ reviewed

@melvin-bot
melvin-bot Bot requested a review from marcochavezf September 8, 2026 15:14

@marcochavezf marcochavezf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcochavezf
marcochavezf merged commit 226ed5c into Expensify:main Sep 8, 2026
38 of 43 checks passed
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚧 marcochavezf has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Sep 8, 2026
69 tasks done
@OSBotify

OSBotify commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.4.74-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Yes — one help site article needed an update, and the draft PR is up: #100636

What changed in the product: clicking Approve on a report with held expenses no longer opens a confirmation modal. It now opens a dropdown menu anchored to the Approve button, and the copy in that menu changed (iou.confirmApprovalAmount → iou.confirmApprovalWithHeldAmount, and iou.confirmApprovalAllHoldAmount dropped its plural forms).

What the docs said: docs/articles/new-expensify/reports-and-expenses/Approve-Expenses.md:47 described "a confirmation modal with two options". That is now wrong.

The two option labels already documented — Approve only [non-held amount] and Approve [full amount] — are still correct, so the edit is scoped to the interaction, plus a note that the same dropdown appears on the report preview in a chat and a non-rendered screenshot suggestion.

How I verified the labels

I ran the flow on web against this PR's branch: created two expenses in a workspace chat, submitted, held one, then opened Approve on the report header.

  • Menu header: Report contains held expenses. Approve only compliant expenses, or approve the entire report?
  • Options: Approve only $40.00 (non-held total) and Approve $65.00 (full total)
  • It renders as a popover anchored under the Approve button, not a centered modal
Approve dropdown menu with held-expense explanation and two approval amounts

I could not reach the all-held approver state on the test account, so the "only Approve [full amount] is available" line is carried over from the existing article and matches ExpenseHeaderApprovalButton.tsx (hasOnlyHeldExpenses skips the partial option) rather than a live run. Worth a second look when you review.

No other article under docs/articles documents this flow.

One thing I couldn't do: GitHub rejected assigning you to the docs PR (mkzie2 has no push access on Expensify/App, so the assignment is silently dropped). The HelpDot label is applied and Expensify/pullerbear is requested as reviewer.

@mkzie2, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #100639 was identified to be related to this PR.

@OSBotify

OSBotify commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.74-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants