You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-09-16] [$250] Expenses are approved and unheld without confirmation when report contains all held expenses #83261
Version Number: 9.3.25-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#70825 Email or phone of affected tester (no customers):jsodjsodnjoisjdosij@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Create two expenses.
Open the expense report.
Hold both expenses.
Go back to workspace chat.
Click Submit button.
Click Approve button.
Expected Result:
Confirmation modal will show up because report contains held expenses.
Actual Result:
There is no confirmation modal when report contains held expenses.
The report is approved directly and expenses are unheld without confirmation.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #70825 - "Clarify Approval Options When Held Expenses Exist" by @mkzie2 (High confidence) Related Issues: N/A
Recommendation: REVERT
PR #70825 introduced a regression where the confirmation modal is no longer shown when approving reports that contain ALL held expenses. The PR attempted to clarify approval options by creating a new ExpenseHeaderApprovalButton component, but the logic incorrectly skips the confirmation modal when hasOnlyHeldExpenses = true.
Labels: Keeping DeployBlockerCash (App PR caused the issue), will remove DeployBlocker (not a backend issue)
📋 Detailed Analysis
Evidence
The bug is reproducible only on staging (v9.3.25-0) and not in production, and PR #70825 was merged in this staging release. The reproduction steps exactly match the scenario this PR was designed to handle (held expenses during approval).
/home/runner/_work/App/App/src/components/MoneyReportHeader.tsx (modified to use new component)
Confirmation that PR #70825 modified these files:
The PR diff shows it created ExpenseHeaderApprovalButton.tsx and refactored the approval logic in MoneyReportHeader.tsx to use this new component.
Root Cause
Before PR #70825:
When approving a report with held expenses, the code would set isHoldMenuVisible(true) to show the ProcessMoneyReportHoldMenu confirmation modal for ALL cases where isAnyTransactionOnHold === true.
After PR #70825:
The new ExpenseHeaderApprovalButton component has flawed logic at line 122:
if(approvalOptions.length>1){return<ButtonWithDropdownMenu ... />}// Falls through to simple Button without confirmationreturn<ButtononPress={()=>onApprove(true)} ... />
The problem is in getApprovalDropdownOptions() (lines 73-81):
if(nonHeldAmount&&hasValidNonHeldAmount&&!hasOnlyHeldExpenses){options.push({/* partial approval option */});}options.push({/* full approval option */});
When hasOnlyHeldExpenses = true:
Only the full approval option is added
approvalOptions.length = 1
The condition approvalOptions.length > 1 is false
A simple Button is rendered instead of the dropdown
This Button directly calls onApprove(true) without any confirmation modal
The old code would always show a confirmation modal when isAnyTransactionOnHold was true, regardless of whether some or all expenses were held.
📣 @mkzie2 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.74-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-09-16. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
changed the title [-][$250] Expenses are approved and unheld without confirmation when report contains all held expenses[/-][+][Due for payment 2026-09-16] [$250] Expenses are approved and unheld without confirmation when report contains all held expenses[/+]on Sep 9, 2026
Activity
melvin-bot commentedon Feb 23, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #70825
melvin-bot commentedon Feb 23, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Feb 23, 2026
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Feb 23, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Feb 23, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #70825 - "Clarify Approval Options When Held Expenses Exist" by @mkzie2 (High confidence)
Related Issues: N/A
Recommendation: REVERT
PR #70825 introduced a regression where the confirmation modal is no longer shown when approving reports that contain ALL held expenses. The PR attempted to clarify approval options by creating a new
ExpenseHeaderApprovalButtoncomponent, but the logic incorrectly skips the confirmation modal whenhasOnlyHeldExpenses = true.Labels: Keeping
DeployBlockerCash(App PR caused the issue), will removeDeployBlocker(not a backend issue)📋 Detailed Analysis
Evidence
The bug is reproducible only on staging (v9.3.25-0) and not in production, and PR #70825 was merged in this staging release. The reproduction steps exactly match the scenario this PR was designed to handle (held expenses during approval).
Verification
Files affected by the bug:
/home/runner/_work/App/App/src/components/ExpenseHeaderApprovalButton.tsx(new file created in PR Clarify Approval Options When Held Expenses Exist #70825)/home/runner/_work/App/App/src/components/MoneyReportHeader.tsx(modified to use new component)Confirmation that PR #70825 modified these files:
The PR diff shows it created
ExpenseHeaderApprovalButton.tsxand refactored the approval logic inMoneyReportHeader.tsxto use this new component.Root Cause
Before PR #70825:
When approving a report with held expenses, the code would set
isHoldMenuVisible(true)to show theProcessMoneyReportHoldMenuconfirmation modal for ALL cases whereisAnyTransactionOnHold === true.After PR #70825:
The new
ExpenseHeaderApprovalButtoncomponent has flawed logic at line 122:The problem is in
getApprovalDropdownOptions()(lines 73-81):When
hasOnlyHeldExpenses = true:approvalOptions.length = 1approvalOptions.length > 1is falseonApprove(true)without any confirmation modalThe old code would always show a confirmation modal when
isAnyTransactionOnHoldwas true, regardless of whether some or all expenses were held.14 remaining items
melvin-bot commentedon Feb 24, 2026
📣 @mkzie2 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
melvin-bot commentedon Feb 24, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
marcochavezf commentedon Feb 24, 2026
Requested retest here https://expensify.slack.com/archives/C09V78U42D8/p1771955096822289
m-natarajan commentedon Feb 24, 2026
Issue is not reproducible, Windows 10 / Chrome, v9.3.25-9
Repro83261Web.mp4
jponikarchuk commentedon Sep 8, 2026
Deploy Blocker #100639 was identified to be related to the PR #83667 that attempted to fix this issue.
melvin-bot commentedon Sep 8, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Sep 9, 2026
@marcochavezf @mkzie2
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.74-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-09-16. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
[-][$250] Expenses are approved and unheld without confirmation when report contains all held expenses[/-][+][Due for payment 2026-09-16] [$250] Expenses are approved and unheld without confirmation when report contains all held expenses[/+]