You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-29] [$250] Report - Cannot change report titles in NewDot #84555
Version Number: Reproducible in staging?: Needs Reproduction (All the steps described in the issue were followed, but the bug did not occur) Reproducible in production?: Needs Reproduction (All the steps described in the issue were followed, but the bug did not occur) If this was caught during regression testing, add the test name, ID and link from BrowserStack: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@GeoVasile Slack conversation (hyperlinked to channel name): expensify_bugs
Action Performed:
Open the report
Click on the report title
Click on the report title again
Expected Result:
This should allow the user to change it
Actual Result:
They receive an "It's not here" error
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Please re-state the problem that we are trying to solve in this issue.
When a user opens an expense report and clicks the report title (to edit it), they see the "Hmm... it's not here" error page instead of the title edit form. This happens on certain workspace configurations where the title field is absent from the policy's field list.
What is the root cause of that problem?
The canEditReportTitle function in App/src/libs/ReportUtils.ts:4511-4516 does not verify that a title field was actually found before returning true:
functioncanEditReportTitle(report,policy){consttitleField=getAvailableReportFields(report,Object.values(policy?.fieldList??{})).find(isReportFieldOfTypeTitle);constisFieldDisabled=isReportFieldDisabled(report,titleField,policy);// ^^^^^^^^^^// titleField can be undefined here, but isReportFieldDisabled(report, undefined, policy)// returns false for non-settled/non-closed expense reports — so the function returns true// even though there is no title field to edit.return!isFieldDisabled&&isAdminOwnerApproverOrReportOwner(report,policy)&&isExpenseReport(report)&&isPaidGroupPolicyPolicyUtils(policy);}
When titleField is undefined, isReportFieldDisabled(report, undefined, policy) falls through its checks and returns false (because isReportFieldOfTypeTitle(undefined) is false, and undefined?.type === FORMULA is also false). So canEditReportTitle returns true even when no title field exists.
This causes the edit button (pencil icon on wide screens) or the clickable title on the report details page to appear. When the user clicks through to EditReportFieldPage, the page tries to look up the title field from report.fieldList and policy.fieldList. Since neither has it, the fallback at getTitleFieldWithFallback returns undefined (because the policy has other fields, so isPolicyFieldListEmpty returns false). The guard at line 80 fires (!reportField is true) and the "It's not here" page is shown.
This explains why the bug is customer-specific and hard to reproduce — it requires a paid group policy where the title field (text_title) is absent from the field list while other custom report fields exist.
What changes do you think we should make in order to solve the problem?
Add a !!titleField check to canEditReportTitle in App/src/libs/ReportUtils.ts:
This prevents the edit button/link from appearing when there is no title field, so the user never navigates to EditReportFieldPage in a state that will show "It's not here".
What alternative solutions did you explore? (Optional)
Fix EditReportFieldPage to handle missing title field gracefully — e.g., always use FALLBACK_TITLE_FIELD even when the policy has other fields. This would let users edit the title regardless of policy configuration, but it may not match intended behavior if an admin intentionally removed the title field.
Fix isReportFieldDisabled to return true for undefined fields — This would be more defensive but could have unintended side effects in other callers that pass undefined fields.
The proposed fix (option in the main section) is the most targeted and safe approach.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
Please re-state the problem that we are trying to solve in this issue.
When a user opens an expense report on a paid group policy workspace and clicks the report title to edit it, they are navigated to the edit page which shows an "It's not here" error instead of the title edit form. This prevents users from changing expense report titles in NewDot.
What is the root cause of that problem?
The canEditReportTitle function does not verify that a title field actually exists before determining editability.
When titleField is undefined (i.e., the policy's fieldList does not contain a title field), isReportFieldDisabled(report, undefined, policy) returns false because isReportFieldOfTypeTitle(undefined) is false, so it skips the title-specific check, and undefined?.type === FORMULA is also false.
This means canEditReportTitle returns true even when no title field exists in the policy. The report details page then renders an interactive/clickable title that navigates to EditReportFieldPage. On that page, the title field lookup fails — report.fieldList and policy.fieldList both lack the field, and getTitleFieldWithFallback returns undefined because the policy has other fields (so isPolicyFieldListEmpty is false).
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.79-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@aimane-chnaif@mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
The offending PR is #80254 — "[No QA] Allow editing report titles if title field is missing", merged on 2026-02-11.
That PR introduced getTitleFieldWithFallback and modified canEditReportTitle but didn't guard against titleField being undefined when the policy has other custom fields but no text_title entry, which is the exact condition that causes the "It's not here" error.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Mar 9, 2026
Triggered auto assignment to @lydiabarclay (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.MelvinBot commentedon Mar 9, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user opens an expense report and clicks the report title (to edit it), they see the "Hmm... it's not here" error page instead of the title edit form. This happens on certain workspace configurations where the title field is absent from the policy's field list.
What is the root cause of that problem?
The
canEditReportTitlefunction inApp/src/libs/ReportUtils.ts:4511-4516does not verify that a title field was actually found before returningtrue:When
titleFieldisundefined,isReportFieldDisabled(report, undefined, policy)falls through its checks and returnsfalse(becauseisReportFieldOfTypeTitle(undefined)isfalse, andundefined?.type === FORMULAis alsofalse). SocanEditReportTitlereturnstrueeven when no title field exists.This causes the edit button (pencil icon on wide screens) or the clickable title on the report details page to appear. When the user clicks through to
EditReportFieldPage, the page tries to look up the title field fromreport.fieldListandpolicy.fieldList. Since neither has it, the fallback atgetTitleFieldWithFallbackreturnsundefined(because the policy has other fields, soisPolicyFieldListEmptyreturnsfalse). The guard at line 80 fires (!reportFieldistrue) and the "It's not here" page is shown.This explains why the bug is customer-specific and hard to reproduce — it requires a paid group policy where the title field (
text_title) is absent from the field list while other custom report fields exist.What changes do you think we should make in order to solve the problem?
Add a
!!titleFieldcheck tocanEditReportTitleinApp/src/libs/ReportUtils.ts:This prevents the edit button/link from appearing when there is no title field, so the user never navigates to
EditReportFieldPagein a state that will show "It's not here".What alternative solutions did you explore? (Optional)
Fix
EditReportFieldPageto handle missing title field gracefully — e.g., always useFALLBACK_TITLE_FIELDeven when the policy has other fields. This would let users edit the title regardless of policy configuration, but it may not match intended behavior if an admin intentionally removed the title field.Fix
isReportFieldDisabledto returntrueforundefinedfields — This would be more defensive but could have unintended side effects in other callers that passundefinedfields.The proposed fix (option in the main section) is the most targeted and safe approach.
Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.melvin-bot commentedon Mar 9, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (
External)melvin-bot commentedon Mar 9, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022030962642924822963
[-]Report - Cannot change report titles in NewDot[/-][+][$250] Report - Cannot change report titles in NewDot[/+]mukhrr commentedon Mar 9, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user opens an expense report on a paid group policy workspace and clicks the report title to edit it, they are navigated to the edit page which shows an "It's not here" error instead of the title edit form. This prevents users from changing expense report titles in NewDot.
What is the root cause of that problem?
The
canEditReportTitlefunction does not verify that a title field actually exists before determining editability.App/src/libs/ReportUtils.ts
Lines 4511 to 4516 in 43a57cf
When
titleFieldisundefined(i.e., the policy'sfieldListdoes not contain a title field),isReportFieldDisabled(report, undefined, policy)returnsfalsebecauseisReportFieldOfTypeTitle(undefined)isfalse, so it skips the title-specific check, andundefined?.type === FORMULAis alsofalse.App/src/libs/ReportUtils.ts
Lines 4472 to 4490 in 43a57cf
This means
canEditReportTitlereturnstrueeven when no title field exists in the policy. The report details page then renders an interactive/clickable title that navigates toEditReportFieldPage. On that page, the title field lookup fails —report.fieldListandpolicy.fieldListboth lack the field, andgetTitleFieldWithFallbackreturnsundefinedbecause the policy has other fields (soisPolicyFieldListEmptyisfalse).App/src/libs/ReportUtils.ts
Lines 4528 to 4539 in 43a57cf
The guard on line 80 of
EditReportFieldPagethen fires (!reportFieldistrue) and rendersFullPageNotFoundView.App/src/pages/EditReportFieldPage.tsx
Lines 80 to 89 in 43a57cf
What changes do you think we should make in order to solve the problem?
!!titleFieldguard tocanEditReportTitleso the edit UI is only shown when a title field actually exists in the policy:App/src/libs/ReportUtils.ts
Lines 4511 to 4516 in 43a57cf
This is a one-line fix that prevents the clickable title from appearing when there is no title field to edit, so users never reach the not-found page.
MelvinBot commentedon Mar 9, 2026
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
72 remaining items
melvin-bot commentedon May 22, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.79-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-29. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 22, 2026
@aimane-chnaif @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
aimane-chnaif commentedon May 25, 2026
@MelvinBot What is offending PR?
MelvinBot commentedon May 25, 2026
The offending PR is #80254 — "[No QA] Allow editing report titles if title field is missing", merged on 2026-02-11.
That PR introduced
getTitleFieldWithFallbackand modifiedcanEditReportTitlebut didn't guard againsttitleFieldbeingundefinedwhen the policy has other custom fields but notext_titleentry, which is the exact condition that causes the "It's not here" error.aimane-chnaif commentedon May 25, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: [No QA] Allow editing report titles if title field is missing #80254 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/642784
Regression Test Proposal
Test:
text_title)Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-8c05-abb4-6db4-c23c4f5d36b4melvin-bot commentedon May 28, 2026
Current assignee @mallenexpensify is eligible for the Awaiting Payment assigner, not assigning anyone new.
mallenexpensify commentedon May 29, 2026
Payment Summary
Contributor+: @aimane-chnaif paid $250 via Upwork
^ Test case created. Thx