Repository navigation
[No QA] Allow editing report titles if title field is missing - #80254
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve import conflict in ReportNameUtils.ts — keep getPolicy and isPolicyFieldListEmpty imports needed for fallback title field. Co-authored-by: Cursor <cursoragent@cursor.com>
The test file directly tests computeReportName, so the restricted import is intentional and necessary. Co-authored-by: Cursor <cursoragent@cursor.com>
Main removed the usage of getPolicy from this file; the import was left over from the merge conflict resolution. Co-authored-by: Cursor <cursoragent@cursor.com>
The merge resolution accidentally committed a stale submodule reference. Reset to main's current version. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@neil-marcellini Anything major changed from my last review ? |
Not really, but I did use AI to update it so probably worth skimming over all changes again. |
ikevin127
left a comment
There was a problem hiding this comment.
Checked all new commits since my last review - everything looks good ✅
|
@puneetlath Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/cristipaval in version: 9.3.18-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.18-8 🚀
|
|
That PR introduced |
Explanation of Change
There are some policies that have an empty fieldList, so they don't have a report title field. In OldDot there is a fallback title field with the formula simply being "New Report". Some users are used to that, and when reports are created the manually update the name. However in NewDot we don't have that fallback, and we incorrectly block updating the report name/title. Now the fallback title field has been added as needed and users are able to manually edit it. The solution works with and without the frontend custom report names beta.
For more context, see this comment (requires org access).
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/591539
PROPOSAL: N/A
Tests
Set up
Default title displays
2026-01-23_09-05-57.mp4
Offline empty report beta enabled
2026-01-23_09-20-43.mp4
Note: There is an API writes error shown in the video, but it also occurs on main. I will make sure to get that ignored. Here's proof.
2026-01-23_09-14-33.mp4
Offline empty report beta disabled
2026-01-23_09-19-10.mp4
Offline new expense report beta enabled
2026-01-23_09-08-50.mp4
Offline new expense report beta disabled
2026-01-23_09-22-58.mp4
Offline convert IOU report to expense report beta disabled
2026-01-23_15-18-22.mp4
Offline convert IOU report to expense report beta enabled
2026-01-23_15-19-49.mp4
Offline tests
See above. If it works offline, then it also works smoothly while online
QA Steps
[No QA] - only applicable to specific accounts. We'll check with the customer that reported the bug to verify it's fixed.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
N/A see above, changes are platform independent
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari