Skip to content

[No QA] Allow editing report titles if title field is missing - #80254

Merged
cristipaval merged 54 commits into
mainfrom
neil-fix-uneditable-title
Feb 11, 2026
Merged

cristipaval merged 54 commits into
mainfrom
neil-fix-uneditable-title

Conversation

@neil-marcellini

@neil-marcellini neil-marcellini commented Jan 22, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

There are some policies that have an empty fieldList, so they don't have a report title field. In OldDot there is a fallback title field with the formula simply being "New Report". Some users are used to that, and when reports are created the manually update the name. However in NewDot we don't have that fallback, and we incorrectly block updating the report name/title. Now the fallback title field has been added as needed and users are able to manually edit it. The solution works with and without the frontend custom report names beta.

For more context, see this comment (requires org access).

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/591539
PROPOSAL: N/A

Tests

Set up

  1. Check out and build the Auth PR
  2. Log in with any account
  3. Create a new workspace
  4. Run this query to clear the fieldList, with an updated policyID
UPDATE nameValuePairs
SET value = JSONB_SET(value, '$.fieldList', JSON('[]'))
WHERE name = 'expensify_policy06B2473A9C794F0B';

Default title displays

  1. Go to workspace settings > Reports
  2. Verify the default title displays as "New Report"
  3. Click to edit it
  4. Verify the text input is filled with "New Report"
2026-01-23_09-05-57.mp4

Offline empty report beta enabled

  1. Hard code the custom report names beta enabled as shown here
  2. Go to the policy expense chat
  3. Open the debug menu (command + d) and enable force offline
  4. Create an empty report
  5. Verify the name is "New Report" in the preview
  6. Open the report, verify the same name displays
  7. Click on the header and the title menu item
  8. Verify the title edit page opens with the current title
  9. exit out back to the policy expense chat
  10. Go back online
  11. Verify the report name remains
  12. Manually update the report name and verify it works
2026-01-23_09-20-43.mp4

Note: There is an API writes error shown in the video, but it also occurs on main. I will make sure to get that ignored. Here's proof.

2026-01-23_09-14-33.mp4
  • ignore API write update error for report name update

Offline empty report beta disabled

  1. Hard code the beta disabled
  2. Run the same test as above
2026-01-23_09-19-10.mp4

Offline new expense report beta enabled

  1. Delete all reports on the workspace
  2. Run the same test as "Offline empty report beta enabled", but create an expense instead of a report while offline
2026-01-23_09-08-50.mp4

Offline new expense report beta disabled

  1. Hard code the beta disabled
  2. Run the same test as above
2026-01-23_09-22-58.mp4

Offline convert IOU report to expense report beta disabled

  1. Go offline
  2. Create an expense report
  3. submit it to an individual
  4. Open the IOU report
  5. Verify the title can't be edited
  6. Change the workspace
  7. Verify the title updates to New Report
  8. Verify it can be edited
  9. Go online
  10. Verify the title persists and then can be edited
2026-01-23_15-18-22.mp4

Offline convert IOU report to expense report beta enabled

  1. Run the same test above but with the beta enabled
2026-01-23_15-19-49.mp4
  • Verify that no errors appear in the JS console

Offline tests

See above. If it works offline, then it also works smoothly while online

QA Steps

[No QA] - only applicable to specific accounts. We'll check with the customer that reported the bug to verify it's fixed.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

N/A see above, changes are platform independent

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@neil-marcellini neil-marcellini self-assigned this Jan 22, 2026
@codecov

codecov Bot commented Jan 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 87.39% <ø> (ø)
src/libs/PolicyUtils.ts 57.69% <100.00%> (+0.22%) ⬆️
src/libs/ReportNameUtils.ts 80.00% <100.00%> (+0.17%) ⬆️
src/pages/ReportDetailsPage.tsx 56.86% <75.00%> (+0.42%) ⬆️
...rc/pages/workspace/reports/ReportsDefaultTitle.tsx 0.00% <0.00%> (ø)
src/libs/actions/Report/index.ts 61.90% <71.42%> (+0.07%) ⬆️
...c/pages/workspace/reports/WorkspaceReportsPage.tsx 0.00% <0.00%> (ø)
src/libs/ReportUtils.ts 74.72% <68.18%> (-0.08%) ⬇️
src/pages/EditReportFieldPage.tsx 0.00% <0.00%> (ø)
... and 13 files with indirect coverage changes

@neil-marcellini neil-marcellini changed the title Allow editing report titles if title field is missing [HOLD Auth 19427] Allow editing report titles if title field is missing Jan 23, 2026
@neil-marcellini neil-marcellini changed the title [HOLD Auth 19427] Allow editing report titles if title field is missing [HOLD Auth 19427][No QA] Allow editing report titles if title field is missing Jan 23, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
neil-marcellini and others added 2 commits February 10, 2026 17:45
Resolve import conflict in ReportNameUtils.ts — keep getPolicy
and isPolicyFieldListEmpty imports needed for fallback title field.

Co-authored-by: Cursor <cursoragent@cursor.com>
The test file directly tests computeReportName, so the restricted
import is intentional and necessary.

Co-authored-by: Cursor <cursoragent@cursor.com>
Main removed the usage of getPolicy from this file; the import
was left over from the merge conflict resolution.

Co-authored-by: Cursor <cursoragent@cursor.com>
The merge resolution accidentally committed a stale submodule
reference. Reset to main's current version.

Co-authored-by: Cursor <cursoragent@cursor.com>
@ikevin127

Copy link
Copy Markdown
Contributor

@neil-marcellini Anything major changed from my last review ?

@neil-marcellini

Copy link
Copy Markdown
Contributor Author

@neil-marcellini Anything major changed from my last review ?

Not really, but I did use AI to update it so probably worth skimming over all changes again.

@ikevin127 ikevin127 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked all new commits since my last review - everything looks good ✅

@melvin-bot
melvin-bot Bot requested a review from puneetlath February 11, 2026 02:42
@melvin-bot

melvin-bot Bot commented Feb 11, 2026

Copy link
Copy Markdown

@puneetlath Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@cristipaval
cristipaval merged commit b46dee1 into main Feb 11, 2026
34 checks passed
@cristipaval
cristipaval deleted the neil-fix-uneditable-title branch February 11, 2026 10:08
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.3.18-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.18-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@aimane-chnaif

Copy link
Copy Markdown
Contributor

That PR introduced getTitleFieldWithFallback and modified canEditReportTitle but didn't guard against titleField being undefined when the policy has other custom fields but no text_title entry.
So this caused bug - Report - Cannot change report titles in NewDot.
While report title in header has edit button, not found page showed when open it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants