Skip to content

[Due for payment 2026-11-20] [$175] Remove Hermes sampling profiler patches after RN 0.85 upgrade #86571

Open

Description

@Julesssss

After upgrading React Native to 0.85.x, we can remove the Hermes sampling profiler patches applied in #84708.

Patches

  • Patch 031 (react-native+0.83.1+031+fix-hermes-sampling-profiler-disable.patch) — Fixes JNI copy-paste bug where disable was mapped to enable. Fixed upstream in facebook/react-native#56174, merged to main, shipping in RN 0.85.x.

  • Patch 032 (react-native+0.83.1+032+fix-hermes-sampling-profiler-pthread-kill-crash.patch) — Replaces pthread_kill with tgkill syscall on Android to avoid SIGABRT on stale pthread_t. Not yet fixed upstream — Hermes still uses pthread_kill. However, with patch 031 fixed the crash becomes much harder to trigger since the root cause was the profiler never being disabled. Evaluate whether this patch is still needed after the upgrade, or push for an upstream fix.

Action

  1. Upgrade to RN 0.85.x
  2. Remove patch 031 (confirmed fixed upstream)
  3. Test whether the SIGABRT crash reproduces without patch 032 — if not, remove it too
  4. If it does reproduce, keep patch 032 and consider upstreaming to facebook/hermes

Related

Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @mallenexpensify
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. self-assigned this
    on Mar 27, 2026
  2. Julesssss commented on Apr 28, 2026

    @Julesssss
    ContributorAuthor

    Check again next month

  3. Julesssss commented on Jun 1, 2026

    @Julesssss
    ContributorAuthor

    @staging-melvinbot what are we waiting for here?

  4. Julesssss commented on Jun 1, 2026

    @Julesssss
    ContributorAuthor

    Oh Melvin isn't available in App... This PR is what we're waiting on, the 0.85.X bump

  5. Julesssss commented on Jul 7, 2026

    @Julesssss
    ContributorAuthor

    We're getting close to merging the RN bump!

  6. 22 remaining items

  7. changed the title [-][$175] Remove Hermes sampling profiler patches after RN 0.85 upgrade[/-] [+][Due for payment 2026-11-20] [$175] Remove Hermes sampling profiler patches after RN 0.85 upgrade[/+] on Nov 13, 2026
  8. melvin-bot commented on Nov 13, 2026

    @melvin-bot

    @aimane-chnaif / @situchan

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.37-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-11-20. 🎊

  9. expensify-chore-bot commented on Nov 18, 2026

    @expensify-chore-bot

    @aimane-chnaif Huh... This is 4 days overdue. Who can take care of this?

  10. expensify-chore-bot commented on Nov 19, 2026

    @expensify-chore-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  11. expensify-chore-bot commented on Nov 19, 2026

    @expensify-chore-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  12. mallenexpensify commented on Nov 21, 2026

    @mallenexpensify
    Contributor

    Claude posting on behalf of Matt:

    Waiting on C+ checklist from @situchan.

    Job price: $175 (standard, no Help Wanted, assigned 2026-11-09). aimane-chnaif (Contributor): 100%, via NewDot. situchan (C+): 100%, via NewDot.

    No deploy blockers or regressions on the issue or the PR.

    Evidence
    • PR 106548: by aimane-chnaif, merged 2026-11-11, production 2026-11-13, approved by Julesssss and situchan. No revert.
    • Test videos: author 1/5, C+ 1/5.

    PAYPREP v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorInternalRequires API changes or must be handled by Expensify staffTaskWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions