You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-11-20] [$175] Remove Hermes sampling profiler patches after RN 0.85 upgrade #86571
After upgrading React Native to 0.85.x, we can remove the Hermes sampling profiler patches applied in #84708.
Patches
Patch 031 (react-native+0.83.1+031+fix-hermes-sampling-profiler-disable.patch) — Fixes JNI copy-paste bug where disable was mapped to enable. Fixed upstream in facebook/react-native#56174, merged to main, shipping in RN 0.85.x.
Patch 032 (react-native+0.83.1+032+fix-hermes-sampling-profiler-pthread-kill-crash.patch) — Replaces pthread_kill with tgkill syscall on Android to avoid SIGABRT on stale pthread_t. Not yet fixed upstream — Hermes still uses pthread_kill. However, with patch 031 fixed the crash becomes much harder to trigger since the root cause was the profiler never being disabled. Evaluate whether this patch is still needed after the upgrade, or push for an upstream fix.
Action
Upgrade to RN 0.85.x
Remove patch 031 (confirmed fixed upstream)
Test whether the SIGABRT crash reproduces without patch 032 — if not, remove it too
If it does reproduce, keep patch 032 and consider upstreaming to facebook/hermes
Related
#85860 — Upstream Hermes patches for Android SIGABRT crash fix
changed the title [-][$175] Remove Hermes sampling profiler patches after RN 0.85 upgrade[/-][+][Due for payment 2026-11-20] [$175] Remove Hermes sampling profiler patches after RN 0.85 upgrade[/+]on Nov 13, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.37-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
Julesssss commentedon Apr 28, 2026
Check again next month
Julesssss commentedon Jun 1, 2026
@staging-melvinbot what are we waiting for here?
Julesssss commentedon Jun 1, 2026
Oh Melvin isn't available in App... This PR is what we're waiting on, the
0.85.XbumpJulesssss commentedon Jul 7, 2026
We're getting close to merging the RN bump!
22 remaining items
[-][$175] Remove Hermes sampling profiler patches after RN 0.85 upgrade[/-][+][Due for payment 2026-11-20] [$175] Remove Hermes sampling profiler patches after RN 0.85 upgrade[/+]melvin-bot commentedon Nov 13, 2026
@aimane-chnaif / @situchan
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.37-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-20. 🎊
expensify-chore-bot commentedon Nov 18, 2026
@aimane-chnaif Huh... This is 4 days overdue. Who can take care of this?
expensify-chore-bot commentedon Nov 19, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)expensify-chore-bot commentedon Nov 19, 2026
Payment Summary
Resolving PRs:
Remove Hermes sampling profiler pthread_kill patch #106548
Reviewer: @aimane-chnaif owed $175 via NewDot
Reviewer: @situchan owed $175 via NewDot
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Nov 21, 2026
Claude posting on behalf of Matt:
Waiting on C+ checklist from @situchan.
Job price: $175 (standard, no Help Wanted, assigned 2026-11-09). aimane-chnaif (Contributor): 100%, via NewDot. situchan (C+): 100%, via NewDot.
No deploy blockers or regressions on the issue or the PR.
Evidence
PAYPREP v1