Skip to content

[Sentry] enable android profiling - #84708

Merged
Julesssss merged 17 commits into
Expensify:mainfrom
callstack-internal:eliran/sentry-enable-android-profiling
Mar 19, 2026
Merged

Julesssss merged 17 commits into
Expensify:mainfrom
callstack-internal:eliran/sentry-enable-android-profiling

Conversation

@elirangoshen

@elirangoshen elirangoshen commented Mar 10, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change
Fixes Android SIGABRT crash (invalid pthread_t passed to pthread_kill in hermes-sampling thread) that occurs when Sentry Hermes profiling is enabled (profilesSampleRate > 0).

Two root causes were identified and fixed via React Native patches:

Patch 030 — JNI copy-paste bug fix

In HermesSamplingProfiler.cpp, the JNI disable method was incorrectly mapped to HermesSamplingProfiler::enable instead of HermesSamplingProfiler::disable. When Sentry called disable() to stop profiling, it actually called enable() again, corrupting the sampling thread state.

Patch 031 — Replace pthread_kill with tgkill on Android

On Android (Bionic libc), pthread_kill with an invalid pthread_t (e.g., thread has exited) calls abort() instead of returning ESRCH like glibc. The Hermes sampling profiler sends SIGPROF via pthread_kill at ~100Hz. If a runtime thread exits while profiling is active, the stale pthread_t triggers the SIGABRT.

This patch replaces pthread_kill with the tgkill syscall on Android, which safely returns ESRCH for dead threads.

The patch is applied via a doLast Gradle hook on unzipHermes because that task downloads fresh Hermes source, overwriting any direct source patches.

Fixed Issues
$ #75036
$ #85860

Tests
[x] Verify that no errors appear in the JS console

  1. Install a staging build on an Android device
  2. Log in and use the app normally for 2-3 minutes (navigate between screens, open chats, etc.)
  3. Verify the app does not crash with Fatal signal 6 (SIGABRT) in logcat
  4. Check logcat: adb logcat | grep -i "hermes-sampling" — the thread should be running without crashes
  5. (Optional) Enable Sentry debug mode and verify Integration installed: HermesProfiling appears in logs and profiling data is being sent
  6. Verify that no errors appear in the JS console

Offline tests
N/A — this is a native-level fix that doesn't affect offline behavior.

QA Steps

  1. Install a staging build on an Android device
  2. Log in and use the app normally for 2-3 minutes (navigate between screens, open chats, etc.)
  3. Verify the app does not crash with Fatal signal 6 (SIGABRT) in logcat
  4. Check logcat: adb logcat | grep -i "hermes-sampling" — the thread should be running without crashes
  5. (Optional) Enable Sentry debug mode and verify Integration installed: HermesProfiling appears in logs and profiling data is being sent
  6. Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

elirangoshen and others added 5 commits March 13, 2026 12:02
…ndroid

Patch 029: Fix JNI copy-paste bug where HermesSamplingProfiler.disable() was
mapped to ::enable instead of ::disable, preventing the profiler from ever
being properly stopped.

Patch 030: Add doLast hook to unzipHermes Gradle task that replaces pthread_kill
with tgkill syscall in SamplingProfilerPosix.cpp. On Android (Bionic), pthread_kill
aborts on invalid pthread_t instead of returning ESRCH. The Gradle hook approach
ensures the fix survives Hermes source re-extraction during builds.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@codecov

codecov Bot commented Mar 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/setup/telemetry/setupSentry.ts 0.00% <0.00%> (ø)
... and 19 files with indirect coverage changes

@elirangoshen

elirangoshen commented Mar 16, 2026 •

Copy link
Copy Markdown
Contributor Author

As its patch of hermes its not trivial to checkout it and test it in dev, as I needed to do extra steps to do it, it wont work without those steps, so Id like to trigger staging build and than we can test it from there ?

I attach instructions how to test it with dev locally but I hope we can produce build instead

How to test locally on dev (workaround)

Building from source doesn't work locally due to a pre-existing react-native-worklets linker error (unrelated to our patches). The prebuilt artifacts don't include our patches yet. So we need to build Hermes
separately, then swap it into a working APK.

Step 1: Build the patched libhermes.so

Set forceBuildFromSource=true in Mobile-Expensify/Android/gradle.properties:
patchedArtifacts.forceBuildFromSource=true

Run yarn android --local. It will fail on the worklets linker step, but Hermes will have been compiled successfully before that. The patched libhermes.so will be at:
node_modules/react-native/ReactAndroid/hermes-engine/build/intermediates/merged_native_libs/debug/mergeDebugNativeLibs/out/lib/arm64-v8a/libhermes.so

Set forceBuildFromSource back to false.

Step 2: Build a working HybridApp APK

Temporarily move our patches aside so the hash matches the existing prebuilt:
mv patches/react-native/react-native+0.81.4+030+fix-hermes-sampling-profiler-disable.patch /tmp/
mv patches/react-native/react-native+0.81.4+031+fix-hermes-sampling-profiler-pthread-kill-crash.patch /tmp/

Build normally:
yarn android --local

Restore the patches:
mv /tmp/react-native+0.81.4+030+fix-hermes-sampling-profiler-disable.patch patches/react-native/
mv /tmp/react-native+0.81.4+031+fix-hermes-sampling-profiler-pthread-kill-crash.patch patches/react-native/

Step 3: Swap libhermes.so in the APK

APK=Mobile-Expensify/Android/build/outputs/apk/debug/Expensify-debug.apk
PATCHED_HERMES=node_modules/react-native/ReactAndroid/hermes-engine/build/intermediates/merged_native_libs/debug/mergeDebugNativeLibs/out/lib/arm64-v8a/libhermes.so
ZIPALIGN=$(find ~/Library/Android/sdk -name "zipalign" | head -1)
APKSIGNER=$(find ~/Library/Android/sdk -name "apksigner" | head -1)

Copy APK

cp "$APK" /tmp/hybrid-patched.apk

Remove old signing

zip -d /tmp/hybrid-patched.apk "META-INF/*"

Replace libhermes.so (must be stored uncompressed)

mkdir -p /tmp/lib/arm64-v8a
cp "$PATCHED_HERMES" /tmp/lib/arm64-v8a/libhermes.so
cd /tmp && zip -0 -u /tmp/hybrid-patched.apk lib/arm64-v8a/libhermes.so

Zipalign then sign (order matters — sign AFTER align)

$ZIPALIGN -p -f 4 /tmp/hybrid-patched.apk /tmp/hybrid-patched-aligned.apk
$APKSIGNER sign --ks /tmp/debug.keystore --ks-pass pass:android --ks-key-alias androiddebugkey /tmp/hybrid-patched-aligned.apk

If you don't have a debug keystore, generate one:
keytool -genkey -v -keystore /tmp/debug.keystore -alias androiddebugkey -keyalg RSA -keysize 2048 -validity 10000 -storepass android -keypass android -dname "CN=Android Debug,O=Android,C=US"

Step 4: Install on device/emulator

adb install /tmp/hybrid-patched-aligned.apk

Then start Metro with yarn start and test.

Note: This workaround is only needed for local dev testing. CI/staging builds might work automatically — the PatchedArtifacts system will detect the new patch hash, build from source in CI (which has a clean
environment), and publish new prebuilt artifacts.

@elirangoshen
elirangoshen marked this pull request as ready for review March 16, 2026 14:03
@elirangoshen
elirangoshen requested review from a team as code owners March 16, 2026 14:03
@melvin-bot
melvin-bot Bot requested review from jasperhuangg and joekaufmanexpensify and removed request for a team March 16, 2026 14:03
@melvin-bot

melvin-bot Bot commented Mar 16, 2026

Copy link
Copy Markdown

@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team March 16, 2026 14:03

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6fb0a82177

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

}
}
into(hermesDir)
+ doLast {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Ensure Hermes source patch runs on up-to-date builds

Attaching the fix only inside doLast means it executes only when unzipHermes actually runs; Gradle skips task actions when a task is UP-TO-DATE, so cached workspaces/CI agents that already extracted Hermes before this change can keep using an unpatched SamplingProfilerPosix.cpp and still hit the Android SIGABRT path. This should either force rerun/invalidated outputs for unzipHermes or fail fast if the expected replacements are not present.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got this input:

In practice, the risk is low because:

  • CI always starts clean → unzipHermes always runs
  • npm install freshens node_modules → extraction happens
  • The if (!content.contains("currentTid_")) guard makes it idempotent when it does run

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@jasperhuangg
jasperhuangg removed their request for review March 16, 2026 17:29
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84708.

Android 🤖 iOS 🍎
❌ FAILED ❌ https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-f81201a-5a38169-1e7673d930fb2812eee35199f151f3506a98b29a/index.html
The QR code can't be generated, because the Android build failed iOS
Web 🕸️
https://84708.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@elirangoshen

elirangoshen commented Mar 19, 2026 •

Copy link
Copy Markdown
Contributor Author

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪 Built from App PR #84708.

Android 🤖 iOS 🍎
❌ FAILED ❌ https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-f81201a-5a38169-1e7673d930fb2812eee35199f151f3506a98b29a/index.html
The QR code can't be generated, because the Android build failed iOS
Web 🕸️
https://84708.pr-testing.expensify.com
Web
👀 View the workflow run that generated this build 👀

I think same issue , so maybe you can execute it without the rock cache

@rlinoz

rlinoz commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

oh I did, but let's run it again

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84708.

Android 🤖 iOS 🍎
❌ FAILED ❌ ⏩ SKIPPED ⏩
The QR code can't be generated, because the Android build failed The build for iOS was skipped
Web 🕸️
⏩ SKIPPED ⏩
The build for Web was skipped

👀 View the workflow run that generated this build 👀

@rlinoz

rlinoz commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Build is failing with:

■  [PatchedArtifacts] No matching artifacts version found for react-hybrid. Building react-native from source.
│  The NODE_ENV environment variable is required but was not specified. Ensure the project is bundled with Expo CLI or NODE_ENV is set. Using only .env.local and .env
│  No modules to process in combine-js-to-schema-cli. If this is unexpected, please check if you set up your NativeComponent correctly. See combine-js-to-schema.js for how codegen finds modules.
│  No modules to process in combine-js-to-schema-cli. If this is unexpected, please check if you set up your NativeComponent correctly. See combine-js-to-schema.js for how codegen finds modules.
│  No modules to process in combine-js-to-schema-cli. If this is unexpected, please check if you set up your NativeComponent correctly. See combine-js-to-schema.js for how codegen finds modules.
│  No modules to process in combine-js-to-schema-cli. If this is unexpected, please check if you set up your NativeComponent correctly. See combine-js-to-schema.js for how codegen finds modules.
│  No modules to process in combine-js-to-schema-cli. If this is unexpected, please check if you set up your NativeComponent correctly. See combine-js-to-schema.js for how codegen finds modules.
│  No modules to process in combine-js-to-schema-cli. If this is unexpected, please check if you set up your NativeComponent correctly. See combine-js-to-schema.js for how codegen finds modules.
│  Warning: This version only understands SDK XML versions up to 3 but an SDK XML file of version 4 was encountered. This can happen if you use versions of Android Studio and the command-line tools that were released at different times.
│  /home/runner/_work/App/App/node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactActivityDelegate.java:120: warning: [dep-ann] deprecated item is not annotated with @Deprecated
│    public ReactInstanceManager getReactInstanceManager() {
│                                ^

Let's try to merge main @elirangoshen

@elirangoshen

Copy link
Copy Markdown
Contributor Author

Build is failing with:

■  [PatchedArtifacts] No matching artifacts version found for react-hybrid. Building react-native from source.
│  The NODE_ENV environment variable is required but was not specified. Ensure the project is bundled with Expo CLI or NODE_ENV is set. Using only .env.local and .env
│  No modules to process in combine-js-to-schema-cli. If this is unexpected, please check if you set up your NativeComponent correctly. See combine-js-to-schema.js for how codegen finds modules.
│  No modules to process in combine-js-to-schema-cli. If this is unexpected, please check if you set up your NativeComponent correctly. See combine-js-to-schema.js for how codegen finds modules.
│  No modules to process in combine-js-to-schema-cli. If this is unexpected, please check if you set up your NativeComponent correctly. See combine-js-to-schema.js for how codegen finds modules.
│  No modules to process in combine-js-to-schema-cli. If this is unexpected, please check if you set up your NativeComponent correctly. See combine-js-to-schema.js for how codegen finds modules.
│  No modules to process in combine-js-to-schema-cli. If this is unexpected, please check if you set up your NativeComponent correctly. See combine-js-to-schema.js for how codegen finds modules.
│  No modules to process in combine-js-to-schema-cli. If this is unexpected, please check if you set up your NativeComponent correctly. See combine-js-to-schema.js for how codegen finds modules.
│  Warning: This version only understands SDK XML versions up to 3 but an SDK XML file of version 4 was encountered. This can happen if you use versions of Android Studio and the command-line tools that were released at different times.
│  /home/runner/_work/App/App/node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactActivityDelegate.java:120: warning: [dep-ann] deprecated item is not annotated with @Deprecated
│    public ReactInstanceManager getReactInstanceManager() {
│                                ^

Let's try to merge main @elirangoshen

done

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@rlinoz rlinoz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well for me, is there an upstream patch too?

@Julesssss

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@Julesssss Julesssss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just held on this.

@Julesssss
Julesssss merged commit d05d2a0 into Expensify:main Mar 19, 2026
39 of 40 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@elirangoshen

Copy link
Copy Markdown
Contributor Author

Tests well for me, is there an upstream patch too?

No, I will make one

@Julesssss

Copy link
Copy Markdown
Contributor

Tests well for me, is there an upstream patch too?

Lets use this issue

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.41-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@elirangoshen

Copy link
Copy Markdown
Contributor Author

Tests well for me, is there an upstream patch too?

Lets use this issue

Sure, can you assign it to me ?

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants