Skip to content

[Due for payment 2026-05-13] Android - Chat - Suggestion list is cut off on the left in landscape mode #88484

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.61-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #87350
Email or phone of affected tester (no customers): sdsodijnosdjoij@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Chat Report View

Action Performed:

  1. Launch Expensify app.
  2. Go to workspace chat.
  3. Rotate device to landscape.
  4. Type @ or :sm

Expected Result:

Suggestion list will not cut off on the left.

Actual Result:

Suggestion list is cut off on the left in landscape mode.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7135135_1776798682675.Screen_Recording_20260422_030852_Expensify.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 21, 2026
  2. melvin-bot commented on Apr 21, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #87350

  3. melvin-bot commented on Apr 21, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Apr 21, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. OSBotify commented on Apr 21, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #87350 - "Fix Suggestion modal appear at the bottom and blocks composer" by @GCyganek (High confidence)
    Related Issues: #87309, #87360 (the issues #87350 was fixing)

    Recommendation: REVERT

    PR #87350 introduced a regression: while attempting to fix the suggestion modal appearing at the bottom in landscape mode, it broke the horizontal positioning of the suggestion list, causing it to be cut off on the left side in landscape mode on Android.

    Assigned: @GCyganek (PR author), @truph01 and @mjasikowski (approving reviewers)
    Labels: No label changes needed — DeployBlockerCash is correct since the fix must happen in the App. No DeployBlocker label is present to remove.

    Detailed Analysis

    Evidence

    Verification

    • The affected files are in src/components/AutoCompleteSuggestions/index.tsx and related portal files.
    • PR Fix Suggestion modal appear at the bottom and blocks composer #87350 modifies these exact files: src/components/AutoCompleteSuggestions/index.tsx, AutoCompleteSuggestionsPortal/index.native.tsx, AutoCompleteSuggestionsPortal/types.ts, and the getBottomSuggestionPadding variants.

    Root Cause

    The PR introduced a getLeftOffset helper function that subtracts leftInset (safe area inset from the left) from the x coordinate when in landscape mode on narrow layouts: isInLandscapeMode ? x - leftInset : x. On Android in landscape mode, the safe area left inset is non-zero (due to the device's notch/camera cutout), so subtracting it from the already-measured x position of the cursor results in a negative or too-small left offset, causing the suggestion list to be rendered partially or fully off-screen to the left.

  6. MelvinBot commented on Apr 21, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    PR #87350 introduced getLeftOffset which subtracts leftInset from the x coordinate in landscape mode on narrow layouts:

    return isInLandscapeMode ? x - leftInset : x;
    

    On Android, measureInWindow already returns window-relative coordinates (excluding system bars/notch), so x does not include the safe area inset. Subtracting leftInset double-compensates, pushing the suggestion popup off the left edge of the screen.

    What changes do you think we should make in order to solve the problem?

    The leftInset subtraction in getLeftOffset should be made platform-specific. On Android, the landscape branch should just return x (same as portrait). If the subtraction is needed on iOS to account for different measureInWindow behavior, it should only apply there — either via a platform-specific file or a Platform.OS check.

    What alternative solutions did you explore? (Optional)

    An alternative would be reverting the landscape-specific logic from PR #87350 entirely, but that may re-introduce the original issue that PR was solving on iOS. A platform-specific approach is more targeted.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. 12 remaining items

  8. melvin-bot commented on May 6, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on May 6, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.67-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-13. 🎊

    For reference, here are some details about the assignees on this issue:

    • @GCyganek does not require payment (Contractor)
    • @truph01 requires payment through NewDot Manual Requests
  10. melvin-bot commented on May 6, 2026

    @melvin-bot

    @truph01 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. melvin-bot commented on May 12, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  12. melvin-bot commented on May 13, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @GCyganek does not require payment (Contractor)
    • Reviewer: @truph01 owed $250 via NewDot

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  13. melvin-bot commented on May 15, 2026

    @melvin-bot

    @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  14. mallenexpensify commented on May 15, 2026

    @mallenexpensify
    Contributor

    Closing, @truph01 if this should be considered for reduced pay on an issue/project, please address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions