You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-13] Android - Chat - Suggestion list is cut off on the left in landscape mode #88484
Version Number: 9.3.61-1 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#87350 Email or phone of affected tester (no customers):sdsodijnosdjoij@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Samsung Galaxy S25 FE / Android 16 App Component: Chat Report View
Action Performed:
Launch Expensify app.
Go to workspace chat.
Rotate device to landscape.
Type @ or :sm
Expected Result:
Suggestion list will not cut off on the left.
Actual Result:
Suggestion list is cut off on the left in landscape mode.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #87350 - "Fix Suggestion modal appear at the bottom and blocks composer" by @GCyganek (High confidence) Related Issues: #87309, #87360 (the issues #87350 was fixing)
Recommendation: REVERT
PR #87350 introduced a regression: while attempting to fix the suggestion modal appearing at the bottom in landscape mode, it broke the horizontal positioning of the suggestion list, causing it to be cut off on the left side in landscape mode on Android.
Assigned: @GCyganek (PR author), @truph01 and @mjasikowski (approving reviewers) Labels: No label changes needed — DeployBlockerCash is correct since the fix must happen in the App. No DeployBlocker label is present to remove.
The affected files are in src/components/AutoCompleteSuggestions/index.tsx and related portal files.
PR Fix Suggestion modal appear at the bottom and blocks composer #87350 modifies these exact files: src/components/AutoCompleteSuggestions/index.tsx, AutoCompleteSuggestionsPortal/index.native.tsx, AutoCompleteSuggestionsPortal/types.ts, and the getBottomSuggestionPadding variants.
Root Cause
The PR introduced a getLeftOffset helper function that subtracts leftInset (safe area inset from the left) from the x coordinate when in landscape mode on narrow layouts: isInLandscapeMode ? x - leftInset : x. On Android in landscape mode, the safe area left inset is non-zero (due to the device's notch/camera cutout), so subtracting it from the already-measured x position of the cursor results in a negative or too-small left offset, causing the suggestion list to be rendered partially or fully off-screen to the left.
PR #87350 introduced getLeftOffset which subtracts leftInset from the x coordinate in landscape mode on narrow layouts:
return isInLandscapeMode ? x - leftInset : x;
On Android, measureInWindow already returns window-relative coordinates (excluding system bars/notch), so x does not include the safe area inset. Subtracting leftInset double-compensates, pushing the suggestion popup off the left edge of the screen.
What changes do you think we should make in order to solve the problem?
The leftInset subtraction in getLeftOffset should be made platform-specific. On Android, the landscape branch should just return x (same as portrait). If the subtraction is needed on iOS to account for different measureInWindow behavior, it should only apply there — either via a platform-specific file or a Platform.OS check.
What alternative solutions did you explore? (Optional)
An alternative would be reverting the landscape-specific logic from PR #87350 entirely, but that may re-introduce the original issue that PR was solving on iOS. A platform-specific approach is more targeted.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.67-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@truph01 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Apr 21, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #87350
melvin-bot commentedon Apr 21, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 21, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Apr 21, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #87350 - "Fix Suggestion modal appear at the bottom and blocks composer" by @GCyganek (High confidence)
Related Issues: #87309, #87360 (the issues #87350 was fixing)
Recommendation: REVERT
PR #87350 introduced a regression: while attempting to fix the suggestion modal appearing at the bottom in landscape mode, it broke the horizontal positioning of the suggestion list, causing it to be cut off on the left side in landscape mode on Android.
Assigned: @GCyganek (PR author), @truph01 and @mjasikowski (approving reviewers)
Labels: No label changes needed —
DeployBlockerCashis correct since the fix must happen in the App. NoDeployBlockerlabel is present to remove.Detailed Analysis
Evidence
AutoCompleteSuggestionscomponent and its landscape mode layout logic — exactly the area the bug is reported in.Verification
src/components/AutoCompleteSuggestions/index.tsxand related portal files.src/components/AutoCompleteSuggestions/index.tsx,AutoCompleteSuggestionsPortal/index.native.tsx,AutoCompleteSuggestionsPortal/types.ts, and thegetBottomSuggestionPaddingvariants.Root Cause
The PR introduced a
getLeftOffsethelper function that subtractsleftInset(safe area inset from the left) from thexcoordinate when in landscape mode on narrow layouts:isInLandscapeMode ? x - leftInset : x. On Android in landscape mode, the safe area left inset is non-zero (due to the device's notch/camera cutout), so subtracting it from the already-measuredxposition of the cursor results in a negative or too-small left offset, causing the suggestion list to be rendered partially or fully off-screen to the left.MelvinBot commentedon Apr 21, 2026
Proposal
What is the root cause of that problem?
PR #87350 introduced
getLeftOffsetwhich subtractsleftInsetfrom thexcoordinate in landscape mode on narrow layouts:On Android,
measureInWindowalready returns window-relative coordinates (excluding system bars/notch), soxdoes not include the safe area inset. SubtractingleftInsetdouble-compensates, pushing the suggestion popup off the left edge of the screen.What changes do you think we should make in order to solve the problem?
The
leftInsetsubtraction ingetLeftOffsetshould be made platform-specific. On Android, the landscape branch should just returnx(same as portrait). If the subtraction is needed on iOS to account for differentmeasureInWindowbehavior, it should only apply there — either via a platform-specific file or aPlatform.OScheck.What alternative solutions did you explore? (Optional)
An alternative would be reverting the landscape-specific logic from PR #87350 entirely, but that may re-introduce the original issue that PR was solving on iOS. A platform-specific approach is more targeted.
Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.12 remaining items
melvin-bot commentedon May 6, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 6, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.67-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 6, 2026
@truph01 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon May 12, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon May 13, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
melvin-bot commentedon May 15, 2026
@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
mallenexpensify commentedon May 15, 2026
Closing, @truph01 if this should be considered for reduced pay on an issue/project, please address.