You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-11] [IOURequestStepScan Decomposition] feat: extract Camera component + MultiScan context #89382
Camera and multi-scan behavior live inside the monolithic scan screen, which blocks a thin router and path-specific subscriptions.
Solution
Introduce new building blocks only (no wiring yet): Camera (web/native/capture/upload splits), MultiScanContext + MultiScanEducationalModal, and useScanRouteParams, all under IOURequestStepScan/ as described in the plan.
changed the title [-][IOURequestStepScan Decomposition] feat: extract Camera component + MultiScan context[/-][+][Due for payment 2026-05-11] [IOURequestStepScan Decomposition] feat: extract Camera component + MultiScan context[/+]on May 4, 2026
I think this is too general (not sure what word to use). In this case, no tests were needed because the PR was preparing some new components that will be wired up in the next one, but it involved a lot of code-only review.
This PR wasn't a typical "no QA" review. It laid the foundation for refactoring a critical part of the scan feature — the architectural decisions made here (the Camera web/native split, the MultiScan context design) carried significant downstream impact across the remaining decomposition PRs, and reviewing them properly required a thorough, code-heavy review rather than a light pass.
That said, I also agree that $125 as the general rate for no-QA PRs is totally fair — this is an exception based on the depth of review required, not a reason to revisit the baseline.
One thing for next time: this kind of discussion is best had between the C+ and the internal engineer before the PR reaches the payment phase, so the compensation is settled up front rather than relitigated afterward.
Activity
[-][IOURequestStepScan Decomposition] feat: extract Camera component + MultiScan context[/-][+][Due for payment 2026-05-11] [IOURequestStepScan Decomposition] feat: extract Camera component + MultiScan context[/+]melvin-bot commentedon May 4, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".13 remaining items
bernhardoj commentedon May 12, 2026
@cristipaval should this be paid per sub-issue or later, after the whole refactor is done?
(asking because the first PR issue is closed without payment yet)
cristipaval commentedon May 12, 2026
oh sorry. I created the subissues after a few PRs had already been merged.
I'd prefer to pay each subissue instead of spending time at the end looking back.
@bernhardoj, could you please comment on the one that has not been paid yet? 🙏Found it, asked here for payment.bernhardoj commentedon May 13, 2026
Got it. Requested in ND.
flaviadefaria commentedon May 18, 2026
$125 approved for @bernhardoj
bernhardoj commentedon Jun 6, 2026
I just realized the payment here is $125. @mallenexpensify Can I request the other half? 😅
mallenexpensify commentedon Jun 8, 2026
@bernhardoj No tests were needed so it should be $125, correct? Per the C+ doc
bernhardoj commentedon Jun 9, 2026
@mallenexpensify ah, I see.
I think this is too general (not sure what word to use). In this case, no tests were needed because the PR was preparing some new components that will be wired up in the next one, but it involved a lot of code-only review.
mallenexpensify commentedon Jun 9, 2026
@bernhardoj pinged ya in Slack to discuss, will leave this open for now
bernhardoj commentedon Jun 11, 2026
@cristipaval do you agree to increase this to $250 with the reasoning above?
cristipaval commentedon Jun 11, 2026
I agree to increase this one to $250.
This PR wasn't a typical "no QA" review. It laid the foundation for refactoring a critical part of the scan feature — the architectural decisions made here (the Camera web/native split, the MultiScan context design) carried significant downstream impact across the remaining decomposition PRs, and reviewing them properly required a thorough, code-heavy review rather than a light pass.
That said, I also agree that $125 as the general rate for no-QA PRs is totally fair — this is an exception based on the depth of review required, not a reason to revisit the baseline.
One thing for next time: this kind of discussion is best had between the C+ and the internal engineer before the PR reaches the payment phase, so the compensation is settled up front rather than relitigated afterward.
mallenexpensify commentedon Jun 11, 2026
@bernhardoj paid, summary updated above. Thx.
bernhardoj commentedon Jun 12, 2026
Thanks! Requested another $125
flaviadefaria commentedon Jun 16, 2026
Approved @bernhardoj another $125.