Skip to content

[Due for payment 2026-05-11] [IOURequestStepScan Decomposition] feat: extract Camera component + MultiScan context #89382

Closed

Description

@cristipaval

Part of IOURequestStepScan Decomposition Plan — see rinej's split design comment.

Parent: #85583

Problem

Camera and multi-scan behavior live inside the monolithic scan screen, which blocks a thin router and path-specific subscriptions.

Solution

Introduce new building blocks only (no wiring yet): Camera (web/native/capture/upload splits), MultiScanContext + MultiScanEducationalModal, and useScanRouteParams, all under IOURequestStepScan/ as described in the plan.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added and removed
    ReviewingHas a PR in review
    on May 4, 2026
  2. changed the title [-][IOURequestStepScan Decomposition] feat: extract Camera component + MultiScan context[/-] [+][Due for payment 2026-05-11] [IOURequestStepScan Decomposition] feat: extract Camera component + MultiScan context[/+] on May 4, 2026
  3. melvin-bot commented on May 4, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  4. 13 remaining items

  5. bernhardoj commented on May 12, 2026

    @bernhardoj
    Contributor

    @cristipaval should this be paid per sub-issue or later, after the whole refactor is done?

    (asking because the first PR issue is closed without payment yet)

  6. cristipaval commented on May 12, 2026

    @cristipaval
    ContributorAuthor

    oh sorry. I created the subissues after a few PRs had already been merged.

    I'd prefer to pay each subissue instead of spending time at the end looking back.

    @bernhardoj, could you please comment on the one that has not been paid yet? 🙏 Found it, asked here for payment.

  7. bernhardoj commented on May 13, 2026

    @bernhardoj
    Contributor

    Got it. Requested in ND.

  8. flaviadefaria commented on May 18, 2026

    @flaviadefaria
    Contributor

    $125 approved for @bernhardoj

  9. bernhardoj commented on Jun 6, 2026

    @bernhardoj
    Contributor

    I just realized the payment here is $125. @mallenexpensify Can I request the other half? 😅

  10. mallenexpensify commented on Jun 8, 2026

    @mallenexpensify
    Contributor

    I just realized the payment here is $125. @mallenexpensify Can I request the other half? 😅

    @bernhardoj No tests were needed so it should be $125, correct? Per the C+ doc

    PR review where testing isn’t involved $125 ie. here

    Image
  11. bernhardoj commented on Jun 9, 2026

    @bernhardoj
    Contributor

    @mallenexpensify ah, I see.

    PR review where testing isn’t involved $125

    I think this is too general (not sure what word to use). In this case, no tests were needed because the PR was preparing some new components that will be wired up in the next one, but it involved a lot of code-only review.

  12. mallenexpensify commented on Jun 9, 2026

    @mallenexpensify
    Contributor

    @bernhardoj pinged ya in Slack to discuss, will leave this open for now

  13. bernhardoj commented on Jun 11, 2026

    @bernhardoj
    Contributor

    @cristipaval do you agree to increase this to $250 with the reasoning above?

  14. cristipaval commented on Jun 11, 2026

    @cristipaval
    ContributorAuthor

    I agree to increase this one to $250.

    This PR wasn't a typical "no QA" review. It laid the foundation for refactoring a critical part of the scan feature — the architectural decisions made here (the Camera web/native split, the MultiScan context design) carried significant downstream impact across the remaining decomposition PRs, and reviewing them properly required a thorough, code-heavy review rather than a light pass.

    That said, I also agree that $125 as the general rate for no-QA PRs is totally fair — this is an exception based on the depth of review required, not a reason to revisit the baseline.

    One thing for next time: this kind of discussion is best had between the C+ and the internal engineer before the PR reaches the payment phase, so the compensation is settled up front rather than relitigated afterward.

  15. mallenexpensify commented on Jun 11, 2026

    @mallenexpensify
    Contributor

    @bernhardoj paid, summary updated above. Thx.

  16. bernhardoj commented on Jun 12, 2026

    @bernhardoj
    Contributor

    Thanks! Requested another $125

  17. flaviadefaria commented on Jun 16, 2026

    @flaviadefaria
    Contributor

    Approved @bernhardoj another $125.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions