Skip to content

[Due for payment 2026-11-19] Standardize Expense Report and Expense header with predictable button placement and carousel counter #90366

Closed

Description

@shawnborton

We have mixed styles for showing the carousel counter on the expense report header as well as the expense header. Sometimes the carousel counter has a "X of X" label, though it doesn't on expenses. We also don't always show the expense carousel counter when you view expenses from the Spend page - we only show it when you view an expense from within an expense report.

We also show the carousel counter buttons on the same line as the next steps, which feels counter intuitive given that the carousel counter is more of a parent item not attached to next steps.

We'd like to standardize on the buttons here across the two types: expense reports and expenses:

Image

Notable changes:

  • Let's move the report buttons to be down near the report next steps, on the same vertical line
  • Let's always have the carousel buttons in the top right
  • Let's make sure we always show the carousel for expenses when you access expenses from the Spend page, the same way you see a carousel when accessing Reports from the Reports page

Once we have this framework in place, we'll be able to do things like launch a violation fixer from Home that will always have a consistent carousel button placement.

cc @JmillsExpensify @trjExpensify @dannymcclain @dubielzyk-expensify

Issue OwnerCurrent Issue Owner: @thelullabyy

Activity

  1. shawnborton commented on May 12, 2026

    @shawnborton
    ContributorAuthor

    Discussed in Slack, @thelullabyy will implement and @ShridharGoel will review.

  2. added
    ExternalAdded to denote the issue can be worked on by a contributor
    NewFeatureSomething to build that is a new item.
    on May 12, 2026
  3. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 12, 2026
  4. KJ21-ENG commented on May 12, 2026

    @KJ21-ENG
  5. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 12, 2026
  6. thelullabyy commented on May 17, 2026

    @thelullabyy
    Contributor

    @ShridharGoel PR is ready for review

  7. 181 remaining items

  8. ShridharGoel commented on Nov 18, 2026

    @ShridharGoel
    Contributor

    Regression Test Proposal

    • Go to https://staging.new.expensify.com and log in with an account that has a workspace with at least 3 expense reports (in different states, e.g. submitted, approved, paid) and at least one report with 3 or more expenses
    • Go to Spend, open Reports and open any expense report
    • Verify the report action buttons (e.g. Submit, Approve, Pay) are placed below the header title, on the same vertical line as the next steps
    • Verify the carousel counter with previous and next arrows is in the top right of the header
    • Use the arrows to navigate between reports and verify the counter always shows the correct position (e.g. 2 of 5) and every report from the list can be opened
    • Go to Spend, open Expenses and open any expense
    • Verify the expense header shows the same carousel counter and arrows in the top right
    • Use the arrows to navigate between expenses and verify every expense from the list can be opened
    • Open an expense from inside an expense report and verify the carousel counter works the same way as when opened from Spend

    Do we agree 👍 or 👎

  9. ShridharGoel commented on Nov 18, 2026

    @ShridharGoel
    Contributor

    Price increase request

    Mandatory

    Proposed amount: $750

    Why the work exceeded the issue: The task was complex. The issue was scoped as a single header-layout change, but the work ran multiple months through five merged PRs (#90403, #97005, #98611, #100331, #105889). Three of those PRs were fully reverted after deploy blockers and had to be re-implemented from scratch, and the final PR spans 53 files (+3,010/−520). Four more PRs (#103523, #103526, #104498, #104499) fixed the demoted blockers under the follow-up issue #103200.

    Regressions caused by this PR: Multiple deploy blockers across the three reverted attempts (#96545, #96548, #96563, #96566, #96575, #98192, #98193, #98196, #98200, #98329, #99609, #99611, #99612, #99614, #99616, #99617, #99619, #99621, #99627, #99630, #99636, #99641). Few other blockers linked to the last PR were demoted to follow-up issue #103200.

    Considering the complexity of the task and then applying the regression penalties, $750 seems to be a good spot. Do we agree?

    CC: @mallenexpensify @JS00001

  10. JS00001 commented on Nov 18, 2026

    @JS00001
    Contributor

    This seems fair to me

  11. expensify-chore-bot commented on Nov 18, 2026

    @expensify-chore-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  12. mallenexpensify commented on Nov 20, 2026

    @mallenexpensify
    Contributor

    Claude posting on behalf of Matt:

    Your call. Job price: $250 (Help Wanted, both assigned 2026-05-12).

    • thelullabyy (Contributor): 300%, via NewDot
    • ShridharGoel (C+): 300%, via NewDot

    Both: asked for $750. JS00001 ruled it fair. ShridharGoel posted the request.

    ShridharGoel is on the BEC list. BECs get no per-issue pay. I don't know when ShridharGoel joined.

    Next: decide on ShridharGoel, then pay. Caps+Y does not read the test steps in a plain comment.

    Evidence
    • Five PRs by thelullabyy, reviewed by ShridharGoel: 90403, 97005, 98611, 100331, 105889. Last production 2026-11-12.
    • Three were reverted: 96636, 98346, 99675. 27 deploy blockers in all. The request lists them.
    • Regression test steps: comment, not a C+ checklist.
    • The request also counts the follow-up work on 103200.

    PAYPREP v1

  13. ShridharGoel commented on Nov 20, 2026

    @ShridharGoel
    Contributor

    This was started before joining the BEC team. No BE hours were counted for this.

  14. mallenexpensify commented on Nov 20, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @thelullabyy due $750 via NewDot
    Contributor+: @ShridharGoel due $750 via NewDot

    @ShridharGoel , @JS00001 , do we want a test case here? QA can check design-related ones monthly (if you think it's worth it)

  15. ShridharGoel commented on Nov 21, 2026

    @ShridharGoel
    Contributor

    Yes I think this can be added: #90366 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions